[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1083 ---

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-31 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r165023581 --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestJoinNullable.java --- @@ -568,6 +570,22 @@ public void nullMixedComparatorEqualJoinHelper(final

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-12 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r161205848 --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestJoinNullable.java --- @@ -568,6 +570,22 @@ public void

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-11 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160996060 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java --- @@ -424,6 +429,23 @@ public MetadataContext getMetaContext()

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-11 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160997779 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java --- @@ -250,20 +250,12 @@ private boolean

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-11 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160936248 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/SchemalessScan.java --- @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-10 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160717181 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java --- @@ -250,20 +250,12 @@ private boolean

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-10 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160711830 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/SchemalessScan.java --- @@ -0,0 +1,90 @@ +/* + * Licensed to

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-10 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160712431 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java --- @@ -424,6 +429,23 @@ public MetadataContext

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-10 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160685002 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java --- @@ -250,20 +250,12 @@ private boolean

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-10 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160666020 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/BaseTestQuery.java --- @@ -119,6 +125,15 @@ public static void setupDefaultTestCluster()

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-10 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160663414 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/SchemalessScan.java --- @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-10 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160663989 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/TestEmptyInputSql.java --- @@ -177,4 +177,33 @@ public void testQueryEmptyCsv() throws

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-10 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160664191 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetGroupScan.java --- @@ -56,65 +56,50 @@ private void

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-10 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160663507 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/RefreshMetadataHandler.java --- @@ -78,19 +78,24 @@ public PhysicalPlan

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-10 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160663899 --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java --- @@ -1197,4 +1197,64 @@ public void testFieldWithDots() throws Exception {

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-10 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160666274 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/BaseTestQuery.java --- @@ -119,6 +125,15 @@ public static void setupDefaultTestCluster()

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-09 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160525590 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetGroupScan.java --- @@ -56,65 +56,50 @@ private void

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-09 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160525146 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/BaseTestQuery.java --- @@ -119,6 +125,15 @@ public static void

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-09 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160526940 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java --- @@ -250,20 +250,12 @@ private boolean

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-09 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160524662 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/SchemalessScan.java --- @@ -0,0 +1,80 @@ +/* + * Licensed to

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-09 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160525926 --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java --- @@ -1197,4 +1197,64 @@ public void testFieldWithDots() throws

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-09 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160525739 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/TestEmptyInputSql.java --- @@ -177,4 +177,33 @@ public void testQueryEmptyCsv() throws

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-09 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160524828 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/RefreshMetadataHandler.java --- @@ -78,19 +78,24 @@ public

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-09 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1083#discussion_r160525303 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/BaseTestQuery.java --- @@ -119,6 +125,15 @@ public static void

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

2018-01-04 Thread vdiravka
GitHub user vdiravka opened a pull request: https://github.com/apache/drill/pull/1083 DRILL-4185: UNION ALL involving empty directory on any side of union … …all results in Failed query SchemaLessTable, SchemaLessScan, SchemaLessBatchCreator, SchemaLessBatch classes are