[GitHub] drill pull request #1228: DRILL-6307: Handle empty batches in record batch s...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1228#discussion_r184590500 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -536,6 +556,11 @@ public ColumnSize getColumn(String

[GitHub] drill pull request #1228: DRILL-6307: Handle empty batches in record batch s...

Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1228#discussion_r184483395 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -536,6 +556,11 @@ public ColumnSize getColumn(String name)

[GitHub] drill pull request #1228: DRILL-6307: Handle empty batches in record batch s...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1228#discussion_r184264961 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -536,6 +556,11 @@ public ColumnSize getColumn(String

[GitHub] drill pull request #1228: DRILL-6307: Handle empty batches in record batch s...

Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1228#discussion_r184258865 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -536,6 +556,11 @@ public ColumnSize getColumn(String name)

[GitHub] drill pull request #1228: DRILL-6307: Handle empty batches in record batch s...

Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1228#discussion_r184236170 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -277,18 +286,29 @@ public boolean isRepeatedList() {

[GitHub] drill pull request #1228: DRILL-6307: Handle empty batches in record batch s...

Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1228#discussion_r184202508 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -536,6 +556,11 @@ public ColumnSize getColumn(String name)

[GitHub] drill pull request #1228: DRILL-6307: Handle empty batches in record batch s...

Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1228#discussion_r184200281 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -277,18 +286,29 @@ public boolean isRepeatedList() {

[GitHub] drill pull request #1228: DRILL-6307: Handle empty batches in record batch s...

Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1228#discussion_r184192443 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -50,7 +50,7 @@ public class RecordBatchSizer {

[GitHub] drill pull request #1228: DRILL-6307: Handle empty batches in record batch s...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1228#discussion_r183264768 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -277,18 +286,29 @@ public boolean isRepeatedList() {

[GitHub] drill pull request #1228: DRILL-6307: Handle empty batches in record batch s...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1228#discussion_r183264235 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -50,7 +50,7 @@ public class RecordBatchSizer {

[GitHub] drill pull request #1228: DRILL-6307: Handle empty batches in record batch s...

GitHub user ppadma opened a pull request: https://github.com/apache/drill/pull/1228 DRILL-6307: Handle empty batches in record batch sizer correctly When we get empty batch, record batch sizer calculates row width as zero. In that case, we do not do accounting and memory allocation