Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/726
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/726#discussion_r97896146
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -179,9 +179,11 @@ connectionStatus_t DrillClientImpl::sendHeartbeat(){
}
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/726#discussion_r97663988
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -1400,22 +1404,6 @@ void DrillClientImpl::handleRead(ByteBuf_t _buf,
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/726#discussion_r97665284
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -179,9 +179,11 @@ connectionStatus_t DrillClientImpl::sendHeartbeat(){
}
GitHub user sudheeshkatkam opened a pull request:
https://github.com/apache/drill/pull/726
DRILL-5218: Support disabling hearbeats from C++ client
+ remove invalid code (server should not request "handshake" type), in
fact, client should fail in that case
You can merge this pull
