Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/906
---
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136440319
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136439631
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -329,9 +326,11 @@ public TypedFieldId
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136445816
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractBinaryRecordBatch.java
---
@@ -0,0 +1,75 @@
+/**
+ * Licensed to the
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136440163
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136446075
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullHolder.java
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136188895
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullVector.java
---
@@ -0,0 +1,267 @@
+/*
+ * Licensed to the Apache
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136188791
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullVector.java
---
@@ -0,0 +1,267 @@
+/*
+ * Licensed to the Apache
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136188197
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullVector.java
---
@@ -0,0 +1,267 @@
+/*
+ * Licensed to the Apache
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136187915
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullVector.java
---
@@ -0,0 +1,267 @@
+/*
+ * Licensed to the Apache
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136187789
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullHolder.java
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136187804
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullHolder.java
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136187598
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullHolder.java
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136186438
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullHolder.java
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136185442
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractSingleRecordBatch.java
---
@@ -125,4 +131,19 @@ public BatchSchema getSchema()
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136185139
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractSingleRecordBatch.java
---
@@ -61,6 +63,10 @@ public IterOutcome innerNext() {
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136184973
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractBinaryRecordBatch.java
---
@@ -0,0 +1,75 @@
+/**
+ * Licensed to the
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136182353
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ProjectPrel.java
---
@@ -35,18 +35,43 @@
import
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136181920
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillScanRel.java
---
@@ -160,12 +161,7 @@ public RelOptCost
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136159563
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136157330
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136157172
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136154993
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136154585
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136152074
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136151330
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136149953
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136149852
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r136143881
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -39,88 +35,107 @@
import
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135979350
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135977556
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -39,88 +35,107 @@
import
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135976739
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/TestEmptyBatchMiniPlan.java
---
@@ -0,0 +1,453 @@
+/*
+ * Licensed to
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135974928
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if (exprHasPrefix
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135974916
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if (exprHasPrefix
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135974905
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if (exprHasPrefix
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135974302
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if (exprHasPrefix
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135974310
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if (exprHasPrefix
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135974133
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if (exprHasPrefix
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135974107
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if (exprHasPrefix
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135925091
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if (exprHasPrefix
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135925006
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if (exprHasPrefix
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135924402
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if (exprHasPrefix
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135924386
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if (exprHasPrefix
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135924412
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if (exprHasPrefix
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135710183
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -329,9 +326,11 @@ public TypedFieldId
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135709915
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -252,14 +235,28 @@ public IterOutcome next() {
}
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135708467
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -152,97 +157,75 @@ public void kill(boolean sendUpstream)
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135578936
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullHolder.java
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135580061
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullVector.java
---
@@ -0,0 +1,267 @@
+/*
+ * Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135577415
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractSingleRecordBatch.java
---
@@ -125,4 +131,19 @@ public BatchSchema
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135578735
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullHolder.java
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135579157
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullVector.java
---
@@ -0,0 +1,267 @@
+/*
+ * Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135574741
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillScanRel.java
---
@@ -160,12 +161,7 @@ public RelOptCost
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135579971
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullVector.java
---
@@ -0,0 +1,267 @@
+/*
+ * Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135575060
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ProjectPrel.java
---
@@ -35,18 +35,43 @@
import
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135578594
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullHolder.java
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135577968
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestEmptyBatchSql.java ---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135577279
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractSingleRecordBatch.java
---
@@ -61,6 +63,10 @@ public IterOutcome innerNext()
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135579027
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullHolder.java
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135577493
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractSingleRecordBatch.java
---
@@ -125,4 +131,19 @@ public BatchSchema
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135579508
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/UntypedNullVector.java
---
@@ -0,0 +1,267 @@
+/*
+ * Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135576938
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractBinaryRecordBatch.java
---
@@ -0,0 +1,75 @@
+/**
+ * Licensed to the
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135424127
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -152,97 +157,75 @@ public void kill(boolean sendUpstream)
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135424090
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -152,97 +157,75 @@ public void kill(boolean sendUpstream)
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135423794
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -152,97 +157,75 @@ public void kill(boolean sendUpstream)
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135382803
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -152,97 +157,75 @@ public void kill(boolean sendUpstream)
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135373441
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -152,97 +157,75 @@ public void kill(boolean sendUpstream)
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135371425
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135367166
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135369535
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135371136
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135370205
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135366734
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -152,97 +157,75 @@ public void kill(boolean
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135368764
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135370016
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135370581
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135368986
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135369170
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -130,562 +145,248 @@ public IterOutcome
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135369225
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -39,88 +35,107 @@
import
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135368337
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -39,88 +35,107 @@
import
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135371013
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -39,88 +35,107 @@
import
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135369394
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -39,88 +35,107 @@
import
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135351183
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -152,97 +157,75 @@ public void kill(boolean sendUpstream)
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135351043
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/Project.java
---
@@ -46,14 +56,18 @@ public Project(@JsonProperty("exprs")
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135351026
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/Project.java
---
@@ -35,9 +35,19 @@
static final org.slf4j.Logger
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r134637327
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/TestEmptyBatchMiniPlan.java
---
@@ -0,0 +1,453 @@
+/*
+ * Licensed to
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r134626985
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r134628709
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r134630528
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r134636771
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r134627805
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r134635590
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r134627033
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r134627882
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r134628593
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r134627196
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -768,4 +765,73 @@ else if
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r134296622
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -152,97 +157,75 @@ public void kill(boolean
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r134305681
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -152,97 +157,75 @@ public void kill(boolean
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r134287754
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/Project.java
---
@@ -46,14 +56,18 @@ public Project(@JsonProperty("exprs")
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r134299304
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
---
@@ -252,14 +235,28 @@ public IterOutcome next() {
1 - 100 of 109 matches
Mail list logo
