Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r141218943
--- Diff: contrib/native/client/src/clientlib/channel.hpp ---
@@ -0,0 +1,237 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140588134
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/TestSSLConfig.java ---
@@ -91,10 +123,35 @@ public void testForTrustStore() throws Exception {
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r141228991
--- Diff: contrib/native/client/src/include/drill/userProperties.hpp ---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r141247355
--- Diff: contrib/native/client/src/clientlib/wincert.ipp ---
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r141245863
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -65,108 +66,70 @@ struct ToRpcType: public
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140593112
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/TestUserBitSSLServer.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r141230974
--- Diff: contrib/native/client/src/clientlib/channel.cpp ---
@@ -0,0 +1,452 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r141215569
--- Diff: contrib/native/client/src/clientlib/channel.hpp ---
@@ -0,0 +1,237 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140590439
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/TestUserBitSSL.java
---
@@ -0,0 +1,338 @@
+/*
+ * Licensed to the
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140621780
--- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicClient.java
---
@@ -120,6 +125,25 @@ protected void initChannel(SocketChannel ch) throws
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140610830
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfig.java ---
@@ -0,0 +1,325 @@
+/*
+ * Licensed to the Apache Software
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140603400
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -126,10 +138,10 @@
String HTTP_SESSION_MEMORY_RESERVATION
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140611274
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfigBuilder.java ---
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140603240
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -110,6 +110,18 @@
String HASHAGG_FALLBACK_ENABLED_KEY =
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140612241
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfigClient.java ---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140602783
--- Diff: distribution/src/resources/drill-override-example.conf ---
@@ -222,7 +222,35 @@ drill.exec: {
# Full workspace name should be indicated
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140611290
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfigBuilder.java ---
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140621875
--- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicServer.java
---
@@ -203,6 +226,9 @@ public void close() throws IOException {
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140602937
--- Diff: distribution/src/resources/drill-override-example.conf ---
@@ -222,7 +222,35 @@ drill.exec: {
# Full workspace name should be indicated
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140603757
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserConnectionConfig.java
---
@@ -75,10 +76,20 @@
} else {
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140612371
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java ---
@@ -140,12 +140,12 @@ protected DrillConnectionImpl(DriverImpl
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140608117
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfig.java ---
@@ -0,0 +1,325 @@
+/*
+ * Licensed to the Apache Software
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140601254
--- Diff:
common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
@@ -110,8 +110,8 @@ public static DrillConfig create() {
*
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140608891
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfig.java ---
@@ -0,0 +1,325 @@
+/*
+ * Licensed to the Apache Software
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140621612
--- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicClient.java
---
@@ -100,6 +103,8 @@ protected void initChannel(SocketChannel ch) throws
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140601290
--- Diff: contrib/native/client/readme.linux ---
@@ -84,6 +84,21 @@ OR
ln -svf libboost_filesystem.a libboost_filesystem-mt.a
ln -svf
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140608922
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfig.java ---
@@ -0,0 +1,325 @@
+/*
+ * Licensed to the Apache Software
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140605580
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
@@ -70,22 +78,80 @@
private static final
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140356738
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfig.java ---
@@ -0,0 +1,325 @@
+/*
+ * Licensed to the Apache Software
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140134229
--- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicClient.java
---
@@ -120,6 +125,25 @@ protected void initChannel(SocketChannel ch) throws
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140132632
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java ---
@@ -102,19 +115,78 @@
// these are used for authentication
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140398730
--- Diff: contrib/native/client/readme.linux ---
@@ -84,6 +84,21 @@ OR
ln -svf libboost_filesystem.a libboost_filesystem-mt.a
ln -svf
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140395265
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
@@ -70,22 +78,80 @@
private static final org.slf4j.Logger
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140357506
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfig.java ---
@@ -0,0 +1,325 @@
+/*
+ * Licensed to the Apache Software
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140130105
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java ---
@@ -140,12 +140,12 @@ protected DrillConnectionImpl(DriverImpl
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140396437
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfig.java ---
@@ -0,0 +1,325 @@
+/*
+ * Licensed to the Apache Software
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140395374
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
@@ -70,22 +78,80 @@
private static final org.slf4j.Logger
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140400536
--- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicServer.java
---
@@ -82,6 +83,9 @@ protected void initChannel(SocketChannel ch) throws
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140397986
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
@@ -70,22 +78,80 @@
private static final org.slf4j.Logger
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140394414
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java ---
@@ -176,31 +256,28 @@ public void connect(final DrillbitEndpoint
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140133705
--- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicClient.java
---
@@ -100,6 +103,8 @@ protected void initChannel(SocketChannel ch) throws
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140130050
--- Diff:
common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
@@ -110,8 +110,8 @@ public static DrillConfig create() {
*
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140395315
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
@@ -70,22 +78,80 @@
private static final org.slf4j.Logger
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140400292
--- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicServer.java
---
@@ -105,6 +109,25 @@ protected void initChannel(SocketChannel ch) throws
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140398781
--- Diff: contrib/native/client/readme.macos ---
@@ -44,12 +44,23 @@ Install Prerequisites
2.2) Install zookeeper
$> brew install zookeeper
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140121083
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -110,6 +110,18 @@
String HASHAGG_FALLBACK_ENABLED_KEY =
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140392979
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfig.java ---
@@ -0,0 +1,325 @@
+/*
+ * Licensed to the Apache Software
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140333837
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java ---
@@ -102,19 +115,78 @@
// these are used for authentication
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140357288
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfigClient.java ---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache Software
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140366914
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfig.java ---
@@ -0,0 +1,325 @@
+/*
+ * Licensed to the Apache Software
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140124213
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -126,10 +138,10 @@
String HTTP_SESSION_MEMORY_RESERVATION =
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140122588
--- Diff: distribution/src/resources/drill-override-example.conf ---
@@ -222,7 +222,35 @@ drill.exec: {
# Full workspace name should be indicated
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140115903
--- Diff:
exec/memory/base/src/main/java/io/netty/buffer/UnsafeDirectLittleEndian.java ---
@@ -69,20 +74,20 @@ private
Github user superbstreak commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140129825
--- Diff: contrib/native/client/src/include/drill/common.hpp ---
@@ -163,9 +170,13 @@ typedef enum{
#define USERPROP_USERNAME "userName"
GitHub user parthchandra opened a pull request:
https://github.com/apache/drill/pull/950
Drill 5431: SSL Support
Add support for SSL between Java/C++ clients and Drillbits.
You can merge this pull request into a Git repository by running:
$ git pull
101 - 155 of 155 matches
Mail list logo
