[GitHub] ihuzenko commented on a change in pull request #1488: DRILL-786: Implement CROSS JOIN

2018-10-04 Thread GitBox
ihuzenko commented on a change in pull request #1488: DRILL-786: Implement CROSS JOIN URL: https://github.com/apache/drill/pull/1488#discussion_r222671465 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java ## @@

[GitHub] ihuzenko commented on a change in pull request #1488: DRILL-786: Implement CROSS JOIN

2018-10-04 Thread GitBox
ihuzenko commented on a change in pull request #1488: DRILL-786: Implement CROSS JOIN URL: https://github.com/apache/drill/pull/1488#discussion_r222660687 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java ## @@ -33,29

[GitHub] ihuzenko commented on a change in pull request #1488: DRILL-786: Implement CROSS JOIN

2018-10-04 Thread GitBox
ihuzenko commented on a change in pull request #1488: DRILL-786: Implement CROSS JOIN URL: https://github.com/apache/drill/pull/1488#discussion_r222670031 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java ## @@ -127,6

[GitHub] ihuzenko commented on a change in pull request #1488: DRILL-786: Implement CROSS JOIN

2018-10-04 Thread GitBox
ihuzenko commented on a change in pull request #1488: DRILL-786: Implement CROSS JOIN URL: https://github.com/apache/drill/pull/1488#discussion_r222669950 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java ## @@ -127,6

[GitHub] ihuzenko commented on a change in pull request #1488: DRILL-786: Implement CROSS JOIN

2018-10-04 Thread GitBox
ihuzenko commented on a change in pull request #1488: DRILL-786: Implement CROSS JOIN URL: https://github.com/apache/drill/pull/1488#discussion_r222692650 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/planner/sql/CrossJoinTest.java ## @@ -0,0 +1,189 @@

[GitHub] ihuzenko commented on a change in pull request #1488: DRILL-786: Implement CROSS JOIN

2018-10-04 Thread GitBox
ihuzenko commented on a change in pull request #1488: DRILL-786: Implement CROSS JOIN URL: https://github.com/apache/drill/pull/1488#discussion_r222692367 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/planner/sql/CrossJoinTest.java ## @@ -0,0 +1,189 @@

[GitHub] ihuzenko commented on a change in pull request #1488: DRILL-786: Implement CROSS JOIN

2018-10-04 Thread GitBox
ihuzenko commented on a change in pull request #1488: DRILL-786: Implement CROSS JOIN URL: https://github.com/apache/drill/pull/1488#discussion_r222664472 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java ## @@ -65,6