[GitHub] vvysotskyi edited a comment on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

vvysotskyi edited a comment on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#issuecomment-429280849 @lushuifeng, I meant to replace `Map> setters` with something like this: `Map>> setters`,

[GitHub] vvysotskyi edited a comment on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

vvysotskyi edited a comment on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#issuecomment-424684441 If this fix just improves the performance without any consequences, then there is no need to disable it

[GitHub] vvysotskyi edited a comment on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

vvysotskyi edited a comment on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#issuecomment-424602274 @lushuifeng, thanks for the contribution! Could you please provide the time of execution of the

[GitHub] vvysotskyi edited a comment on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

vvysotskyi edited a comment on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#issuecomment-424602274 @lushuifeng, thanks for the contribution! Besides setters added to the generated code, are there