Khurram Faraaz created DRILL-5793: ------------------------------------- Summary: NPE on close Key: DRILL-5793 URL: https://issues.apache.org/jira/browse/DRILL-5793 Project: Apache Drill Issue Type: Bug Components: Execution - Flow Affects Versions: 1.12.0 Environment: Drill 1.12.0 commit : aaff1b35b7339fb4e6ab480dd517994ff9f0a5c5 Reporter: Khurram Faraaz
The code looks wrong: {noformat} @Override public void close() throws Exception { options.close(); } If the shutdown occurs to early, options is not yet assigned and an NPE results. {noformat} {noformat} 2017-09-14 20:16:39,551 [main] DEBUG o.apache.drill.exec.server.Drillbit - Shutdown begun. 2017-09-14 20:16:41,560 [pool-5-thread-1] INFO o.a.drill.exec.rpc.user.UserServer - closed eventLoopGroup io.netty.channel.nio.NioEventLoopGroup@71a84ff4 in 1006 ms 2017-09-14 20:16:41,560 [pool-5-thread-2] INFO o.a.drill.exec.rpc.data.DataServer - closed eventLoopGroup io.netty.channel.nio.NioEventLoopGroup@f711283 in 1005 ms 2017-09-14 20:16:41,561 [pool-5-thread-1] INFO o.a.drill.exec.service.ServiceEngine - closed userServer in 1007 ms 2017-09-14 20:16:41,562 [pool-5-thread-2] DEBUG o.a.drill.exec.memory.BaseAllocator - closed allocator[rpc:bit-data]. 2017-09-14 20:16:41,562 [pool-5-thread-2] INFO o.a.drill.exec.service.ServiceEngine - closed dataPool in 1008 ms 2017-09-14 20:16:41,563 [main] DEBUG o.a.drill.exec.memory.BaseAllocator - closed allocator[rpc:user]. 2017-09-14 20:16:41,563 [main] DEBUG o.a.drill.exec.memory.BaseAllocator - closed allocator[rpc:bit-control]. 2017-09-14 20:16:41,593 [main] DEBUG o.a.drill.exec.memory.BaseAllocator - closed allocator[ROOT]. 2017-09-14 20:16:41,593 [main] WARN o.apache.drill.exec.server.Drillbit - Failure on close() java.lang.NullPointerException: null at org.apache.drill.exec.server.options.SystemOptionManager.close(SystemOptionManager.java:369) ~[drill-java-exec-1.12.0-SNAPSHOT.jar:1.12.0-SNAPSHOT] at org.apache.drill.exec.server.DrillbitContext.close(DrillbitContext.java:241) ~[drill-java-exec-1.12.0-SNAPSHOT.jar:1.12.0-SNAPSHOT] at org.apache.drill.exec.work.WorkManager.close(WorkManager.java:154) ~[drill-java-exec-1.12.0-SNAPSHOT.jar:1.12.0-SNAPSHOT] at org.apache.drill.common.AutoCloseables.close(AutoCloseables.java:76) ~[drill-common-1.12.0-SNAPSHOT.jar:1.12.0-SNAPSHOT] at org.apache.drill.common.AutoCloseables.close(AutoCloseables.java:64) ~[drill-common-1.12.0-SNAPSHOT.jar:1.12.0-SNAPSHOT] at org.apache.drill.exec.server.Drillbit.close(Drillbit.java:173) [drill-java-exec-1.12.0-SNAPSHOT.jar:1.12.0-SNAPSHOT] at org.apache.drill.exec.server.Drillbit.start(Drillbit.java:314) [drill-java-exec-1.12.0-SNAPSHOT.jar:1.12.0-SNAPSHOT] at org.apache.drill.exec.server.Drillbit.start(Drillbit.java:290) [drill-java-exec-1.12.0-SNAPSHOT.jar:1.12.0-SNAPSHOT] at org.apache.drill.exec.server.Drillbit.main(Drillbit.java:286) [drill-java-exec-1.12.0-SNAPSHOT.jar:1.12.0-SNAPSHOT] {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)