----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35949/ -----------------------------------------------------------
Review request for drill. Bugs: DRILL-3151 https://issues.apache.org/jira/browse/DRILL-3151 Repository: drill-git Description ------- Added ~unit test for ResultSetMetaData implementation. Made getObject return classes available to implementation of getColumnClassName: - Added SqlAccessor.getObjectClass() (to put that metadata right next to code to which it corresponds rather than in far-away parallel code). - Added similar AvaticaDrillSqlAccessor.getObjectClass(). - Changed DrillAccessorList.accessors from Accessor[] to AvaticaDrillSqlAccessor[] for better access to JDBC getObject return class. - Extracted return classes from accessors to pass to updateColumnMetaData. Reworked some data type mapping and utilities: - Added Added Types.getSqlTypeName(...). - Renamed Types.getJdbcType(...) to getJdbcTypeCode(...) - Replaced Types.isUnSigned with isJdbcSignedType. - Fixed various bogus RPC-type XXX -> java.sql.Types.SMALLINT mappings. - Removed DrillColumnMetaDataList.getJdbcTypeName. - Moved getAvaticaType up (for bottom-up order). - Revised DrillColumnMetaDataList.getAvaticaType(...). MAIN: - Updated updateColumnMetaData(...) to change many calculations of metadata input to ColumnMetaData construction. [DrillColumnMetaDataList] Updated other metadata tests per changes. Diffs ----- common/src/main/java/org/apache/drill/common/types/Types.java df484b7 exec/java-exec/src/main/codegen/templates/SqlAccessors.java c50a3e2 exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/BoundCheckingAccessor.java 3d3683e exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/GenericAccessor.java 347cf26 exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/SqlAccessor.java 19e6fcf exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/AvaticaDrillSqlAccessor.java 64f5b87 exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillAccessorList.java 25ca1ba exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillColumnMetaDataList.java d43755e exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java 5ae7509 exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TypeConvertingSqlAccessor.java b542f94 exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataGetColumnsTest.java 15c9d5c exec/jdbc/src/test/java/org/apache/drill/jdbc/DrillColumnMetaDataListTest.java a4571c7 exec/jdbc/src/test/java/org/apache/drill/jdbc/ResultSetGetMethodConversionsTest.java 1c528f9 exec/jdbc/src/test/java/org/apache/drill/jdbc/ResultSetMetaDataTest.java PRE-CREATION exec/jdbc/src/test/java/org/apache/drill/jdbc/impl/TypeConvertingSqlAccessorTest.java a595ed4 exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestInformationSchemaColumns.java 8fb521e Diff: https://reviews.apache.org/r/35949/diff/ Testing ------- Ran new specified test. Ran existing tests. Thanks, Daniel Barclay