[GitHub] drill issue #581: DRILL-4864: Add ANSI format for date/time functions

2016-10-21 Thread Serhii-Harnyk
Github user Serhii-Harnyk commented on the issue: https://github.com/apache/drill/pull/581 @adeneche - miliseconds issue is fixed in last commit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

2016-10-21 Thread Serhii-Harnyk
Github user Serhii-Harnyk commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r84509944 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -418,6 +447,7 @@ private void

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

2016-10-21 Thread Serhii-Harnyk
Github user Serhii-Harnyk commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r84509937 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -337,6 +364,7 @@ private void writeData(MapWriter

[GitHub] drill issue #594: DRILL-4842: SELECT * on JSON data results in NumberFormatE...

2016-10-21 Thread Serhii-Harnyk
Github user Serhii-Harnyk commented on the issue: https://github.com/apache/drill/pull/594 Added fixes according to review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

2016-10-21 Thread Serhii-Harnyk
Github user Serhii-Harnyk commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r84507055 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -56,6 +58,12 @@ private final boolean

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

2016-10-21 Thread Serhii-Harnyk
Github user Serhii-Harnyk commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r84508112 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -131,14 +139,33 @@ public void

[GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...

2016-10-21 Thread Serhii-Harnyk
Github user Serhii-Harnyk commented on a diff in the pull request: https://github.com/apache/drill/pull/594#discussion_r84507516 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -131,14 +139,33 @@ public void

Re: [GitHub] drill issue #597: DRILL-4905: Push the LIMIT down to the parquet reader.

2016-10-21 Thread Padma Penumarthy
Thanks for the review. Thanks, Padma > On Oct 21, 2016, at 2:16 PM, jinfengni wrote: > > Github user jinfengni commented on the issue: > >https://github.com/apache/drill/pull/597 > >+1 > >Thanks for the PR. It's good that you added couple of more unit

[GitHub] drill pull request #627: DRILL-4812: Fix for detecting wildcards in paths wh...

2016-10-21 Thread mlavende
GitHub user mlavende opened a pull request: https://github.com/apache/drill/pull/627 DRILL-4812: Fix for detecting wildcards in paths when running on windows By the time the path makes it to the `handleWildCard` method the separators have all been normalized to the forward slash.

[GitHub] drill issue #560: DRILL-4823: Fix OOM while trying to prune partitions with ...

2016-10-21 Thread amansinha100
Github user amansinha100 commented on the issue: https://github.com/apache/drill/pull/560 @jinfengni could you also take a quick look at this since the code change is in the Interpreter. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] drill pull request #624: DRILL-4954 - Fix printing Strings when `allTextMode...

2016-10-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/624 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #621: DRILL-4950: Remove incorrect false condition; consu...

2016-10-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/621 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #597: DRILL-4905: Push the LIMIT down to the parquet read...

2016-10-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/597 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #626: DRILL-4560: When new bits register, invoke listener...

2016-10-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/626#discussion_r84428172 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java --- @@ -245,33 +242,29 @@ public DrillbitEndpoint

[GitHub] drill issue #350: DRILL-4309: Make this option `store.hive.optimize_scan_wit...

2016-10-21 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/350 PR should be closed. New PR was opened - https://github.com/apache/drill/pull/625 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Created] (DRILL-4956) Temporary tables support

2016-10-21 Thread Arina Ielchiieva (JIRA)
Arina Ielchiieva created DRILL-4956: --- Summary: Temporary tables support Key: DRILL-4956 URL: https://issues.apache.org/jira/browse/DRILL-4956 Project: Apache Drill Issue Type: Improvement