[jira] [Resolved] (DRILL-1691) ConvertCountToDirectScan rule should be applicable for 2 or more COUNT aggregates

2017-08-15 Thread Arina Ielchiieva (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva resolved DRILL-1691. - Resolution: Fixed Fixed in the scope of DRILL-4735. > ConvertCountToDirectScan rule

[jira] [Resolved] (DRILL-3407) CTAS Auto Partition : The plan for count(*) should show the list of files scanned

2017-08-15 Thread Arina Ielchiieva (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva resolved DRILL-3407. - Resolution: Fixed Fix Version/s: (was: Future) 1.12.0 Fixed

[jira] [Resolved] (DRILL-5357) Partition pruning information not available in query plan for COUNT aggregate query

2017-08-15 Thread Arina Ielchiieva (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva resolved DRILL-5357. - Resolution: Fixed Fix Version/s: 1.12.0 Fixed in the scope of DRILL-4735. >

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r133228018 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatConfig.java --- @@ -24,9 +24,16 @@ import

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/877 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

RE: direct.used on the Metrics page exceeded planner.memory.max_query_memory_per_node while running a single query

2017-08-15 Thread Kunal Khatua
The property *planner.memory.max_query_memory_per_node* is a cumulative limit of all the operators' minor fragments' memory consumption. However, like Boaz pointed out, the truly memory hungry operators like Hash, Sort or Scan operators will take the lion's share of a query's memory. Since,

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r133234012 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatConfig.java --- @@ -24,9 +24,16 @@ import

Re: direct.used on the Metrics page exceeded planner.memory.max_query_memory_per_node while running a single query

2017-08-15 Thread Boaz Ben-Zvi
Here are the relevant lines of code (from exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractBase.java) public static long MAX_ALLOCATION = 10_000_000_000L; protected long maxAllocation = MAX_ALLOCATION; So this applies to every (instance == minor fragment) of

[jira] [Created] (DRILL-5723) Add An Internal Options Table

2017-08-15 Thread Timothy Farkas (JIRA)
Timothy Farkas created DRILL-5723: - Summary: Add An Internal Options Table Key: DRILL-5723 URL: https://issues.apache.org/jira/browse/DRILL-5723 Project: Apache Drill Issue Type: New Feature

Re: direct.used on the Metrics page exceeded planner.memory.max_query_memory_per_node while running a single query

2017-08-15 Thread Muhammad Gelbana
I guess that's why someone recommended to specify a low limit, but then specify a higher one for each query before execution, using the *ALTER SESSION* command. I can't remember were did I read that. Thanks, Gelbana On Tue, Aug 15, 2017 at 7:49 PM, Kunal Khatua wrote: > The

Re: Supporting Internal Options DRILL-5723

2017-08-15 Thread Paul Rogers
Hi Tim, As you noted, it might be easier to have a single options system (that is, one for runtime system/session) options rather than two. If we have two, we’d need to create two system tables, two session tables and two bundles of options sent along with each query, and two sets of SQL ALTER

Re: Supporting Internal Options DRILL-5723

2017-08-15 Thread Parth Chandra
There are some examples of using internal (undocumented) configuration options in Drill. You simply don't put the option in drill-module.conf or in the SystemOptionManager. Adding any (arbitrary) key name in drill-override.conf automatically gives you an undocumented boot time option name. Or

Supporting Internal Options DRILL-5723

2017-08-15 Thread Timothy Farkas
Hello All, Boaz has proposed the idea of internal options. Currently all the options are visible to to the user when they do: select * from sys.options. We would like internal options to be not visible to the user by default. Possibly requiring them to do: select * from internal.options in

Re: Supporting Internal Options DRILL-5723

2017-08-15 Thread Parth Chandra
There is one case I can think of where this is useful - for testing a server we may want to modify these parameters without having to restart a drillbit. With what I said above, that cannot be done. Also, re security parameters: these can be exposed to show a user that they are set, however their

Re: direct.used on the Metrics page exceeded planner.memory.max_query_memory_per_node while running a single query

2017-08-15 Thread Muhammad Gelbana
By "instance", you mean minor fragments, correct ? And does the *planner.memory.max_query_memory_per_node* limit apply to each *type* of minor fragments individually ? Assuming the memory limit is set to *4 GB*, and the running query involves external sort and hash aggregates, should I expect the

[GitHub] drill issue #905: DRILL-1162: Fix OOM for hash join operator when the right ...

2017-08-15 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/905 @paul-rogers @jinfengni can you please review this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r133143191 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetMetadataCache.java --- @@ -452,33 +458,202 @@ public void

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r133159772 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java --- @@ -268,11 +276,15 @@ private FileSelection

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r132515388 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/MetadataContext.java --- @@ -41,6 +42,9 @@ private PruneStatus

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r133143486 --- Diff: exec/java-exec/src/test/resources/parquet/unsupported_metadata/corrupted_metadata.requires_replace.txt --- @@ -0,0 +1,41 @@ +{ +

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r132533745 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/MetadataVersion.java --- @@ -0,0 +1,156 @@ +/* + * Licensed to the

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r133141382 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java --- @@ -1123,4 +1163,22 @@ public GroupScan

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r133142647 --- Diff: exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java --- @@ -639,14 +644,18 @@ protected static void

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r132536020 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java --- @@ -268,11 +276,15 @@ private FileSelection

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r132533379 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java --- @@ -519,17 +564,16 @@ private void

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r133157793 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java --- @@ -633,13 +645,22 @@ public long getRowCount() {

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r132652665 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java --- @@ -209,9 +211,10 @@ public ParquetGroupScan( //

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r13314 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java --- @@ -974,8 +1005,17 @@ private int

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r132517116 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java --- @@ -132,25 +140,62 @@ public static ParquetTableMetadata_v3

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r133139901 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java --- @@ -974,8 +1005,17 @@ private int

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r132534589 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java --- @@ -222,15 +222,17 @@ public DrillTable

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r132432541 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java --- @@ -188,6 +188,10 @@ public void setExpandedFully() {

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r133177759 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java --- @@ -543,78 +584,72 @@ private void

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r133179047 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/MetadataContext.java --- @@ -41,6 +42,8 @@ private PruneStatus

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r133178381 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/MetadataContext.java --- @@ -41,6 +42,8 @@ private PruneStatus

[jira] [Resolved] (DRILL-5685) Provide a way to set common environment variable between sqlline and Drillbit differently.

2017-08-15 Thread Jinfeng Ni (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-5685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jinfeng Ni resolved DRILL-5685. --- Resolution: Fixed Fixed in ae123e166af2ddb22c79b8cb93278a66fccc3be4 > Provide a way to set common

[GitHub] drill issue #877: DRILL-5660: Drill 1.10 queries fail due to Parquet Metadat...

2017-08-15 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/877 +1, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r133198419 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java --- @@ -543,78 +584,72 @@ private void readBlockMeta(String path,

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r133198372 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/MetadataContext.java --- @@ -41,6 +42,8 @@ private PruneStatus

[GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...

2017-08-15 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/877#discussion_r133198332 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/MetadataContext.java --- @@ -41,6 +42,8 @@ private PruneStatus

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

2017-08-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/860 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #902: DRILL-5714: Fix NPE when mapr-db plugin is used in ...

2017-08-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/902 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #874: DRILL-5663: Drillbit fails to start when only keyst...

2017-08-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/874 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #900: DRILL-4735: ConvertCountToDirectScan rule enhanceme...

2017-08-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/900 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #891: DRILL-5699: Drill Web UI Page Source Has Links To E...

2017-08-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/891 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #883: DRILL-5685: Provide a way to set common environment...

2017-08-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/883 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #890: DRILL-5698 Escape version number period separator, ...

2017-08-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/890 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is