[jira] [Created] (DRILL-5969) unit test should continue to tests of storage plugins even there are some failures in exec

2017-11-15 Thread Chunhui Shi (JIRA)
Chunhui Shi created DRILL-5969: -- Summary: unit test should continue to tests of storage plugins even there are some failures in exec Key: DRILL-5969 URL: https://issues.apache.org/jira/browse/DRILL-5969

[GitHub] drill issue #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 Stabali...

2017-11-15 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1023 @arina-ielchiieva Spoke with @paul-rogers . This will likely introduce some conflicts for https://github.com/apache/drill/pull/921 . In an effort to lighten the workload for that contributor we'll

[GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit

2017-11-15 Thread dvjyothsna
Github user dvjyothsna commented on a diff in the pull request: https://github.com/apache/drill/pull/921#discussion_r151201163 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -165,32 +169,59 @@ public DrillbitContext getContext() {

[GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit

2017-11-15 Thread dvjyothsna
Github user dvjyothsna commented on a diff in the pull request: https://github.com/apache/drill/pull/921#discussion_r151201233 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -165,32 +169,59 @@ public DrillbitContext getContext() {

[jira] [Created] (DRILL-5970) DrillParquetReader always builds the schema with "OPTIONAL" dataMode columns instead of "REQUIRED" ones

2017-11-15 Thread Vitalii Diravka (JIRA)
Vitalii Diravka created DRILL-5970: -- Summary: DrillParquetReader always builds the schema with "OPTIONAL" dataMode columns instead of "REQUIRED" ones Key: DRILL-5970 URL:

[GitHub] drill pull request #1037: DRILL-5968: Add support for empty service_host use...

2017-11-15 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/1037#discussion_r151260752 --- Diff: contrib/native/client/src/include/drill/userProperties.hpp --- @@ -28,6 +28,20 @@ class DECLSPEC_DRILL_CLIENT DrillUserProperties{

[GitHub] drill pull request #1037: DRILL-5968: Add support for empty service_host use...

2017-11-15 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/1037#discussion_r151260565 --- Diff: contrib/native/client/src/include/drill/userProperties.hpp --- @@ -28,6 +28,20 @@ class DECLSPEC_DRILL_CLIENT DrillUserProperties{

[GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit

2017-11-15 Thread dvjyothsna
Github user dvjyothsna commented on a diff in the pull request: https://github.com/apache/drill/pull/921#discussion_r151246632 --- Diff: protocol/src/main/java/org/apache/drill/exec/proto/beans/RpcType.java --- @@ -25,28 +25,8 @@ HANDSHAKE(0), ACK(1),

[jira] [Created] (DRILL-5971) Fix INT64, INT32 logical types in complex parquet reader

2017-11-15 Thread Parth Chandra (JIRA)
Parth Chandra created DRILL-5971: Summary: Fix INT64, INT32 logical types in complex parquet reader Key: DRILL-5971 URL: https://issues.apache.org/jira/browse/DRILL-5971 Project: Apache Drill

[GitHub] drill pull request #1036: DRILL-5962: Adding ST_AsJSON functionality

2017-11-15 Thread brendanstennett
Github user brendanstennett commented on a diff in the pull request: https://github.com/apache/drill/pull/1036#discussion_r151267136 --- Diff: contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STAsJson.java --- @@ -0,0 +1,64 @@ +/* + * Licensed to the

[GitHub] drill pull request #1037: DRILL-5968: Add support for empty service_host use...

2017-11-15 Thread superbstreak
Github user superbstreak commented on a diff in the pull request: https://github.com/apache/drill/pull/1037#discussion_r151282112 --- Diff: contrib/native/client/src/include/drill/userProperties.hpp --- @@ -28,6 +28,20 @@ class DECLSPEC_DRILL_CLIENT DrillUserProperties{

[GitHub] drill pull request #1037: DRILL-5968: Add support for empty service_host use...

2017-11-15 Thread superbstreak
Github user superbstreak commented on a diff in the pull request: https://github.com/apache/drill/pull/1037#discussion_r151282197 --- Diff: contrib/native/client/src/include/drill/userProperties.hpp --- @@ -28,6 +28,20 @@ class DECLSPEC_DRILL_CLIENT DrillUserProperties{

[GitHub] drill pull request #1032: DRILL-5089: Dynamically load schema of storage plu...

2017-11-15 Thread chunhui-shi
Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/1032#discussion_r151299650 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/SchemaTreeProvider.java --- @@ -105,12 +106,36 @@ public SchemaPlus

[GitHub] drill pull request #1032: DRILL-5089: Dynamically load schema of storage plu...

2017-11-15 Thread chunhui-shi
Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/1032#discussion_r151298428 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemSchemaFactory.java --- @@ -73,9 +87,10 @@ public void

[GitHub] drill pull request #1032: DRILL-5089: Dynamically load schema of storage plu...

2017-11-15 Thread chunhui-shi
Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/1032#discussion_r151302799 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DynamicRootSchema.java --- @@ -0,0 +1,125 @@ +/* + * Licensed to the

[GitHub] drill pull request #1024: DRILL-3640: Support JDBC Statement.setQueryTimeout...

2017-11-15 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1024#discussion_r151286559 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java --- @@ -96,6 +105,14 @@ private void throwIfClosed() throws

[GitHub] drill pull request #1038: DRILL-5972: Slow performance for query on INFORMAT...

2017-11-15 Thread ppadma
GitHub user ppadma opened a pull request: https://github.com/apache/drill/pull/1038 DRILL-5972: Slow performance for query on INFORMATION_SCHEMA.TABLE Please see DRILL-5972. Problem is while evaluating "boolean and", we are returning as soon as expression result is not TRUE. We

[GitHub] drill pull request #1039: DRILL-5584: Add branding and versioning informatio...

2017-11-15 Thread superbstreak
GitHub user superbstreak opened a pull request: https://github.com/apache/drill/pull/1039 DRILL-5584: Add branding and versioning information for windows C++ C… …lient. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] drill pull request #1039: DRILL-5584: Add branding and versioning informatio...

2017-11-15 Thread superbstreak
Github user superbstreak commented on a diff in the pull request: https://github.com/apache/drill/pull/1039#discussion_r151329816 --- Diff: contrib/native/client/src/clientlib/env.h.in --- @@ -30,6 +30,11 @@ #define GIT_SHA_PROP @GIT_SHA_PROP@ #define GIT_COMMIT_PROP

[GitHub] drill pull request #1032: DRILL-5089: Dynamically load schema of storage plu...

2017-11-15 Thread chunhui-shi
Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/1032#discussion_r151301607 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java --- @@ -150,14 +152,30 @@ public

[jira] [Created] (DRILL-5972) Slow performance for query on INFORMATION_SCHEMA.TABLE

2017-11-15 Thread Padma Penumarthy (JIRA)
Padma Penumarthy created DRILL-5972: --- Summary: Slow performance for query on INFORMATION_SCHEMA.TABLE Key: DRILL-5972 URL: https://issues.apache.org/jira/browse/DRILL-5972 Project: Apache Drill

[GitHub] drill issue #1029: DRILL-5867: List profiles in pages rather than a long ver...

2017-11-15 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1029 +1, LGTM. ---

[GitHub] drill issue #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 Stabali...

2017-11-15 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1023 @ilooner please resolve conflicts. ---

[GitHub] drill pull request #1036: DRILL-5962: Adding ST_AsJSON functionality

2017-11-15 Thread ChrisSandison
Github user ChrisSandison commented on a diff in the pull request: https://github.com/apache/drill/pull/1036#discussion_r151142574 --- Diff: contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STAsJSON.java --- @@ -0,0 +1,58 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #1036: DRILL-5962: Adding ST_AsJSON functionality

2017-11-15 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1036#discussion_r151143439 --- Diff: contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STAsJSON.java --- @@ -0,0 +1,58 @@ +/** --- End diff --

Re: [DISCUSS] Drill 1.12.0 release

2017-11-15 Thread Arina Yelchiyeva
Current status, we are close to the code freeze which will happen not later then the end of the next week. Blocker: DRILL-5917: Ban org.json:json library in Drill (developer - Vlad R., code reviewer - Arina) - in progress. Targeted for 1.12 release: DRILL-4779: Kafka storage plugin support

[GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit

2017-11-15 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/921#discussion_r151110780 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java --- @@ -58,13 +63,170 @@ @Inject UserAuthEnabled

[GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit

2017-11-15 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/921#discussion_r15078 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java --- @@ -315,7 +481,12 @@ public int compareTo(DrillbitInfo

[GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit

2017-11-15 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/921#discussion_r151110657 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java --- @@ -58,13 +63,170 @@ @Inject UserAuthEnabled

[GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit

2017-11-15 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/921#discussion_r15410 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -179,6 +184,98 @@ +

[GitHub] drill pull request #1036: DRILL-5962: Adding ST_AsJSON functionality

2017-11-15 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1036#discussion_r151184679 --- Diff: contrib/gis/src/test/java/org/apache/drill/exec/expr/fn/impl/gis/TestGeometryFunctions.java --- @@ -49,6 +50,28 @@ public void

[GitHub] drill pull request #1036: DRILL-5962: Adding ST_AsJSON functionality

2017-11-15 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1036#discussion_r151184397 --- Diff: contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STAsJSON.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the

[GitHub] drill pull request #1036: DRILL-5962: Adding ST_AsJSON functionality

2017-11-15 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1036#discussion_r151184263 --- Diff: contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STAsJSON.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the

[GitHub] drill pull request #1036: DRILL-5962: Adding ST_AsJSON functionality

2017-11-15 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1036#discussion_r151184326 --- Diff: contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STAsJSON.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the

[GitHub] drill pull request #1036: DRILL-5962: Adding ST_AsJSON functionality

2017-11-15 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1036#discussion_r151184182 --- Diff: contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STAsJSON.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the