Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1243
@mayyamus please create Apache Jira for the fix first
(https://drill.apache.org/docs/apache-drill-contribution-guidelines/). Also
please note that the part of code you are changing was done
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1230
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1216
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1210
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1226
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1235
@vrozov so you suggest to leave as is, correct?
@paul-rogers since you have originally added `DebugStringBuilder`, do you
agree?
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1224
@chunhui-shi could you please address @vrozov comment?
@vvysotskyi could you please alos take a look at PR?
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1204
@oleg-zinovev could you please rebase to the latest master?
---
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1233
@arina-ielchiieva I'll change the PR as suggested by Parth. Since Bridget
does the merges for _gh-pages_ repo, I'll ask her to close the PR.
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1236
@BruceKuiLiu could you please address @vrozov comments?
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1126
@Vlad-Storona could you please rebase to the latest master and confirm that
PR is ready for review?
---
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/1222#discussion_r184882305
--- Diff:
contrib/storage-mongo/src/test/java/org/apache/drill/exec/store/mongo/MongoTestSuit.java
---
@@ -128,42 +130,63 @@ private static void setup()
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/1224
As I understand from DRILL-1921, cross join was prevented due to the
`CannotPlanException` exception at the planning stage.
Can we get the same problem using `APPLY`? If yes, should be
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1144
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1222
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1218
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1240
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1196
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1220
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1217
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1234
---
I did not mean that a pass-through operator should not take the
ownership of a batch it processes. My question was whether they do so
and if they do, when and how. As far as I can see in the
ProjectorTemplate code, the transfer is not done in all cases and when
Projector operates in sv2 mode,
Specific answers based on my understanding.
> I did not mean that a pass-through operator should not take the
ownership of a batch it processes. My question was whether they do so
and if they do, when and how.
Yes, operators do take ownership, somewhere in the process of calling next() on
Github user mayyamus closed the pull request at:
https://github.com/apache/drill/pull/1243
---
Hi Vlad,
More responses.
> The same approach [as for internal operators] applies to senders and
> receivers. Senders gets batches
from the upstream operators taking ownership of those batches and send
data to receivers.
Senders receive data from an "upstream" operator, then serialize over the
Hi Vlad,
Glad to see you are becoming an expert in the mechanics of data batch handling.
This is a complex area that deserves the care and attention your are investing.
Drill's current behavior reflects the design decisions of Drill's original
authors. Unfortunately, those authors are no
Vitalii Diravka created DRILL-6371:
--
Summary: Use FilterSetOpTransposeRule,
DrillProjectSetOpTransposeRule in main logical stage
Key: DRILL-6371
URL: https://issues.apache.org/jira/browse/DRILL-6371
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1235
My take is that "append" is more common for classes with the similar
functionality, see for example `ToStringBuilder`. As there is no added benefit
of using "print" vs "append", my recommendation is
[
https://issues.apache.org/jira/browse/DRILL-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vitalii Diravka resolved DRILL-3130.
Resolution: Done
Fix Version/s: (was: 1.1.0)
1.14.0
Resolved
[
https://issues.apache.org/jira/browse/DRILL-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vitalii Diravka resolved DRILL-2746.
Resolution: Done
Fix Version/s: (was: 1.1.0)
1.14.0
Resolved
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1236
LGTM. Please squash commits.
---
GitHub user mayyamus opened a pull request:
https://github.com/apache/drill/pull/1243
Solved unable to get jquery on the intranet
Running on the intranet, access is slow due to the inability to get jquery.
Modified to directly access local jQuery resources.
You can merge this pull
Paul Rogers created DRILL-6370:
--
Summary: Mod operator % is documented, but not available
Key: DRILL-6370
URL: https://issues.apache.org/jira/browse/DRILL-6370
Project: Apache Drill
Issue Type:
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1222#discussion_r184881467
--- Diff:
contrib/storage-mongo/src/test/java/org/apache/drill/exec/store/mongo/MongoTestSuit.java
---
@@ -128,42 +130,63 @@ private static void
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1233
@kkhatua / @parthchandra should we close the PR or what other work should
be done?
---
Github user BruceKuiLiu commented on the issue:
https://github.com/apache/drill/pull/1236
@vrozov Thanks.
---
Turns out I really needed better type functions in order to explain the nuances
of Drill types, so I went ahead and created them.
See DRILL-6361, PR #1242 [1]. Examples shown in the PR. Reviewers very much
appreciated.
Thanks,
- Paul
[1] https://github.com/apache/drill/pull/1242
On
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/1242
DRILL-6361: Revised typeOf() function versions
Drill provides the `typeof()` function to return the type of a column.
However, this function has two key limitations:
1. It returns NULL
38 matches
Mail list logo
