[GitHub] [drill] vvysotskyi commented on a change in pull request #2069: DRILL-7723 - Add Excel Metadata as Implicit Fields

vvysotskyi commented on a change in pull request #2069: URL: https://github.com/apache/drill/pull/2069#discussion_r429570614 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ## @@ -75,7 +83,9 @@ private Row

[GitHub] [drill] vvysotskyi commented on pull request #2077: DRILL-7734: Revise the result set reader

vvysotskyi commented on pull request #2077: URL: https://github.com/apache/drill/pull/2077#issuecomment-633135657 @paul-rogers, changes look good. Could you please resolve the checkstyle failure? This is an automated

[GitHub] [drill] sanel commented on a change in pull request #2069: DRILL-7723 - Add Excel Metadata as Implicit Fields

sanel commented on a change in pull request #2069: URL: https://github.com/apache/drill/pull/2069#discussion_r429577212 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ## @@ -420,15 +510,57 @@ private void

[GitHub] [drill] vvysotskyi commented on pull request #2076: DRILL-7729: Use java.time in column accessors

vvysotskyi commented on pull request #2076: URL: https://github.com/apache/drill/pull/2076#issuecomment-633133080 @paul-rogers, did you have a chance to take a look at @cgivre comments? This is an automated message from the