[GitHub] drill pull request: Drill-3242: Offload RPC threads

GitHub user jacques-n opened a pull request: https://github.com/apache/drill/pull/229 Drill-3242: Offload RPC threads You can merge this pull request into a Git repository by running: $ git pull https://github.com/jacques-n/drill DRILL-3242v2 Alternatively you can review and

[GitHub] drill pull request: DRILL-951:CSV header row should be parsed

Github user abhipol commented on a diff in the pull request: https://github.com/apache/drill/pull/232#discussion_r43721290 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/TextParsingSettings.java --- @@ -57,6 +56,14 @@ public void

[GitHub] drill pull request: DRILL-951:CSV header row should be parsed

Github user abhipol commented on a diff in the pull request: https://github.com/apache/drill/pull/232#discussion_r43721297 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/CompliantTextRecordReader.java --- @@ -101,16 +108,23 @@ public void

[GitHub] drill pull request: DRILL-951:CSV header row should be parsed

Github user abhipol commented on a diff in the pull request: https://github.com/apache/drill/pull/232#discussion_r43721299 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/CompliantTextRecordReader.java --- @@ -71,15 +79,14 @@ public

[GitHub] drill pull request: Drill 3952

Github user adeneche commented on the pull request: https://github.com/apache/drill/pull/222#issuecomment-153131868 Window operator has become increasingly complex. I already opened [DRILL-3662](https://issues.apache.org/jira/browse/DRILL-3662) to refactor the code. --- If your

Re: Review Request 35719: DRILL-3242: Update RPC layer so that requests and response are managed on a secondary thread.

> On July 16, 2015, 6:56 p.m., Sudheesh Katkam wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/RpcBus.java, line 459 > > > > > > Should this just be logged? Previously, we threw the exception. > >

[jira] [Created] (DRILL-4007) json reader treats empty list inconsistently,

Sean Hsuan-Yi Chu created DRILL-4007: Summary: json reader treats empty list inconsistently, Key: DRILL-4007 URL: https://issues.apache.org/jira/browse/DRILL-4007 Project: Apache Drill

Re: Review Request 35719: DRILL-3242: Update RPC layer so that requests and response are managed on a secondary thread.

> On June 30, 2015, 7:55 p.m., Sudheesh Katkam wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java, > > line 148 > > > > > > The RPC thread could potentially spend quite

Re: Query a field with empty list

There could be inconsistent results: https://issues.apache.org/jira/browse/DRILL-4007 On Mon, Nov 2, 2015 at 8:17 AM, Andries Engelbrecht < aengelbre...@maprtech.com> wrote: > Currently in 1.2 I observe the following. > > 0: jdbc:drill:> select a from dfs.json.`/test.json`; > +---+ > | a

[GitHub] drill pull request: DRILL-951:CSV header row should be parsed

Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/232#discussion_r43716119 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/TextParsingSettings.java --- @@ -57,6 +56,14 @@ public void

[GitHub] drill pull request: DRILL-951:CSV header row should be parsed

Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/232#discussion_r43716151 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/CompliantTextRecordReader.java --- @@ -71,15 +79,14 @@ public

[GitHub] drill pull request: DRILL-951:CSV header row should be parsed

Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/232#discussion_r43716276 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/CompliantTextRecordReader.java --- @@ -101,16 +108,23 @@ public void

[GitHub] drill pull request: DRILL-2288: Fix ScanBatch violation of IterOut...

Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/228#discussion_r43717182 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java --- @@ -325,10 +325,13 @@ public AggOutcome

[GitHub] drill pull request: DRILL-2288: Fix ScanBatch violation of IterOut...

Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/228#discussion_r43717190 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java --- @@ -122,6 +122,7 @@ protected void

[GitHub] drill pull request: DRILL-2288: Fix ScanBatch violation of IterOut...

Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/228#discussion_r43717313 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -93,13 +93,15 @@ public void

Re: Query a field with empty list

Currently in 1.2 I observe the following. 0: jdbc:drill:> select a from dfs.json.`/test.json`; +---+ | a | +---+ | null | +———+ But then flatten produces an error 0: jdbc:drill:> select flatten(a) from dfs.json.`/test.json`; Error: SYSTEM ERROR: ClassCastException: Cannot cast

Re: Query a field with empty list

Sounds to me that FLATTEN over an empty list NULL should produce 0 row. That's actually the behavior of UNNEST of empty array, or NULL, in Postgres. Unless we have a strong reason that FLATTEN should behavior differently than UNNEST, I think it makes sense for FLATTEN to produce 0 row over empty

Re: Query a field with empty list

Seems empty list is getting the vote for select. For consistency would it then make sense to have flatten produce a single row with an empty list in the result? —Andries > On Nov 2, 2015, at 12:55 PM, Neeraja Rentachintala > wrote: > > Empty list sounds like

[GitHub] drill pull request: DRILL-3941: Add timing instrumentation in diff...

GitHub user mehant opened a pull request: https://github.com/apache/drill/pull/230 DRILL-3941: Add timing instrumentation in different phases of partiti… …on pruning Add basic timing instrumentation while initializing FileSelection and reading the metadata cache file

[GitHub] drill pull request: DRILL-3941: Add timing instrumentation in diff...

Github user mehant commented on the pull request: https://github.com/apache/drill/pull/230#issuecomment-153201984 @amansinha100 can you please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Created] (DRILL-4009) Assert in a query with concat function in a group by and limit in outer query

Victoria Markman created DRILL-4009: --- Summary: Assert in a query with concat function in a group by and limit in outer query Key: DRILL-4009 URL: https://issues.apache.org/jira/browse/DRILL-4009

[jira] [Resolved] (DRILL-3313) Eliminate redundant #load methods and unit-test loading & exporting of vectors

[ https://issues.apache.org/jira/browse/DRILL-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hanifi Gunes resolved DRILL-3313. - Resolution: Fixed Fixed by 77e2b89 > Eliminate redundant #load methods and unit-test loading &

[GitHub] drill pull request: DRILL-3634: Add number of partitions informati...

GitHub user mehant opened a pull request: https://github.com/apache/drill/pull/231 DRILL-3634: Add number of partitions information in the plan for hive… … scans You can merge this pull request into a Git repository by running: $ git pull https://github.com/mehant/drill

[GitHub] drill pull request: DRILL-2288: Fix ScanBatch violation of IterOut...

Github user dsbos commented on a diff in the pull request: https://github.com/apache/drill/pull/228#discussion_r43704529 --- Diff: contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java --- @@ -142,10 +148,12 @@ public void

[GitHub] drill pull request: DRILL-3941: Add timing instrumentation in diff...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/230#discussion_r43706195 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java --- @@ -163,7 +163,9 @@ private ParquetTableMetadata_v1

[GitHub] drill pull request: DRILL-3941: Add timing instrumentation in diff...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/230#discussion_r43706257 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java --- @@ -166,16 +174,28 @@ protected void

[jira] [Created] (DRILL-4010) In HBase reader, create child vectors for referenced HBase columns to avoid spurious schema changes

Daniel Barclay (Drill) created DRILL-4010: - Summary: In HBase reader, create child vectors for referenced HBase columns to avoid spurious schema changes Key: DRILL-4010 URL:

[GitHub] drill pull request: DRILL-3912: Common subexpression elimination

Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/189#discussion_r43714617 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java --- @@ -218,11 +220,16 @@ public HoldingContainer

[GitHub] drill pull request: DRILL-3912: Common subexpression elimination

Github user StevenMPhillips commented on a diff in the pull request: https://github.com/apache/drill/pull/189#discussion_r43715223 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java --- @@ -106,19 +177,30 @@ public HoldingContainer

[GitHub] drill pull request: DRILL-3912: Common subexpression elimination

Github user StevenMPhillips commented on a diff in the pull request: https://github.com/apache/drill/pull/189#discussion_r43715208 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java --- @@ -218,11 +220,16 @@ public HoldingContainer

[GitHub] drill pull request: DRILL-3912: Common subexpression elimination

Github user jinfengni commented on the pull request: https://github.com/apache/drill/pull/189#issuecomment-153236066 The revised code(adds MappingSet to ExpressionHolder) looks good to me. --- If your project is set up for it, you can reply to this email and have your

[GitHub] drill pull request: DRILL-951:CSV header row should be parsed

GitHub user abhipol opened a pull request: https://github.com/apache/drill/pull/232 DRILL-951:CSV header row should be parsed You can merge this pull request into a Git repository by running: $ git pull https://github.com/abhipol/drill issues/DRILL-951 Alternatively you can