[GitHub] drill issue #517: DRILL-4704 fix

2016-08-06 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/517 Good point. So, we'd want to issue an overflow error in the cast method, but it seems Drill has no way to do that. So, for now, maybe just leave it at the version that works when numbers are in

[GitHub] drill issue #517: DRILL-4704 fix

2016-08-06 Thread daveoshinsky
Github user daveoshinsky commented on the issue: https://github.com/apache/drill/pull/517 The scale is a schema-level property of that column of data, that is never changed on the fly, to deal with problematic truncation, or otherwise.  If anybody is interested in a detail

[GitHub] drill issue #517: DRILL-4704 fix

2016-08-06 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/517 To clarify the previous comment... In the case where the maximum required precision for the int type is greater than the maximum precision of the target decimal type, we use Dave's code to figure

[GitHub] drill pull request #551: DRILL-4792: Include session options used for a quer...

2016-08-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/551#discussion_r73786030 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java --- @@ -338,7 +345,8 @@ private QueryProfile

[GitHub] drill pull request #551: DRILL-4792: Include session options used for a quer...

2016-08-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/551#discussion_r73785925 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java --- @@ -81,6 +85,7 @@ private final String

[GitHub] drill pull request #520: DRILL-3510: Add ANSI_QUOTES option so that Drill's ...

2016-08-06 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/520#discussion_r73784191 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java --- @@ -1273,5 +1295,11 @@ public boolean