[GitHub] drill pull request #592: DRILL-4826: Query against INFORMATION_SCHEMA.TABLES...

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/592 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill issue #634: DRILL-4974: NPE in FindPartitionConditions.analyzeCall() f...

Github user bitblender commented on the issue: https://github.com/apache/drill/pull/634 @amansinha100 Can you please review this change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] drill pull request #631: DRILL-4968: Add column size to ColumnMetadata

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/631 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: isDateCorrect field in ParquetTableMetadata

FWIW: back on the magic flag issue… I noted Vitali’s concern about “1.9” and “1.9-SNAPSHOT” being too course grained for our needs. A typical solution is include the version of the Parquet writer in addition to that of Drill. Each time we change something in the writer, increment the version

[GitHub] drill pull request #634: DRILL-4974: NPE in FindPartitionConditions.analyzeC...

GitHub user bitblender opened a pull request: https://github.com/apache/drill/pull/634 DRILL-4974: NPE in FindPartitionConditions.analyzeCall() for 'holistic' expressions Changes: Added a missing null check in FindPartitionConditions.analyzeCall(), to ensure that opStack.peek()

[GitHub] drill issue #600: DRILL-4373: Drill and Hive have incompatible timestamp rep...

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/600 Changing this to -1 until unit test failure is addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] drill pull request #600: DRILL-4373: Drill and Hive have incompatible timest...

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/600#discussion_r85449218 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -739,30 +741,76 @@ public void

[GitHub] drill issue #631: DRILL-4968: Add column size to ColumnMetadata

Github user adeneche commented on the issue: https://github.com/apache/drill/pull/631 +1, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: isDateCorrect field in ParquetTableMetadata

Vitalli, Thank you for looking into this, sorry I missed it in the review. When you open up a request to fix this issue could you update the check for correctness in the metadata to check for the is.date.correct flag, or a version greater than or equal to 1.9.0 (no snapshot)? This will allow us

Re: isDateCorrect field in ParquetTableMetadata

Vitalii -- are you still planning to open a ticket and pull request for the fix you've noted below? -- Zelaine On Wed, Oct 26, 2016 at 8:28 AM, Vitalii Diravka wrote: > @Paul Rogers > It may be the undefined case when the file is generated with drill.version > =

[GitHub] drill issue #602: Improve Drill C++ connector

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/602 No need for many PRs. Let's just squash this branch into commits for the individual JIRA's I think. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] drill issue #622: DRILL-4369: Exchange name and version infos during handsha...

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/622 Thanks for the responses! Sorry I posted my comments just after the commit. The issues are "nice-to-haves" for the original PR, do not justify another PR. --- If your project is set up for it,

[GitHub] drill issue #602: Improve Drill C++ connector

Github user laurentgo commented on the issue: https://github.com/apache/drill/pull/602 @parthchandra do you want individual pull requests for each issue, or are you okay having this branch squashed and merged? --- If your project is set up for it, you can reply to this email and

[GitHub] drill pull request #602: Improve Drill C++ connector

Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/602#discussion_r85436247 --- Diff: contrib/native/client/cmakeModules/FindZookeeper.cmake --- @@ -30,8 +30,10 @@ if (MSVC) if(${CMAKE_BUILD_TYPE} MATCHES "Debug")

[GitHub] drill pull request #602: Improve Drill C++ connector

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/602#discussion_r85434357 --- Diff: contrib/native/client/cmakeModules/FindZookeeper.cmake --- @@ -30,8 +30,10 @@ if (MSVC) if(${CMAKE_BUILD_TYPE} MATCHES "Debug")

[GitHub] drill pull request #602: Improve Drill C++ connector

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/602#discussion_r85434499 --- Diff: contrib/native/client/cmakeModules/FindCppUnit.cmake --- @@ -0,0 +1,67 @@ +# +# Licensed to the Apache Software Foundation (ASF) under

Re: Filter appears above project in query plan - Null Equality Join

Ok, if there is not much of a performance gain as suggested in the responses, then there is not much that can be done in this case. Thanks, Khurram On Thu, Oct 27, 2016 at 3:41 AM, Jinfeng Ni wrote: > Also, if the project operator is not doing any expression evaluation, > the

[jira] [Created] (DRILL-4973) Sqlline history

Andries Engelbrecht created DRILL-4973: -- Summary: Sqlline history Key: DRILL-4973 URL: https://issues.apache.org/jira/browse/DRILL-4973 Project: Apache Drill Issue Type: Improvement

Re: TO_TIMESTAMP function returns in-correct results

Hello, Khurram http://joda-time.sourceforge.net/apidocs/org/joda/time/format/DateTimeFormat.html s second of minute number55 S fraction of second number978 2016-10-27 13:54 GMT+03:00 Khurram Faraaz : > All, > > I am on

TO_TIMESTAMP function returns in-correct results

All, I am on Drill 1.9.0 git commit ID : a29f1e29 on CentOS TO_TIMESTAMP function does not return correct results, note that the minutes, seconds and milliseconds parts of timestamp are incorrect in the results {noformat} 0: jdbc:drill:schema=dfs.tmp> VALUES(TO_TIMESTAMP('2015-03-30 20:49:59.10