[GitHub] drill issue #367: DRILL-4364: Image Metadata Format Plugin

Github user cgivre commented on the issue: https://github.com/apache/drill/pull/367 @nagix I just became a committer, and I'd really love to see this incorporated into the latest version of Drill. Are you willing to keep working on this to finish it? If not, I may have some time to

[GitHub] drill issue #880: DRILL-5678: Undefined behavior due to un-initialized value...

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/880 +1. Nice catch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128367397 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java --- @@ -70,52 +72,90 @@ */

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128367935 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SortConfig.java --- @@ -114,15 +127,25 @@ public

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128365742 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/PriorityQueueCopierWrapper.java --- @@ -82,7 +84,7 @@ private

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128322098 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java --- @@ -19,117 +19,162 @@ import

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128365478 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/MergeSortWrapper.java --- @@ -147,7 +147,7 @@ private MSorter

Re: Questions about Drill's multi-thread model

What do you mean by "one query was blocked by the storage"? Are the other queries blocked in query planning time, or execution time? I recalled someone asked the problem related to long query planning. Turns out that if one enabled storage plugin is slow to access, it would affect every query,

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128134981 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SortMemoryManager.java --- @@ -312,52 +488,66 @@ private void

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128124656 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggBatch.java --- @@ -265,7 +277,7 @@ private

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128130180 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SortMemoryManager.java --- @@ -19,7 +19,125 @@

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128127882 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java --- @@ -189,30 +238,29 @@ public

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128129092 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/PriorityQueueCopierWrapper.java --- @@ -100,10 +102,12 @@

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128125131 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggTemplate.java --- @@ -36,6 +36,9 @@ private int

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128144906 --- Diff: exec/vector/src/main/java/org/apache/drill/exec/vector/AllocationHelper.java --- @@ -26,14 +26,16 @@ public static void allocate(ValueVector v,

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128143815 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ClientFixture.java --- @@ -231,4 +236,120 @@ public void setControls(String controls) {

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128128588 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/MSortTemplate.java --- @@ -92,8 +93,9 @@ public void setup(final

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128143565 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/SmartAllocationHelper.java --- @@ -0,0 +1,156 @@ +/* + * Licensed to the

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128144743 --- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java --- @@ -247,27 +249,26 @@ public void copyEntry(int toIndex, ValueVector

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128133649 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SortMemoryManager.java --- @@ -19,7 +19,125 @@

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128134415 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SortMemoryManager.java --- @@ -97,24 +215,43 @@

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128125799 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java --- @@ -19,117 +19,162 @@ import

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128127648 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java --- @@ -177,7 +226,7 @@ public

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128126935 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java --- @@ -19,117 +19,162 @@ import

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128142798 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SorterWrapper.java --- @@ -83,10 +83,9 @@ private

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128143493 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/SmartAllocationHelper.java --- @@ -0,0 +1,156 @@ +/* + * Licensed to the

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128142873 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/SmartAllocationHelper.java --- @@ -0,0 +1,156 @@ +/* + * Licensed to the

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128127127 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java --- @@ -139,14 +184,16 @@ public String

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128124528 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggBatch.java --- @@ -111,6 +120,8 @@ public void

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128130382 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SortMemoryManager.java --- @@ -19,7 +19,125 @@

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128129255 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/PriorityQueueCopierWrapper.java --- @@ -245,29 +250,35 @@

[GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r128128116 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/SpillSet.java --- @@ -413,7 +419,12 @@ public SpillSet(DrillConfig

Re: Questions about Drill's multi-thread model

Hi Weijie, There is nothing in Drill’s design that would account for this behavior: each query runs a separate set of threads from any other query; there is no synchronization among queries. Did you, perhaps, enable Drill’s ZK-based queueing feature? That would cause later queries to block

Questions about Drill's multi-thread model

Hi there， Our product environment has a situation that if one query was blocked by the storage,then all other queries which come later would took long and long time to run even they really just need fewer time. At the time ,the cluster's load is not too high. I know that every foreman will

Re: [DISCUSS] Drill 1.11.0 release

Thanks, Boaz! Unfortunately, I still see the failures connected to DRILL-5669. I'll share the details. Kind regards Arina On Wed, Jul 19, 2017 at 2:00 AM, Boaz Ben-Zvi wrote: > Hi Arina, > > The three Jira’s are ready (+1, squashed, rebased, etc.): > > • DRILL-5616: