Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/976
+1
looks good!
---
Github user priteshm commented on the issue:
https://github.com/apache/drill/pull/976
@sachouche can you please take a final look? If it looks good, maybe one of
the committers can include this for the 1.12 release. @arina-ielchiieva ?
---
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r147581757
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestCastFunctions.java
---
@@ -77,16 +83,21 @@ public void
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r147582599
--- Diff:
logical/src/test/java/org/apache/drill/common/expression/fn/JodaDateValidatorTest.java
---
@@ -24,6 +24,7 @@
import org.junit.BeforeClass;
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r147581841
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestDateFunctions.java
---
@@ -17,11 +17,10 @@
*/
package
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r147582266
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestDateFunctions.java
---
@@ -34,19 +33,22 @@
import
