[GitHub] drill pull request #1020: DRILL-5921: Display counter metrics in table

GitHub user prasadns14 opened a pull request: https://github.com/apache/drill/pull/1020 DRILL-5921: Display counter metrics in table Listed the counter metrics in a table @arina-ielchiieva please review You can merge this pull request into a Git repository by running: $

[jira] [Created] (DRILL-5921) Counters metrics should be listed in table

Prasad Nagaraj Subramanya created DRILL-5921: Summary: Counters metrics should be listed in table Key: DRILL-5921 URL: https://issues.apache.org/jira/browse/DRILL-5921 Project: Apache

[GitHub] drill issue #984: DRILL-5783 Made a unit test for generated Priority Queue. ...

Github user ilooner commented on the issue: https://github.com/apache/drill/pull/984 @paul-rogers This is ready for another round of review. I have also responded to / addressed your comments. ---

[GitHub] drill issue #970: DRILL-5832: Migrate OperatorFixture to use SystemOptionMan...

Github user ilooner commented on the issue: https://github.com/apache/drill/pull/970 @paul-rogers Will this be going in anytime soon? I'd like to fix the annoying ``` test(String.format("alter session...")) ``` statements in the tests after this goes in.

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r148396417 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/TableFileBuilder.java --- @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r148395420 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestCorruptParquetDateCorrection.java --- @@ -377,21 +386,21 @@ public

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r148394268 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestExternalSort.java --- @@ -138,34 +141,34 @@ public void

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r148393893 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/BatchUtils.java --- @@ -0,0 +1,280 @@ +/* + * Licensed to the Apache Software Foundation

Re: Drill SASL Forward Compatibility

Parth, Your understanding is correct. I am also debating for 1(A) specially in context of security mechanisms like Kerberos which guarantees prevention from MITM during handshake. But with 1( B ) we are saying in case of Drill it's possible and fine since no data is compromised. Thanks,

[GitHub] drill issue #976: DRILL-5797: Choose parquet reader from read columns

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/976 Drill follows SQL rules and is case insensitive. If case sensitivity has snuck in somewhere (perhaps due to the use of `equals()` rather than `equalsIgnorCase()` or the use of a case-sensitive

[GitHub] drill pull request #1019: DRILL-5909: Added new Counter metrics

GitHub user prasadns14 opened a pull request: https://github.com/apache/drill/pull/1019 DRILL-5909: Added new Counter metrics Added new metrics to capture succeeded, failed and canceled queries count. @paul-rogers please review You can merge this pull request into a Git

Re: Drill SASL Forward Compatibility

I sort of lost track of the arguments in the thread. Is my understanding below correct ? 1) A handshake from a (1.12) client expecting authentication and encryption is intercepted by a rogue server. The server then responds with a success message and bypasses the auth and encryption for the

[GitHub] drill issue #1015: DRILL-5889: Simple pattern matchers can work with DrillBu...

Github user sachouche commented on the issue: https://github.com/apache/drill/pull/1015 Padma, DRILL-5889 is the wrong JIRA (sqlline loses RPC..); I think your JIRA is 5899 Regards, Salim From: Padma Penumarthy

[GitHub] drill issue #1018: Drill-5834 Add Networking Functions #971

Github user cgivre commented on the issue: https://github.com/apache/drill/pull/1018 @paul-rogers @arina-ielchiieva I'm terrible at git so here is a clean copy of the PR with one commit. ---

[GitHub] drill pull request #971: Drill-5834 Add Networking Functions

Github user cgivre closed the pull request at: https://github.com/apache/drill/pull/971 ---

[GitHub] drill pull request #1018: Drill-5834 Add Networking Functions #971

GitHub user cgivre opened a pull request: https://github.com/apache/drill/pull/1018 Drill-5834 Add Networking Functions #971 This is a collection of Networking Functions to facilitate network analysis. The functions include: - **inet_aton(``)**: Converts an IPv4 address

[jira] [Resolved] (DRILL-5920) Drill incorrectly projects column aliases to scan operator

[ https://issues.apache.org/jira/browse/DRILL-5920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Rogers resolved DRILL-5920. Resolution: Not A Bug > Drill incorrectly projects column aliases to scan operator >

[GitHub] drill issue #1015: DRILL-5889: Simple pattern matchers can work with DrillBu...

Github user ppadma commented on the issue: https://github.com/apache/drill/pull/1015 @sachouche @paul-rogers can you please review ? ---

[GitHub] drill issue #976: DRILL-5797: Choose parquet reader from read columns

Github user sachouche commented on the issue: https://github.com/apache/drill/pull/976 Looking at the stack trace: - The code definitely is initializing a column of type REPEATABLE - The Fast Reader didn't expect this scenario so it used a default container (NullableVarBinary)

[jira] [Created] (DRILL-5920) Drill incorrectly projects column aliases to scan operator

Paul Rogers created DRILL-5920: -- Summary: Drill incorrectly projects column aliases to scan operator Key: DRILL-5920 URL: https://issues.apache.org/jira/browse/DRILL-5920 Project: Apache Drill

Re: Drill SASL Forward Compatibility

Hi Sorabh, regarding your question: > > We have to either back port above forward compatibility fix into 1.10 and > 1.11 or just fix in current release and support forward compatibility post > 1.12+. > Arina/Sudheesh - Please suggest if the analysis and fix sounds good and > what are the

Re: Drill SASL Forward Compatibility

My comments inline: On Tue, Oct 31, 2017 at 6:11 PM, Sorabh Hamirwasia wrote: > - if using Kerberos, things are a bit different: even if a MITM intercepts > > the token, only the server can decode it properly and set up encryption so > that only client can use it (a proxy

[jira] [Created] (DRILL-5919) Add session option to allow json reader/writer to work with NaN,INF

Volodymyr Tkach created DRILL-5919: -- Summary: Add session option to allow json reader/writer to work with NaN,INF Key: DRILL-5919 URL: https://issues.apache.org/jira/browse/DRILL-5919 Project:

[GitHub] drill issue #892: DRILL-5645: negation of expression causes null pointer exc...

Github user josiahyan commented on the issue: https://github.com/apache/drill/pull/892 Yay! First commit! Thanks for the review! ---

Re: gitbox?

+1 but as we have communicated on Hangouts committer should be responsible for: 1. making sure that there is only one commit (otherwise ask developer to squash the commits, unless several commits are required) and commit message is according to the Drill standards. 2. all unit tests pass. 3. all