[GitHub] drill pull request #1024: DRILL-3640: Support JDBC Statement.setQueryTimeout...

Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/1024#discussion_r149276207 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java --- @@ -376,6 +415,19 @@ synchronized void cleanup() {

[GitHub] drill pull request #1024: DRILL-3640: Support JDBC Statement.setQueryTimeout...

Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/1024#discussion_r149278719 --- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/StatementTest.java --- @@ -61,55 +71,129 @@ public static void tearDownStatement() throws

[GitHub] drill pull request #1024: DRILL-3640: Support JDBC Statement.setQueryTimeout...

Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/1024#discussion_r149278215 --- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java --- @@ -237,6 +245,127 @@ public String toString() { }

[GitHub] drill pull request #1024: DRILL-3640: Support JDBC Statement.setQueryTimeout...

Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/1024#discussion_r149277578 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java --- @@ -46,6 +48,8 @@

[GitHub] drill pull request #1024: DRILL-3640: Support JDBC Statement.setQueryTimeout...

Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/1024#discussion_r149278003 --- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java --- @@ -237,6 +245,127 @@ public String toString() { }

[GitHub] drill pull request #1024: DRILL-3640: Support JDBC Statement.setQueryTimeout...

Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/1024#discussion_r149277896 --- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java --- @@ -237,6 +245,127 @@ public String toString() { }

[GitHub] drill pull request #1024: DRILL-3640: Support JDBC Statement.setQueryTimeout...

Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/1024#discussion_r149277524 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java --- @@ -61,8 +65,14 @@ protected

[GitHub] drill pull request #1024: DRILL-3640: Support JDBC Statement.setQueryTimeout...

Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/1024#discussion_r149277205 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java --- @@ -100,13 +103,17 @@ final LinkedBlockingDeque batchQueue =

[GitHub] drill pull request #1024: DRILL-3640: Support JDBC Statement.setQueryTimeout...

Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/1024#discussion_r149278905 --- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/StatementTest.java --- @@ -61,55 +71,129 @@ public static void tearDownStatement() throws

[GitHub] drill pull request #1024: DRILL-3640: Support JDBC Statement.setQueryTimeout...

Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/1024#discussion_r149277286 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java --- @@ -66,11 +70,27 @@ private final DrillConnectionImpl

[GitHub] drill pull request #1024: DRILL-3640: Support JDBC Statement.setQueryTimeout...

Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/1024#discussion_r149277380 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java --- @@ -96,6 +117,13 @@ private void throwIfClosed() throws

[GitHub] drill pull request #1024: DRILL-3640: Support JDBC Statement.setQueryTimeout...

Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/1024#discussion_r149277808 --- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java --- @@ -237,6 +245,127 @@ public String toString() { }

[GitHub] drill pull request #1024: DRILL-3640: Support JDBC Statement.setQueryTimeout...

Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/1024#discussion_r149278294 --- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java --- @@ -237,6 +245,127 @@ public String toString() { }

[GitHub] drill pull request #1024: DRILL-3640: Support JDBC Statement.setQueryTimeout...

Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/1024#discussion_r149278066 --- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java --- @@ -237,6 +245,127 @@ public String toString() { }

[GitHub] drill pull request #1024: DRILL-3640: Support JDBC Statement.setQueryTimeout...

Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/1024#discussion_r149277720 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java --- @@ -66,11 +70,27 @@ private final DrillConnectionImpl

[GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...

Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/858#discussion_r149274508 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java --- @@ -552,16 +701,22 @@ public void clearParameters()

[GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...

Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/858#discussion_r149229998 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java --- @@ -54,7 +55,8 @@ void setQueryTimeout( int milliseconds ) ---

[GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...

Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/858#discussion_r149274342 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TimeoutTrigger.java --- @@ -0,0 +1,87 @@ +/** + * Licensed to the Apache Software

[GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...

Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/858#discussion_r149230118 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java --- @@ -98,6 +103,34 @@ private void throwIfClosed() throws

[GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...

Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/858#discussion_r149228776 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java --- @@ -34,11 +35,11 @@ *if connection is closed */

[GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...

Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/858#discussion_r149273958 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java --- @@ -201,31 +252,57 @@ public int getQueryTimeout() throws

[GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...

Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/858#discussion_r149229229 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java --- @@ -34,11 +35,11 @@ *if connection is closed */

[jira] [Created] (DRILL-5936) Refactor MergingRecordBatch based on code review

Vlad Rozov created DRILL-5936: - Summary: Refactor MergingRecordBatch based on code review Key: DRILL-5936 URL: https://issues.apache.org/jira/browse/DRILL-5936 Project: Apache Drill Issue Type:

Re: Drill SASL Forward Compatibility

Hi Laurent, Please see the responses inline. Thanks, Sorabh From: Laurent Goujon Sent: Thursday, November 2, 2017 11:52 AM To: dev Subject: Re: Drill SASL Forward Compatibility I have a parallel scenario: - Scenario 1: 1) A handshake from

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r149257480 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -158,38 +165,49 @@ public DrillbitContext getContext() {

[GitHub] drill issue #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 Stabali...

Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1023 Applied review comments ---

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r149257347 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -158,38 +165,49 @@ public DrillbitContext getContext() {

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r149257392 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -158,38 +165,49 @@ public DrillbitContext getContext() {

[GitHub] drill pull request #1018: Drill-5834: Add Networking Functions

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1018 ---

[GitHub] drill issue #1021: DRILL-5923: Display name for query state

Github user prasadns14 commented on the issue: https://github.com/apache/drill/pull/1021 @arina-ielchiieva, made changes to avoid display name duplication. Please review ---

[jira] [Created] (DRILL-5935) Hash Join projects unneeded columns

Boaz Ben-Zvi created DRILL-5935: --- Summary: Hash Join projects unneeded columns Key: DRILL-5935 URL: https://issues.apache.org/jira/browse/DRILL-5935 Project: Apache Drill Issue Type: Bug

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r149230560 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -158,38 +165,49 @@ public DrillbitContext getContext() {

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r149234360 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -158,38 +165,49 @@ public DrillbitContext getContext() {

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r149232323 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -158,38 +165,49 @@ public DrillbitContext getContext() {

[GitHub] drill issue #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 Stabali...

Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1023 @arina-ielchiieva Please let me know if you have any additional comments. ---

[GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit

Github user dvjyothsna commented on a diff in the pull request: https://github.com/apache/drill/pull/921#discussion_r149186970 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/TestGracefulShutdown.java --- @@ -0,0 +1,323 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit

Github user dvjyothsna commented on a diff in the pull request: https://github.com/apache/drill/pull/921#discussion_r149186401 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java --- @@ -348,6 +354,21 @@ public void run() { */ }

[GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit

Github user dvjyothsna commented on a diff in the pull request: https://github.com/apache/drill/pull/921#discussion_r149185238 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitStateManager.java --- @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r149173898 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/user/PlanSplitter.java --- @@ -79,6 +80,15 @@ public QueryPlanFragments

[GitHub] drill pull request #652: DRILL-4990:Use new HDFS API access instead of listS...

Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/652#discussion_r149173203 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java --- @@ -151,17 +152,32 @@ public WorkspaceSchemaFactory(

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r149168826 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -158,38 +165,49 @@ public DrillbitContext getContext() {

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r149168081 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java --- @@ -828,8 +828,13 @@ public void close() throws Exception {

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r149167784 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -158,38 +165,49 @@ public DrillbitContext getContext() {

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r149167742 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -158,38 +165,49 @@ public DrillbitContext getContext() {

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r149167716 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -158,38 +165,49 @@ public DrillbitContext getContext() {

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r149166078 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -59,12 +61,14 @@ public class WorkManager implements

[GitHub] drill issue #978: DRILL-5842: Refactor and simplify the fragment, operator c...

Github user sohami commented on the issue: https://github.com/apache/drill/pull/978 +1 LGTM. Thanks for clarification. ---