[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r154477971 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/BatchGroup.java --- @@ -280,17 +278,14 @@ private void

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r154478390 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/cache/TestBatchSerialization.java --- @@ -117,11 +117,12 @@ public void

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r154476694 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorSerializer.java --- @@ -62,27 +72,65 @@ public Writer write(VectorAccessible

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r154475785 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorSerializer.java --- @@ -62,27 +72,65 @@ public Writer write(VectorAccessible

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r154478770 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorSerializer.java --- @@ -62,27 +72,65 @@ public Writer write(VectorAccessible

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r154475350 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorSerializer.java --- @@ -62,27 +72,65 @@ public Writer write(VectorAccessible

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r154478289 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/BatchGroup.java --- @@ -249,7 +247,7 @@ public void close()

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r154477573 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/SpillSet.java --- @@ -331,6 +337,43 @@ public long

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r154477089 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorSerializer.java --- @@ -62,27 +72,65 @@ public Writer write(VectorAccessible

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r154476440 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorSerializer.java --- @@ -40,20 +52,18 @@ */ public static

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r154477815 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/SpillSet.java --- @@ -419,6 +462,13 @@ public SpillSet(DrillConfig

[jira] [Created] (DRILL-6004) Direct buffer bounds checking should be disabled by default

Vlad Rozov created DRILL-6004: - Summary: Direct buffer bounds checking should be disabled by default Key: DRILL-6004 URL: https://issues.apache.org/jira/browse/DRILL-6004 Project: Apache Drill

[GitHub] drill issue #1057: DRILL-5993 Generic Copiers With Append Methods

Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1057 @Ben-Zvi @paul-rogers As per our discussion I've added Paul's generic copiers and have provided a GenericCopier that works for RecordBatches that do not have selection vectors. I've enhanced the

Re: [VOTE] Release Apache Drill 1.12.0 - rc0

I'm seeing a unit test failure tracked by DRILL-6003, when building from [4]. Can someone take a look? On Wed, Nov 29, 2017 at 6:50 AM, Arina Ielchiieva wrote: > Hi all, > > I'd like to propose the first release candidate (rc0) of Apache Drill, > version 1.12.0. > > The

[jira] [Created] (DRILL-6003) Unit test testLazyInitWhenDynamicUdfSupportIsDisabled(org.apache.drill.TestDynamicUDFSupport fails with FUNCTION ERROR: Failure reading Function class.

Abhishek Girish created DRILL-6003: -- Summary: Unit test testLazyInitWhenDynamicUdfSupportIsDisabled(org.apache.drill.TestDynamicUDFSupport fails with FUNCTION ERROR: Failure reading Function class. Key: DRILL-6003

Re: [VOTE] Release Apache Drill 1.12.0 - rc0

Downloaded built gz file. Ran Drill. Exercised the queue-based memory allocation options and ran a query. Functionality and UI passed basic sanity tests. (UI tests are not yet automated, so this verification has to be done by hand.) Krystal had done a full test earlier, which passed. So, +1

Aw: RE: Re: [VOTE] Release Apache Drill 1.12.0 - rc0

  No, this time it's 1.12 driver against 1.12 drillbit. The error was introduced in 1.11. If I build the driver from source, everthing is fine. Gesendet: Freitag, 01. Dezember 2017 um 21:14 Uhr Von: "Kunal Khatua" An: "dev@drill.apache.org" Betreff: RE:

RE: Re: [VOTE] Release Apache Drill 1.12.0 - rc0

Are you trying to connect to pre-1.11.0 server? The JIRA mentions you swapped out Drill 1.10 JDBC clients with 1.11.0 and hit an issue. -Original Message- From: korlawu...@die-optimisten.net [mailto:korlawu...@die-optimisten.net] Sent: Friday, December 01, 2017 12:11 PM To:

Aw: Re: [VOTE] Release Apache Drill 1.12.0 - rc0

-1   Because the prebuild drill-jdbc-driver is not usable: https://issues.apache.org/jira/browse/DRILL-5702

Re: [VOTE] Release Apache Drill 1.12.0 - rc0

Sorry, incorrectly estimated end date, it should be at 3:00 PM UTC (7:00 AM PST), December 2, 2017. So far we don't have enough votes to accept the release candidate. Please vote! Kind regards Arina On Thu, Nov 30, 2017 at 9:36 PM, Kunal Khatua wrote: > Performed sanity