[jira] [Resolved] (DRILL-3958) Improve error message when JDBC driver not found

2017-12-20 Thread Kunal Khatua (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kunal Khatua resolved DRILL-3958. - Resolution: Fixed > Improve error message when JDBC driver not found >

[GitHub] drill issue #1067: DRILL-3958: Return a valid error message when storage plu...

2017-12-20 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1067 @amansinha100 / @parthchandra can you review this? ---

[GitHub] drill pull request #1077: DRILL-5068: Create sys.profiles table

2017-12-20 Thread kkhatua
GitHub user kkhatua opened a pull request: https://github.com/apache/drill/pull/1077 DRILL-5068: Create sys.profiles table (Thanks to Hongze Zhang for the initial work) Introduced a non-distributed (i.e. the foreman Drillbit executes a single fragment query) system table to

[jira] [Created] (DRILL-6049) Rollup of hygiene changes from "batch size" project

2017-12-20 Thread Paul Rogers (JIRA)
Paul Rogers created DRILL-6049: -- Summary: Rollup of hygiene changes from "batch size" project Key: DRILL-6049 URL: https://issues.apache.org/jira/browse/DRILL-6049 Project: Apache Drill Issue

[GitHub] drill pull request #914: DRILL-5657: Size-aware vector writer structure

2017-12-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/914 ---

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r158183470 --- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java --- @@ -309,7 +314,7 @@ public void setInitialCapacity(final int valueCount)

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r158197926 --- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java --- @@ -296,26 +655,75 @@ public void transferTo(Nullable${minor.class}Vector

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r158196904 --- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java --- @@ -68,96 +85,441 @@ private final UInt1Vector bits = new

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r158196570 --- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java --- @@ -68,96 +85,441 @@ private final UInt1Vector bits = new

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r158183647 --- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java --- @@ -15,13 +15,19 @@ * See the License for the specific language

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r158181548 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java --- @@ -471,8 +519,8 @@ public void close() throws Exception

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r158197616 --- Diff: exec/vector/src/main/codegen/templates/FixedValueVectors.java --- @@ -874,6 +880,46 @@ public void setSafe(int index, BigDecimal value) {

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r158198379 --- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java --- @@ -804,6 +1406,310 @@ public void fromNotNullable(${minor.class}Vector

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r158197380 --- Diff: exec/memory/base/src/main/java/org/apache/drill/exec/util/MemoryUtils.java --- @@ -0,0 +1,186 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r158198205 --- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java --- @@ -456,55 +818,191 @@ public void get(int index,

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r158183682 --- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java --- @@ -15,13 +15,19 @@ * See the License for the specific language

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r158183275 --- Diff: protocol/src/main/protobuf/UserBitShared.proto --- @@ -148,6 +148,8 @@ message SerializedField { optional int32 value_count = 4;

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r158197120 --- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java --- @@ -68,96 +85,441 @@ private final UInt1Vector bits = new

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r158196450 --- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java --- @@ -68,96 +85,441 @@ private final UInt1Vector bits = new

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r158196813 --- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java --- @@ -51,6 +57,17 @@ public final class ${className} extends

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r158197511 --- Diff: exec/vector/.externalToolBuilders/Maven_Ant_Builder.launch --- @@ -0,0 +1,25 @@ + --- End diff -- Did this file want to be

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r158182667 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableColumnReader.java --- @@ -165,17 +181,133 @@

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r158196388 --- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java --- @@ -68,96 +85,441 @@ private final UInt1Vector bits = new

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r158196333 --- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java --- @@ -51,6 +57,17 @@ public final class ${className} extends

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r158183519 --- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java --- @@ -386,7 +391,7 @@ public void reAlloc() { throw new

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r158181731 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java --- @@ -449,7 +451,7 @@ public void close() throws

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r158180993 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorSerializer.java --- @@ -40,20 +52,18 @@ */ public static

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r158180527 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorSerializer.java --- @@ -62,27 +72,65 @@ public Writer write(VectorAccessible

[GitHub] drill pull request #1057: DRILL-5993 VectorContainer Append and Generic Copi...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1057#discussion_r158179222 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java --- @@ -353,6 +353,23 @@ public int getRecordCount() {

[GitHub] drill pull request #1057: DRILL-5993 VectorContainer Append and Generic Copi...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1057#discussion_r158179561 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/svremover/GenericCopierTest.java --- @@ -0,0 +1,41 @@ +/* + *

[GitHub] drill pull request #1070: DRILL-6004: Direct buffer bounds checking should b...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1070#discussion_r158164933 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/XXHash.java --- @@ -166,9 +164,7 @@ public static long hash64(double val, long

[GitHub] drill pull request #1070: DRILL-6004: Direct buffer bounds checking should b...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1070#discussion_r158165417 --- Diff: exec/memory/base/src/main/java/org/apache/drill/exec/memory/BoundsChecking.java --- @@ -17,19 +17,92 @@ */ package

[GitHub] drill pull request #1070: DRILL-6004: Direct buffer bounds checking should b...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1070#discussion_r158165539 --- Diff: exec/memory/base/src/main/java/org/apache/drill/exec/memory/BoundsChecking.java --- @@ -17,19 +17,92 @@ */ package

[GitHub] drill pull request #1066: DRILL-3993: Changes to support Calcite 1.15

2017-12-20 Thread chunhui-shi
Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/1066#discussion_r158173488 --- Diff: exec/java-exec/src/test/resources/record/test_recorditerator.json --- @@ -60,7 +60,7 @@ @id:2, child:1,

[GitHub] drill pull request #1066: DRILL-3993: Changes to support Calcite 1.15

2017-12-20 Thread chunhui-shi
Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/1066#discussion_r158173904 --- Diff: exec/jdbc-all/pom.xml --- @@ -572,7 +572,7 @@ This is likely due to you adding new dependencies to a java-exec

[GitHub] drill pull request #1066: DRILL-3993: Changes to support Calcite 1.15

2017-12-20 Thread chunhui-shi
Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/1066#discussion_r158117382 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java --- @@ -470,34 +576,32 @@ public void

[GitHub] drill pull request #1066: DRILL-3993: Changes to support Calcite 1.15

2017-12-20 Thread chunhui-shi
Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/1066#discussion_r158105572 --- Diff: contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcPrel.java --- @@ -62,7 +62,7 @@ public JdbcPrel(RelOptCluster

[GitHub] drill pull request #1066: DRILL-3993: Changes to support Calcite 1.15

2017-12-20 Thread chunhui-shi
Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/1066#discussion_r158120135 --- Diff: contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseSchemaFactory.java --- @@ -72,7 +72,16 @@ public AbstractSchema

[GitHub] drill pull request #1066: DRILL-3993: Changes to support Calcite 1.15

2017-12-20 Thread chunhui-shi
Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/1066#discussion_r158103733 --- Diff: contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseSchemaFactory.java --- @@ -72,7 +72,16 @@ public AbstractSchema

[GitHub] drill pull request #1071: DRILL-6028: Allow splitting generated code in Chai...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1071#discussion_r158164670 --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestUnionDistinct.java --- @@ -754,4 +756,37 @@ public void testDrill4147_1() throws Exception {

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158159524 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158160669 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158158949 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158160610 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158161425 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158161881 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestSqlPatterns.java --- @@ -446,6 +446,61 @@ public void

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158160928 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158160058 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158160358 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1073: DRILL-5967: Fixed memory leak in OrderedPartitionS...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1073#discussion_r158158542 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionSenderRootExec.java --- @@ -341,6 +351,10 @@ public

[GitHub] drill pull request #1074: DRILL-6025: Display execution time of a query in R...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1074#discussion_r158150927 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java --- @@ -195,23 +196,31 @@ public String

[GitHub] drill pull request #1075: DRILL-6030: Managed sort should minimize number of...

2017-12-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1075#discussion_r158150320 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SortConfig.java --- @@ -84,7 +85,7 @@ public

[GitHub] drill issue #1076: DRILL-6036: Create sys.connections table

2017-12-20 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/1076 +1. Nice work. ---

[GitHub] drill issue #1055: DRILL-5973 : Support injection of time-bound pauses in se...

2017-12-20 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1055 Didn't make sense to have small commits in the PR. So I've squashed and rebased onto 1.13.0. ---

[GitHub] drill pull request #1076: DRILL-6036: Create sys.connections table

2017-12-20 Thread kkhatua
GitHub user kkhatua opened a pull request: https://github.com/apache/drill/pull/1076 DRILL-6036: Create sys.connections table Introduced a distributed (i.e. each Drillbit executes a fragment) system table to list all the active client connections to all the Drillbits in a cluster.

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread sachouche
Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158086368 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread sachouche
Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158085723 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread sachouche
Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158084806 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread sachouche
Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158080247 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread sachouche
Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158080071 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread sachouche
Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158074965 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread sachouche
Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158074289 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread sachouche
Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158072762 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158033645 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158029512 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158025793 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158032627 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158034838 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158030478 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158031007 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158029113 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158030234 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill pull request #1072: DRILL-5879: Improved SQL Pattern Contains Performa...

2017-12-20 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1072#discussion_r158033448 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -19,44 +19,283 @@ import

[GitHub] drill issue #1026: DRILL-5919: Add non-numeric support for JSON processing

2017-12-20 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1026 @vladimirtkach thanks for adding tests for math functions. New changes look good to me. @paul-rogers please take a look. ---