[GitHub] drill pull request #1198: DRILL-6294: Changes to support Calcite 1.16.0

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1198#discussion_r178404654 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java --- @@ -1142,16 +1142,8 @@ public void moveToCurrentRow() throws

[GitHub] drill issue #1182: DRILL-6287: apache-release profile should be disabled by ...

Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1182 @parthchandra Please review ---

[GitHub] drill pull request #1198: DRILL-6294: Changes to support Calcite 1.16.0

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/1198#discussion_r178395314 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java --- @@ -1142,16 +1142,8 @@ public void moveToCurrentRow() throws

[GitHub] drill pull request #1196: DRILL-6286: Fixed incorrect reference to shutdown ...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1196#discussion_r178375583 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -86,6 +86,9 @@ private final StatusThread statusThread;

[GitHub] drill pull request #1196: DRILL-6286: Fixed incorrect reference to shutdown ...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1196#discussion_r178376213 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -212,19 +218,29 @@ private boolean areQueriesAndFragmentsEmpty() {

[GitHub] drill pull request #1196: DRILL-6286: Fixed incorrect reference to shutdown ...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1196#discussion_r178376362 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -212,19 +218,29 @@ private boolean areQueriesAndFragmentsEmpty() {

[GitHub] drill pull request #1198: DRILL-6294: Changes to support Calcite 1.16.0

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1198#discussion_r178371341 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillReduceAggregatesRule.java --- @@ -218,7 +218,8 @@ private void

[GitHub] drill pull request #1195: DRILL-6273: Removed dependency licensed under Cate...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1195#discussion_r178364790 --- Diff: tools/fmpp/src/main/java/bsh/EvalError.java --- @@ -0,0 +1,28 @@ +/** --- End diff -- Please do not use doc comment for the

[GitHub] drill pull request #1195: DRILL-6273: Removed dependency licensed under Cate...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1195#discussion_r178365989 --- Diff: tools/fmpp/src/main/java/bsh/EvalError.java --- @@ -0,0 +1,28 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] drill pull request #1195: DRILL-6273: Removed dependency licensed under Cate...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1195#discussion_r178366218 --- Diff: tools/fmpp/pom.xml --- @@ -57,6 +57,10 @@ commons-logging-api commons-logging + +

[GitHub] drill pull request #1198: DRILL-6294: Changes to support Calcite 1.16.0

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/1198#discussion_r178364263 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillReduceAggregatesRule.java --- @@ -218,7 +218,8 @@ private void

[jira] [Created] (DRILL-6303) Provide a button to copy the Drillbit's JStack shown in /threads

Kunal Khatua created DRILL-6303: --- Summary: Provide a button to copy the Drillbit's JStack shown in /threads Key: DRILL-6303 URL: https://issues.apache.org/jira/browse/DRILL-6303 Project: Apache Drill

[GitHub] drill issue #1197: DRILL-6279: UI indicates operators that spilled in-memory...

Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1197 @arina-ielchiieva could you review this? I will be using this commit as the basis for [DRILL-6289](https://issues.apache.org/jira/browse/DRILL-6289) ---

[GitHub] drill issue #1170: DRILL-6223: Fixed several Drillbit failures due to schema...

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1170 Over the last year, we've tended to favor including unit tests with each PR. There don't seem to be any with this one, yet we are proposing to make a fairly complex change. Perhaps tests can be

[GitHub] drill issue #1170: DRILL-6223: Fixed several Drillbit failures due to schema...

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1170 BTW: thanks for tackling such a difficult, core issue in Drill. Drill claims to be a) schema free and b) SQL compliant. SQL is based on operations over relations with a fixed number of columns

[GitHub] drill issue #1198: DRILL-6294: Changes to support Calcite 1.16.0

Github user vvysotskyi commented on the issue: https://github.com/apache/drill/pull/1198 @amansinha100, @chunhui-shi could you please take a look? ---

[GitHub] drill issue #1173: DRILL-6259: Support parquet filter push down for complex ...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1173 Done. ---

[GitHub] drill pull request #1198: DRILL-6294: Changes to support Calcite 1.16.0

GitHub user vvysotskyi opened a pull request: https://github.com/apache/drill/pull/1198 DRILL-6294: Changes to support Calcite 1.16.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/vvysotskyi/drill DRILL-6294 Alternatively you

[GitHub] drill pull request #1166: DRILL-6016 - Fix for Error reading INT96 created b...

Github user rajrahul commented on a diff in the pull request: https://github.com/apache/drill/pull/1166#discussion_r178324303 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -61,6 +60,7 @@ import

[GitHub] drill issue #1060: DRILL-5846: Improve parquet performance for Flat Data Typ...

Github user sachouche commented on the issue: https://github.com/apache/drill/pull/1060 Parth, - I have attached, within the DRILL-5846, two profiles with latest Apache code and this PR request (bounds checks are off): o Used one thread in each run o I observe ~3x

[GitHub] drill issue #1173: DRILL-6259: Support parquet filter push down for complex ...

Github user amansinha100 commented on the issue: https://github.com/apache/drill/pull/1173 @arina-ielchiieva could you rebase this on latest master ? thanks. ---

[GitHub] drill pull request #1178: DRILL-6278: Removed temp codegen directory in test...

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1178 ---

[GitHub] drill pull request #1172: DRILL-6256: Remove references to java 7 from readm...

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1172 ---

[GitHub] drill pull request #1105: DRILL-6125: Fix possible memory leak when query is...

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1105 ---

[GitHub] drill pull request #1190: DRILL-5937: ExecConstants: changed comment, timeou...

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1190 ---

[GitHub] drill pull request #1192: DRILL-6299: Fixed a filter pushed down issue when ...

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1192 ---

[GitHub] drill pull request #1194: DRILL-6300: Refresh protobuf C++ source files

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1194 ---

[GitHub] drill pull request #1179: DRILL-6254: IllegalArgumentException: the requeste...

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1179 ---

Build failed in Jenkins: drill-scm #951

See Changes: [asinha] DRILL-6300: Refresh protobuf C++ source files [asinha] DRILL-6299: Fixed a filter pushed down issue when a column doesn't have [asinha] DRILL-5937: drill-module.conf : Changed timeout to 30

[GitHub] drill pull request #1166: DRILL-6016 - Fix for Error reading INT96 created b...

Github user rajrahul commented on a diff in the pull request: https://github.com/apache/drill/pull/1166#discussion_r178290675 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -780,17 +780,31 @@ public void

[GitHub] drill issue #1060: DRILL-5846: Improve parquet performance for Flat Data Typ...

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/1060 I feel putting this PR in without finalizing DRILL-6301 is putting the cart before the horse. (BTW, it would help the discussion if the benchmarks were published !). My observation based on

[GitHub] drill pull request #1166: DRILL-6016 - Fix for Error reading INT96 created b...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1166#discussion_r178255699 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -61,6 +60,7 @@ import

[GitHub] drill pull request #1166: DRILL-6016 - Fix for Error reading INT96 created b...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1166#discussion_r178255942 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -780,17 +780,31 @@ public void

[GitHub] drill issue #1168: DRILL-6246: Reduced the size of the jdbc-all jar file

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/1168 I would recommend trying to setup a connection using Spotfire or Squirrel and running a couple of metadata queries and a couple of queries on complex data. (These have traditionally been areas

[GitHub] drill pull request #1197: DRILL-6279: UI indicates operators that spilled in...

GitHub user kkhatua opened a pull request: https://github.com/apache/drill/pull/1197 DRILL-6279: UI indicates operators that spilled in-memory data to disk 1. Detect the presence of an operator that has spilled to disk, in the Operators Overview section of a query's profile page.