Re: Connection Persistence

2020-01-17 Thread Paul Rogers
Hi Charles, Poked around a bit. Turns out that the Cassandra client seems to work a bit differently than a JDBC client. From the JavaDoc page: "Session instances are thread-safe and usually a single instance is enough per application." Given this, you might be able to cache a single connection

Re: ScanBatchCreator

2020-01-17 Thread Paul Rogers
Hi Charles, Excellent question. The short answer is "no", but the longer answer is "we should fix this so the answer is yes." The reason the answer is "no" today is that Drill uses some odd magic to match up scan batch creators with plugins. In particular, the class of the second argument to

ScanBatchCreator

2020-01-17 Thread Charles Givre
Hey Paul, In looking through the storage plugins, it seems as if the scan batch creator is virtually identical EXCEPT for arguments passed to the RecordReader class. I'm wondering if that could be abstracted in the Base Storage PR as well. -- C

Re: Connection Persistence

2020-01-17 Thread Charles Givre
Hi Paul, I did take a look at the JDBC plugin and it appeared that the code to create the actual connection was here:

Re: Connection Persistence

2020-01-17 Thread Paul Rogers
Hi Charles, I've seen nothing like this in my travels through Drill code. My guess is that you'd have to create a connection pool. I'd also guess that connection pool implementations exist that could be reused. Drill is multi-threaded: any one Drillbit could be running many concurrent

[GitHub] [drill] arina-ielchiieva opened a new pull request #1956: DRILL-7467: Jdbc plugin enhancements and fixes

2020-01-17 Thread GitBox
arina-ielchiieva opened a new pull request #1956: DRILL-7467: Jdbc plugin enhancements and fixes URL: https://github.com/apache/drill/pull/1956 [DRILL-7467](https://issues.apache.org/jira/browse/DRILL-7467): Jdbc plugin enhancements and fixes ## Description 1. Added logic to

[jira] [Created] (DRILL-7530) Fix class names in loggers

2020-01-17 Thread Arina Ielchiieva (Jira)
Arina Ielchiieva created DRILL-7530: --- Summary: Fix class names in loggers Key: DRILL-7530 URL: https://issues.apache.org/jira/browse/DRILL-7530 Project: Apache Drill Issue Type: Task

Re: Updated invitation: Drill Hangout @ Fri Jan 24, 2020 9:30am - 10:30am (EST) (dev@drill.apache.org)

2020-01-17 Thread Igor Guzenko
Sorry didn't notice that date is 24 Jan, all fine. On Fri, Jan 17, 2020 at 4:18 PM Igor Guzenko wrote: > Hello Charles, > > Could you please move call to the next week, since Volodymyr may not be > present? > > Thanks, > Igor > > > On Thu, Jan 16, 2020 at 5:58 PM wrote: > >> *This event has

Re: Updated invitation: Drill Hangout @ Fri Jan 24, 2020 9:30am - 10:30am (EST) (dev@drill.apache.org)

2020-01-17 Thread Igor Guzenko
Hello Charles, Could you please move call to the next week, since Volodymyr may not be present? Thanks, Igor On Thu, Jan 16, 2020 at 5:58 PM wrote: > *This event has been changed.* > Drill Hangout > > *When* > Fri Jan 24, 2020 9:30am – 10:30am Eastern Time - New York > *Where* > Google

Connection Persistence

2020-01-17 Thread Charles Givre
Hello Drill Devs I have a question for you. I'm working on a storage plugin for Apache Cassandra. I've got the queries mostly working, but I have a question. Connections to Cassandra are meant to be opened once and remain open and so they are "heavy". It takes about 2 seconds to connect to

[GitHub] [drill] arina-ielchiieva commented on issue #1955: DRILL-7491: Incorrect count() returned for complex types in parquet

2020-01-17 Thread GitBox
arina-ielchiieva commented on issue #1955: DRILL-7491: Incorrect count() returned for complex types in parquet URL: https://github.com/apache/drill/pull/1955#issuecomment-575580335 @paul-rogers Igor had addressed code review comments and left one comment explaining the background of the