cgivre commented on pull request #2067:
URL: https://github.com/apache/drill/pull/2067#issuecomment-623045652
@vvysotskyi
Thanks for the quick review! I addressed all your review comments.
Regarding updating the website, I will be happy to do so, but I've never done
it before. I'll
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419037351
##
File path: exec/java-exec/src/test/java/org/apache/drill/test/ClusterTest.java
##
@@ -125,4 +139,29 @@ public static void run(String query, Object...
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419037264
##
File path: exec/java-exec/src/test/java/org/apache/drill/test/ClusterTest.java
##
@@ -125,4 +139,29 @@ public static void run(String query, Object...
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419036988
##
File path: protocol/src/main/protobuf/UserBitShared.proto
##
@@ -379,7 +379,11 @@ enum CoreOperatorType {
SHP_SUB_SCAN = 65;
METADATA_HANDLER = 66;
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419036349
##
File path:
contrib/format-spss/src/main/java/org/apache/drill/exec/store/spss/SpssBatchReader.java
##
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419036031
##
File path:
contrib/format-spss/src/main/java/org/apache/drill/exec/store/spss/SpssBatchReader.java
##
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419035541
##
File path:
contrib/format-spss/src/main/java/org/apache/drill/exec/store/spss/SpssBatchReader.java
##
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419035598
##
File path: contrib/format-spss/src/main/resources/bootstrap-format-plugins.json
##
@@ -0,0 +1,37 @@
+{
+ "storage":{
Review comment:
Fixed
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419035528
##
File path:
contrib/format-spss/src/main/java/org/apache/drill/exec/store/spss/SpssBatchReader.java
##
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419035267
##
File path:
contrib/format-spss/src/main/java/org/apache/drill/exec/store/spss/SpssBatchReader.java
##
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419034736
##
File path:
contrib/format-spss/src/main/java/org/apache/drill/exec/store/spss/SpssBatchReader.java
##
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419034417
##
File path: contrib/format-spss/README.md
##
@@ -0,0 +1,87 @@
+# Format Plugin for SPSS (SAV) Files
+This format plugin enables Apache Drill to read and
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419034264
##
File path: contrib/format-spss/README.md
##
@@ -0,0 +1,87 @@
+# Format Plugin for SPSS (SAV) Files
+This format plugin enables Apache Drill to read and
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419034126
##
File path: contrib/format-spss/README.md
##
@@ -0,0 +1,87 @@
+# Format Plugin for SPSS (SAV) Files
+This format plugin enables Apache Drill to read and
akkapur commented on a change in pull request #1888:
URL: https://github.com/apache/drill/pull/1888#discussion_r419029352
##
File path:
contrib/storage-druid/src/main/java/org/apache/drill/exec/store/druid/DruidScanner.java
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache
akkapur commented on a change in pull request #1888:
URL: https://github.com/apache/drill/pull/1888#discussion_r419025233
##
File path:
contrib/storage-druid/src/main/java/org/apache/drill/exec/store/druid/DruidScanner.java
##
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache
vvysotskyi commented on a change in pull request #2072:
URL: https://github.com/apache/drill/pull/2072#discussion_r419006884
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/metadata/MetadataControllerBatch.java
##
@@ -127,113 +126,93 @@
vvysotskyi commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419001452
##
File path: contrib/format-spss/README.md
##
@@ -0,0 +1,87 @@
+# Format Plugin for SPSS (SAV) Files
+This format plugin enables Apache Drill to read
vvysotskyi commented on a change in pull request #2068:
URL: https://github.com/apache/drill/pull/2068#discussion_r418995949
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/extended/ExtendedTypeFieldFactory.java
##
@@ -0,0 +1,207 @@
+/*
+ *
19 matches
Mail list logo
