Re: [PR] DRILL-8158: Remove non-reproducible entry (drill)

[via GitHub]

jnturton merged PR #2805:
URL: https://github.com/apache/drill/pull/2805


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] DRILL-8437: Add Header Index Pagination (drill)

[via GitHub]

cgivre merged PR #2806:
URL: https://github.com/apache/drill/pull/2806


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] DRILL-8158: Remove non-reproducible entry (drill)

[via GitHub]

hboutemy commented on code in PR #2805:
URL: https://github.com/apache/drill/pull/2805#discussion_r1199775459


##
pom.xml:
##
@@ -562,7 +562,6 @@
 ^git\.commit\..*$
 ^git\.dirty$
 ^git\.tags$
-
^git\.total\.commit\.count$

Review Comment:
   in fact, if you do a shallow git clone (= what Maven Release Plugin does to 
reduce download), you get 1 instead of the value of the full content: yes, not 
so easy to guess :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] DRILL-8158: Remove non-reproducible entry (drill)

[via GitHub]

hboutemy commented on code in PR #2805:
URL: https://github.com/apache/drill/pull/2805#discussion_r1199775459


##
pom.xml:
##
@@ -562,7 +562,6 @@
 ^git\.commit\..*$
 ^git\.dirty$
 ^git\.tags$
-
^git\.total\.commit\.count$

Review Comment:
   in fact, if you do a shallow git clone, you get 1 instead of the value of 
the full content: yes, not so easy to guess :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] DRILL-8437: Add Header Index Pagination (drill)

[via GitHub]

cgivre opened a new pull request, #2806:
URL: https://github.com/apache/drill/pull/2806

   # [DRILL-8437](https://issues.apache.org/jira/browse/DRILL-8437): Add Header 
Index Pagination
   
   (Please replace `PR Title` with actual PR Title)
   
   ## Description
   See below
   
   
   ## Documentation
   Updated README.
   
   ## Header Index Pagination
   Header index pagination is used when the API in question returns a link to 
the next page in the response header.  Shopify is one such example of an API 
that does this. 
   
   The only configuration option is the `nextPageParam` which is the parameter 
that Drill should look for in the response header.
   
   ```json
"paginator": {
   "nextPageParam": "page",
   "method": "HEADER_INDEX"
 }
   ```
   
   
   ## Testing
   Added UT and manually tested with Shopify API.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (DRILL-8437) Add Header Index Pagination

[Charles Givre (Jira)]

Charles Givre created DRILL-8437:


 Summary: Add Header Index Pagination
 Key: DRILL-8437
 URL: https://issues.apache.org/jira/browse/DRILL-8437
 Project: Apache Drill
  Issue Type: Improvement
  Components: Storage - HTTP
Affects Versions: 1.21.1
Reporter: Charles Givre
Assignee: Charles Givre
 Fix For: 1.22.0


Some APIs include pagination fields in the HTTP response headers.  This PR adds 
a new pagination method called Header Index which supports that.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] DRILL-8158 remove non-reproducible entry (drill)

[via GitHub]

jnturton commented on code in PR #2805:
URL: https://github.com/apache/drill/pull/2805#discussion_r1199746266


##
pom.xml:
##
@@ -562,7 +562,6 @@
 ^git\.commit\..*$
 ^git\.dirty$
 ^git\.tags$
-
^git\.total\.commit\.count$

Review Comment:
   Thank you for this. I'd have thought that the count of the commits leading 
to up to some tagged commit _is_ reproducible? Or are we catering for the case 
where a build system makes a shallow clone for efficiency and that truncates 
the commit history?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] DRILL-8158 remove non-reproducible entry (drill)

[via GitHub]

hboutemy opened a new pull request, #2805:
URL: https://github.com/apache/drill/pull/2805

   [DRILL-8158](https://issues.apache.org/jira/browse/DRILL-DRILL-8158
   
   see rebuild of release 1.21.1 
https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/drill/README.md


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org