[GitHub] drill pull request: Initial version of RecordIterator and MergeJoi...

2015-10-07 Thread amithadke
GitHub user amithadke opened a pull request: https://github.com/apache/drill/pull/190 Initial version of RecordIterator and MergeJoin rewrite. You can merge this pull request into a Git repository by running: $ git pull https://github.com/amithadke/drill mergejoin-rewrite

[GitHub] drill pull request: Initial version of RecordIterator and MergeJoi...

2015-10-08 Thread amithadke
Github user amithadke commented on the pull request: https://github.com/apache/drill/pull/190#issuecomment-146626167 @jacques-n @StevenMPhillips @jaltekruse --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] drill pull request: Add Sequence file support.

2015-10-21 Thread amithadke
GitHub user amithadke opened a pull request: https://github.com/apache/drill/pull/214 Add Sequence file support. Read key values from sequence file as VarBinary. You can merge this pull request into a Git repository by running: $ git pull https://github.com/amithadke/drill

[GitHub] drill pull request: Add Sequence file support.

2015-10-21 Thread amithadke
Github user amithadke commented on the pull request: https://github.com/apache/drill/pull/214#issuecomment-150022336 @jaltekruse @StevenMPhillips @jacques-n --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] drill pull request: Add Sequence file support.

2015-10-21 Thread amithadke
Github user amithadke commented on a diff in the pull request: https://github.com/apache/drill/pull/214#discussion_r42682512 --- Diff: protocol/src/main/java/org/apache/drill/exec/proto/beans/CoreOperatorType.java --- @@ -58,7 +58,8 @@ HBASE_SUB_SCAN(33), WINDOW

[GitHub] drill pull request: DRILL-3963 Add Sequence file support.

2015-10-26 Thread amithadke
Github user amithadke commented on a diff in the pull request: https://github.com/apache/drill/pull/214#discussion_r43066184 --- Diff: protocol/src/main/java/org/apache/drill/exec/proto/beans/CoreOperatorType.java --- @@ -58,7 +58,8 @@ HBASE_SUB_SCAN(33), WINDOW

[GitHub] drill pull request: DRILL-3963 Add Sequence file support.

2015-10-26 Thread amithadke
Github user amithadke commented on a diff in the pull request: https://github.com/apache/drill/pull/214#discussion_r43066207 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/sequencefile/SequenceFileRecordReader.java --- @@ -0,0 +1,141

[GitHub] drill pull request: DRILL-3963 Add Sequence file support.

2015-10-26 Thread amithadke
Github user amithadke commented on a diff in the pull request: https://github.com/apache/drill/pull/214#discussion_r43066234 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/sequencefile/SequenceFileRecordReader.java --- @@ -0,0 +1,141

[GitHub] drill pull request: DRILL-3963 Add Sequence file support.

2015-10-26 Thread amithadke
Github user amithadke commented on a diff in the pull request: https://github.com/apache/drill/pull/214#discussion_r43066250 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/sequencefile/SequenceFileRecordReader.java --- @@ -0,0 +1,141

[GitHub] drill pull request: DRILL-3963 Add Sequence file support.

2015-10-26 Thread amithadke
Github user amithadke commented on a diff in the pull request: https://github.com/apache/drill/pull/214#discussion_r43066220 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/sequencefile/SequenceFileRecordReader.java --- @@ -0,0 +1,141

[GitHub] drill pull request: DRILL-3963 Add Sequence file support.

2015-10-26 Thread amithadke
Github user amithadke commented on a diff in the pull request: https://github.com/apache/drill/pull/214#discussion_r43067968 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/sequencefile/SequenceFileRecordReader.java --- @@ -0,0 +1,146

[GitHub] drill pull request: DRILL-3963 Add Sequence file support.

2015-10-26 Thread amithadke
Github user amithadke commented on a diff in the pull request: https://github.com/apache/drill/pull/214#discussion_r43073521 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/sequencefile/SequenceFileRecordReader.java --- @@ -0,0 +1,146

[GitHub] drill pull request: DRILL-3963 Add Sequence file support.

2015-10-26 Thread amithadke
Github user amithadke commented on the pull request: https://github.com/apache/drill/pull/214#issuecomment-151378062 TextRecordReaders and others do not use impersonation during setup. Hive probably had different issue. ImplCreator getRecordBatch() calls getBatch() using proxy

[GitHub] drill pull request: DRILL-3963 Add Sequence file support.

2015-10-26 Thread amithadke
Github user amithadke commented on the pull request: https://github.com/apache/drill/pull/214#issuecomment-151379334 @sudheeshkatkam inputFormat.getRecordReader which internally does path.getFileSystem(conf); As far as this is called under proxy we are good. If I&#

[GitHub] drill pull request: DRILL-3963 Add Sequence file support.

2015-10-26 Thread amithadke
Github user amithadke commented on the pull request: https://github.com/apache/drill/pull/214#issuecomment-151379563 @sudheeshkatkam I meant we don't need to explicitly call getRecordReader() in proxy during RecordReader#setup. Call to getBatch is called under proxy. -

[GitHub] drill pull request: DRILL-3963 Add Sequence file support.

2015-10-28 Thread amithadke
Github user amithadke commented on the pull request: https://github.com/apache/drill/pull/214#issuecomment-152036324 @sudheeshkatkam I've added changes and tests for sequence file and avro. they both use hadoop's api to create recordreader. Thanks for helping out with

[GitHub] drill pull request: DRILL-3963 Add Sequence file support.

2015-10-29 Thread amithadke
Github user amithadke commented on a diff in the pull request: https://github.com/apache/drill/pull/214#discussion_r43459627 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyFormatPlugin.java --- @@ -173,7 +173,7 @@ CloseableRecordBatch

[GitHub] drill pull request: DRILL-3963 Add Sequence file support.

2015-10-29 Thread amithadke
Github user amithadke commented on a diff in the pull request: https://github.com/apache/drill/pull/214#discussion_r43460492 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/sequencefile/SequenceFileRecordReader.java --- @@ -0,0 +1,167

[GitHub] drill pull request: DRILL-3963 Add Sequence file support.

2015-10-29 Thread amithadke
Github user amithadke commented on a diff in the pull request: https://github.com/apache/drill/pull/214#discussion_r43462115 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestImpersonationQueries.java --- @@ -179,6 +199,15 @@ private static void

[GitHub] drill pull request: DRILL-3963 Add Sequence file support.

2015-10-29 Thread amithadke
Github user amithadke commented on a diff in the pull request: https://github.com/apache/drill/pull/214#discussion_r43462353 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestImpersonationQueries.java --- @@ -258,8 +286,35 @@ public void

[GitHub] drill pull request: Initial version of RecordIterator and MergeJoi...

2015-10-30 Thread amithadke
Github user amithadke commented on a diff in the pull request: https://github.com/apache/drill/pull/190#discussion_r43549769 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java --- @@ -403,14 +325,14 @@ private JoinWorker

[GitHub] drill pull request: DRILL-3963 Add Sequence file support.

2015-10-30 Thread amithadke
Github user amithadke commented on the pull request: https://github.com/apache/drill/pull/214#issuecomment-152661547 Jacques was having similar issue. I'm trying to reproduce but I'm seeing something different

[GitHub] drill pull request: Sequence file format and example query.

2015-11-22 Thread amithadke
GitHub user amithadke opened a pull request: https://github.com/apache/drill/pull/276 Sequence file format and example query. You can merge this pull request into a Git repository by running: $ git pull https://github.com/amithadke/drill sequencefilereader Alternatively you

[GitHub] drill pull request: DRILL-4109 Fix NPE in RecordIterator.

2015-11-24 Thread amithadke
GitHub user amithadke opened a pull request: https://github.com/apache/drill/pull/282 DRILL-4109 Fix NPE in RecordIterator. You can merge this pull request into a Git repository by running: $ git pull https://github.com/amithadke/drill DRILL-4109 Alternatively you can review

[GitHub] drill pull request: DRILL-4163 Schema changes support in MergeJoin...

2015-12-04 Thread amithadke
GitHub user amithadke opened a pull request: https://github.com/apache/drill/pull/292 DRILL-4163 Schema changes support in MergeJoin Operator. You can merge this pull request into a Git repository by running: $ git pull https://github.com/amithadke/drill mergejoin

[GitHub] drill pull request: Sequence file format and example query.

2015-12-04 Thread amithadke
Github user amithadke closed the pull request at: https://github.com/apache/drill/pull/276 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request: DRILL-4165 Fix a bug in counting records in ou...

2015-12-07 Thread amithadke
GitHub user amithadke opened a pull request: https://github.com/apache/drill/pull/294 DRILL-4165 Fix a bug in counting records in outgoing batch. You can merge this pull request into a Git repository by running: $ git pull https://github.com/amithadke/drill DRILL-4165

[GitHub] drill pull request: DRILL-4165 Add a precondition for size of merg...

2015-12-07 Thread amithadke
GitHub user amithadke opened a pull request: https://github.com/apache/drill/pull/295 DRILL-4165 Add a precondition for size of merge join record batch. You can merge this pull request into a Git repository by running: $ git pull https://github.com/amithadke/drill DRILL-4165

[GitHub] drill pull request: DRILL-4182 TopN schema changes support.

2015-12-10 Thread amithadke
GitHub user amithadke opened a pull request: https://github.com/apache/drill/pull/297 DRILL-4182 TopN schema changes support. You can merge this pull request into a Git repository by running: $ git pull https://github.com/amithadke/drill topn-schemachanges Alternatively you

[GitHub] drill pull request: DRILL-3991 Initial patch to support schema cha...

2015-12-14 Thread amithadke
GitHub user amithadke opened a pull request: https://github.com/apache/drill/pull/299 DRILL-3991 Initial patch to support schema changes in hash join. You can merge this pull request into a Git repository by running: $ git pull https://github.com/amithadke/drill hash-join

[GitHub] drill pull request: DRILL-4182 TopN schema changes support.

2015-12-17 Thread amithadke
Github user amithadke commented on the pull request: https://github.com/apache/drill/pull/297#issuecomment-165609542 @StevenMPhillips Can you review this change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] drill pull request: DRILL-4182 TopN schema changes support.

2015-12-18 Thread amithadke
Github user amithadke commented on the pull request: https://github.com/apache/drill/pull/297#issuecomment-165901628 @StevenMPhillips yup makes sense, should we do that under another JIRA? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] drill pull request: DRILL-4190 Don't hold on to batches from left ...

2016-01-03 Thread amithadke
GitHub user amithadke opened a pull request: https://github.com/apache/drill/pull/315 DRILL-4190 Don't hold on to batches from left side of merge join. You can merge this pull request into a Git repository by running: $ git pull https://github.com/amithadke/drill DRILL

[GitHub] drill pull request: DRILL-4196 Fix to stop returning no more data ...

2016-01-26 Thread amithadke
GitHub user amithadke opened a pull request: https://github.com/apache/drill/pull/338 DRILL-4196 Fix to stop returning no more data when output batch is fu… …ll during merge. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] drill pull request: DRILL-3715 Support all encoded vector types fo...

2015-08-31 Thread amithadke
Github user amithadke commented on the pull request: https://github.com/apache/drill/pull/136#issuecomment-136476945 @mehant @jaltekruse Could you take a look at recent patch? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on