Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/660#discussion_r91278330
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/DebugStringBuilder.java
---
@@ -0,0 +1,57 @@
+/**
+ * Licensed
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/660#discussion_r91520598
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/DrillJavaFileObject.java
---
@@ -38,14 +39,18 @@
private Map
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/660#discussion_r91278968
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/DebugStringBuilder.java
---
@@ -0,0 +1,57 @@
+/**
+ * Licensed
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/660#discussion_r91274791
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/CachedClassLoader.java
---
@@ -0,0 +1,70 @@
+/**
+ * Licensed
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/660#discussion_r91275047
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/CachedClassLoader.java
---
@@ -0,0 +1,70 @@
+/**
+ * Licensed
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/660#discussion_r91509351
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/MergeAdapter.java ---
@@ -253,7 +257,13 @@ public static MergedClassResult
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/660#discussion_r91277152
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/CodeCompiler.java ---
@@ -33,36 +32,71 @@
import
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/660#discussion_r91278889
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/DirectExpression.java
---
@@ -20,6 +20,12 @@
import
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/660#discussion_r91521257
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/DrillJavaFileObject.java
---
@@ -67,6 +72,14 @@ public boolean isCompiled
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/660#discussion_r91322821
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/TemplateClassDefinition.java
---
@@ -63,6 +78,14 @@ public SignatureHolder
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/660#discussion_r91273747
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/CachedClassLoader.java
---
@@ -0,0 +1,70 @@
+/**
+ * Licensed
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/660#discussion_r91279454
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java ---
@@ -246,6 +246,12 @@ public void rotateBlock
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/660
Paul, it's really good feature! I have left some comments in PR.
Other than that:
1. Please format the code to remove unnecessary spaces.
Examples:
addClass( key, results.get
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/672#discussion_r91078578
--- Diff: distribution/src/resources/drill-override-example.conf ---
@@ -170,7 +170,17 @@ drill.exec: {
threadpool_size: 8
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/672#discussion_r91085335
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
---
@@ -377,14 +374,12 @@ private
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/672#discussion_r91085385
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/registry/RemoteFunctionRegistry.java
---
@@ -189,6 +188,7 @@ private void
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/672
@paul-rogers made changes after 2CR. Partially reverted temporary directory
implementation logic to provide backward compatibility. Please review.
---
If your project is set up for it, you
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/672#discussion_r91077966
--- Diff: distribution/src/resources/drill-override-example.conf ---
@@ -170,7 +170,17 @@ drill.exec: {
threadpool_size: 8
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/660#discussion_r91679324
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java ---
@@ -246,6 +246,12 @@ public void rotateBlock
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/660
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r91901654
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/Utilities.java ---
@@ -43,19 +43,21 @@ public static String
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/685
@nagarajanchinnasamy
1. Please address minor changes in review comments.
2. Squash / fixup everything in one commit.
3. Update commit message: Jira-number: Jira name (ex: DRILL
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/685
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/672#discussion_r91085531
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -45,11 +45,13 @@ drill.client: {
supports-complex-types: true
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/721
Looks good. Please squash commits into one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/714#discussion_r95770127
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/CompliantTextRecordReader.java
---
@@ -91,6 +96,9 @@ public
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/721#discussion_r95764299
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -105,6 +128,17 @@ public String
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95571159
--- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl ---
@@ -106,6 +106,7 @@
STATE: ${model.getProfile().getState().name
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95570379
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -68,20 +68,35 @@
@Inject
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95570493
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java
---
@@ -114,6 +114,10 @@ public QueryProfile
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95570474
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -105,6 +120,17 @@ public String
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95569784
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -68,20 +68,35 @@
@Inject
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95436174
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -105,6 +109,25 @@ public String
GitHub user arina-ielchiieva opened a pull request:
https://github.com/apache/drill/pull/672
DRILL-5085: Add / update description for dynamic UDFs directories in â¦
â¦drill-env.sh and drill-module.conf
You can merge this pull request into a Git repository by running:
$ git
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/672#discussion_r90484226
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -207,11 +207,12 @@ drill.exec: {
// Set this property if custom
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/672#discussion_r90483802
--- Diff: distribution/src/resources/drill-env.sh ---
@@ -141,4 +141,9 @@
# Arguments passed to sqlline (the Drill shell) at all times: whether
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/669
@paul-rogers, I have made changes after CR, please review when possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/669#discussion_r89994171
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateFunctionHandler.java
---
@@ -175,22 +175,20 @@ private void
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/669#discussion_r89994657
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestDynamicUDFSupport.java ---
@@ -271,6 +271,75 @@ public void
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/669#discussion_r89993422
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropFunctionHandler.java
---
@@ -143,7 +143,7 @@ private Jar
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/669#discussion_r89993367
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateFunctionHandler.java
---
@@ -175,22 +175,20 @@ private void
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/669#discussion_r89995323
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestDynamicUDFSupport.java ---
@@ -271,6 +271,75 @@ public void
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/706#discussion_r94571676
--- Diff: exec/java-exec/src/main/codegen/templates/NewValueFunctions.java
---
@@ -17,6 +17,12 @@
*/
<@pp.dropOutputF
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/706#discussion_r95005998
--- Diff: exec/java-exec/src/main/codegen/templates/NewValueFunctions.java
---
@@ -17,8 +17,14 @@
*/
<@pp.dropOutputF
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/713
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user arina-ielchiieva opened a pull request:
https://github.com/apache/drill/pull/714
DRILL-4919: Fix select count(1) / count(*) on csv with header
When columns from file are not needed in result (`isSkipQuery = true`),
empty list of columns is replaced for text files
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/716
Looks good. Thank you, Paul!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95344665
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -105,6 +109,25 @@ public String
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/666
@paul-rogers
I have re-designed CTTAS, here is the main changes:
1. Temp table name is generated using UUID.randowmUUID().
2. All session temp tables are stored in session temp
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r92195973
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -55,13 +61,37 @@
private OptionManager
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r92196412
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -207,25 +239,165 @@ public SchemaPlus getDefaultSchema
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r92196815
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractSchema.java ---
@@ -248,4 +263,13 @@ public void dropTable(String
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r92196649
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -207,25 +239,165 @@ public SchemaPlus getDefaultSchema
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r91707161
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java
---
@@ -74,36 +74,51 @@ public PhysicalPlan
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r91709387
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/SchemaConfig.java ---
@@ -94,12 +94,16 @@ public ViewExpansionContext
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r91707928
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -55,13 +61,37 @@
private OptionManager
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r91707181
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -30,15 +33,18 @@
import
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r91706305
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/FileSystemCreateTableEntry.java
---
@@ -47,28 +47,33 @@
private
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r93030294
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordWriter.java
---
@@ -374,6 +381,13 @@ public void endRecord
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r92194798
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java
---
@@ -55,35 +57,48 @@ public
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r91959700
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JsonRecordWriter.java
---
@@ -82,6 +84,9 @@ public void init(Map<Str
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r91952635
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -207,25 +239,165 @@ public SchemaPlus getDefaultSchema
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r92197145
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/StorageStrategy.java
---
@@ -0,0 +1,82 @@
+/**
+ * Licensed to the Apache
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r92197400
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
---
@@ -478,10 +479,27 @@ private View getView
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r91953946
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
---
@@ -523,7 +541,7 @@ public Table getTable
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r91953026
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -207,25 +239,165 @@ public SchemaPlus getDefaultSchema
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r91952612
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -207,25 +239,165 @@ public SchemaPlus getDefaultSchema
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r91953272
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -207,25 +239,165 @@ public SchemaPlus getDefaultSchema
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r91952565
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -207,25 +239,165 @@ public SchemaPlus getDefaultSchema
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r91951263
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/WriterRecordBatch.java
---
@@ -174,10 +174,15 @@ protected void
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r92195010
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerUtil.java
---
@@ -235,4 +235,15 @@ public static void
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r91952394
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -55,13 +61,37 @@
private OptionManager
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r91708725
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -207,25 +239,165 @@ public SchemaPlus getDefaultSchema
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r91708832
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -207,25 +239,165 @@ public SchemaPlus getDefaultSchema
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r91709435
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/SchemaConfig.java ---
@@ -94,12 +94,16 @@ public ViewExpansionContext
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r91708701
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -115,6 +145,8 @@ public UserSession build
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r91952814
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -207,25 +239,165 @@ public SchemaPlus getDefaultSchema
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r91953573
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/StorageStrategy.java
---
@@ -0,0 +1,82 @@
+/**
+ * Licensed to the Apache
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r91706453
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java
---
@@ -55,35 +57,48 @@ public
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r91706926
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java
---
@@ -55,35 +57,48 @@ public
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/685
-1 to changes after refactoring.
using withSessionContext() is optional, so somebody can create a session
without it's unique id (for example, for CTTAS it's not acceptable). I suggest
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r93205867
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/ContextInformation.java
---
@@ -28,12 +29,14 @@
private final String
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r93207023
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
@@ -255,11 +257,12 @@ void disableReadTimeout
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r93208334
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
@@ -255,11 +257,12 @@ void disableReadTimeout
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r93206354
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
@@ -255,11 +257,12 @@ void disableReadTimeout
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r93206188
--- Diff: protocol/src/main/protobuf/UserBitShared.proto ---
@@ -320,3 +320,17 @@ message Jar {
repeated string function_signature = 2
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r93206036
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -160,6 +173,14 @@ public int getQueryCount
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r93206853
--- Diff: protocol/src/main/protobuf/UserBitShared.proto ---
@@ -320,3 +320,17 @@ message Jar {
repeated string function_signature = 2
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r93209088
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
@@ -343,10 +346,10 @@ public BitToUserHandshake
GitHub user arina-ielchiieva opened a pull request:
https://github.com/apache/drill/pull/706
DRILL-5039: NPE - CTAS PARTITION BY ()
1. Moved varchar `newPartitionValue` functions to `NewValueFunctions`
template:
a. took advantage of code generation for varchar
GitHub user arina-ielchiieva opened a pull request:
https://github.com/apache/drill/pull/701
DRILL-4963: Sync remote and local function registries before query exâ¦
â¦ecution
Lazy-init was performed only when function was not found during Calcite
parsing but DRILL-4963
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/794#discussion_r108035893
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java
---
@@ -70,27 +70,65 @@
private static final
GitHub user arina-ielchiieva opened a pull request:
https://github.com/apache/drill/pull/794
DRILL-5375: Nested loop join: return correct result for left join
With this fix nested loop join will correctly process INNER and LEFT joins
with non-equality conditions.
You can merge
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/794#discussion_r108421451
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/BatchReference.java ---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/794
Thanks for bringing up this point. I have done some investigation and found
out that implicit casts for nested loop join are already included during
materialization.
Join condition
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/794#discussion_r108640631
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java
---
@@ -70,27 +70,65 @@
private static final
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/794#discussion_r108382080
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/NestedLoopJoinTemplate.java
---
@@ -40,132 +41,133
GitHub user arina-ielchiieva opened a pull request:
https://github.com/apache/drill/pull/804
DRILL-5405: Add missing operator types
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arina-ielchiieva/drill DRILL-5405
Alternatively
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/794#discussion_r109205650
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java
---
@@ -70,27 +70,65 @@
private static final
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/794#discussion_r109205170
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PlannerSettings.java
---
@@ -105,6 +103,29 @@
public static
301 - 400 of 1736 matches
Mail list logo
