Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/367
@nagix Are you still working on this? What is the status?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/367
@nagix I'd be happy to review it, but I'm not a Drill committer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user cgivre opened a pull request:
https://github.com/apache/drill/pull/607
Drill 3423:Add New HTTPD format plugin
This PR adds the capability to Drill to query HTTPD web server logs
natively. In addition to the HTTPD parser, it also includes two UDFs:
parse_url
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/607
@chunhui-shi
I've actually been thinking about writing a generic log parser for Drill in
which the user would provide a regex with groups and a list of fields. For
instance consider
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/708
HI Paul,
Is the mock data source actually in Drill 1.9? I tried executing this
query and it threw errors.
Thx,
âC
> On Dec 27, 2016, at 21:54, Paul Rogers <noti
GitHub user cgivre opened a pull request:
https://github.com/apache/drill/pull/893
DRILL-5703 Add Syntax Highlighting & Autocompletion to Query Form
This PR (https://issues.apache.org/jira/browse/DRILL-5703) adds syntax
highlighting and autocompletion to the query form u
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/897
Hi Arina,
Iâd also like to add syntax highlighting to the storage plugin page as
well. IMHO, itâs really easy to make a small mistake, missing a comma or
quote or something, and it can
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/897
@parthchandra What do you want to fix in the pagination? IMHO, the query
page and the storage plugin editor both are in dire need of syntax
highlighting. I was going to work on that next
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/865#discussion_r127383370
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java
---
@@ -0,0 +1,389 @@
+/*
+ * Licensed to the Apache
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/865#discussion_r127383363
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java
---
@@ -0,0 +1,389 @@
+/*
+ * Licensed to the Apache
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/865#discussion_r127383405
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java
---
@@ -0,0 +1,389 @@
+/*
+ * Licensed to the Apache
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/865#discussion_r127132444
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java
---
@@ -0,0 +1,389 @@
+/*
+ * Licensed to the Apache
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/367
@nagix I just became a committer, and I'd really love to see this
incorporated into the latest version of Drill. Are you willing to keep working
on this to finish it? If not, I may have some time
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/865#discussion_r125486933
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java
---
@@ -0,0 +1,345 @@
+/**
+ * Licensed to the Apache
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/865#discussion_r125487229
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java
---
@@ -0,0 +1,345 @@
+/**
+ * Licensed to the Apache
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/865#discussion_r125487364
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java
---
@@ -0,0 +1,345 @@
+/**
+ * Licensed to the Apache
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/865#discussion_r125489004
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java
---
@@ -0,0 +1,345 @@
+/**
+ * Licensed to the Apache
GitHub user cgivre opened a pull request:
https://github.com/apache/drill/pull/865
DRILL-5634 - Add Crypto and Hash Functions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cgivre/drill master
Alternatively you can review
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/865
Hi Parth,
I need to look at AES, but on the page you sent it specifically said that
all the digests (MD5, SHA) have no restrictions.
âC
> On Jul 5, 2017, at 16:33, Parth Chan
GitHub user cgivre opened a pull request:
https://github.com/apache/drill/pull/897
Drill-5703 Added Syntax Highlighting and Limited Autocomplete on Query Page
This is a clean PR for #893 . This PR replaces the textarea on the query
page with the Ace Code editor. (https://ace.c9.io
Github user cgivre closed the pull request at:
https://github.com/apache/drill/pull/893
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/897
@kkhatua I think the formatter is editable. Truthfully, my main goal is to
implement JSON syntax highlighting on the plugin config pages. I've spent a
decent amount of time debugging JSON because
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/971#discussion_r144722144
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/NetworkFunctions.java
---
@@ -0,0 +1,668 @@
+/**
+ * Licensed to the Apache
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/971#discussion_r144722146
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/NetworkFunctions.java
---
@@ -0,0 +1,668 @@
+/**
+ * Licensed to the Apache
GitHub user cgivre opened a pull request:
https://github.com/apache/drill/pull/971
Drill-5834 Add Networking Functions
This is a collection of Networking Functions to facilitate network
analysis. The functions include:
- **inet_aton(``)**: Converts an IPv4 address
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/971#discussion_r144030560
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/NetworkFunctions.java
---
@@ -0,0 +1,668 @@
+/**
+ * Licensed to the Apache
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/971
Thanks! Iâll resubmit this weekend using commons-validator
> On Oct 11, 2017, at 11:26, Arina Ielchiieva <notificati...@github.com>
wrote:
>
> @arina-ielch
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/971#discussion_r146263421
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/NetworkFunctions.java
---
@@ -0,0 +1,566 @@
+/*
+ * Licensed to the Apache
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/971
I applied the code formatting template from the Drill site in IntelliJ and
resubmitted. Regarding converting an IP to an int, there are tons of examples
of this online and when I implemented it, I
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/1043
I made the requested fixes, and attempted to squash the commits into one,
but failed on that last step. I actually renamed the js director
`ace-code-editor`, which seemed descriptive to me.
---
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/335
HI @k255
Are you still interested in this? I think if we're going to get the GIS
functions into Drill, we really should get this in as well and I'm happy to
help. For whatever reason, I didn't
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/258
I'm getting some unit test failures when I build this.
[org.apache.drill.exec.expr.fn.impl.gis.TestGeometryFunctions.txt](https://github.com/apache/drill/files/1483754
GitHub user cgivre opened a pull request:
https://github.com/apache/drill/pull/1043
DRILL-5981: Add Syntax Highlighting and Error Checking to Storage Plugin
Config
This PR adds syntax highlighting to the storage plugin configuration page
in the Drill web UI, as shown below
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/1018
@paul-rogers @arina-ielchiieva
I'm terrible at git so here is a clean copy of the PR with one commit.
---
GitHub user cgivre opened a pull request:
https://github.com/apache/drill/pull/1018
Drill-5834 Add Networking Functions #971
This is a collection of Networking Functions to facilitate network
analysis. The functions include:
- **inet_aton(``)**: Converts an IPv4 address
Github user cgivre closed the pull request at:
https://github.com/apache/drill/pull/971
---
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/1018
@arina-ielchiieva
I followed the instructions you sent and due to the force commit, it isn't
possible to re-open the original PR.
---
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/258#discussion_r148653960
--- Diff:
contrib/gis/src/test/java/org/apache/drill/exec/expr/fn/impl/gis/TestGeometryFunctions.java
---
@@ -72,4 +72,203 @@ public void testSTWithinQuery
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/258#discussion_r148172786
--- Diff:
contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STUnionAggregate.java
---
@@ -0,0 +1,114 @@
+/**
+ * Licensed
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/258#discussion_r148115797
--- Diff:
contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STBuffer.java
---
@@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/258#discussion_r148172580
--- Diff:
contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STUnionAggregate.java
---
@@ -0,0 +1,114 @@
+/**
+ * Licensed
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/258#discussion_r148117858
--- Diff:
contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STContains.java
---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/258#discussion_r148114646
--- Diff:
contrib/gis/src/main/java/com/esri/core/geometry/VertexGeomAccessor.java ---
@@ -0,0 +1,25 @@
+/**
--- End diff --
Please put
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/1201
LGTM +1
One thing, which I suspect may be a problem with my environment, not this
PR, but when I try to build the module with the tests, I get the following
errors:
```
[ERROR
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/1201
In that case, LGTM +1
Thank you for your work on this!. Are you going to take a look at the ESRI
format plugin?
---
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/1201
@arina-ielchiieva Should I do the commit or would you like to do that.
---
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/1222#discussion_r184882305
--- Diff:
contrib/storage-mongo/src/test/java/org/apache/drill/exec/store/mongo/MongoTestSuit.java
---
@@ -128,42 +130,63 @@ private static void setup
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/258
Hi there,
This will be my first commit, (AH!) so any assistance would be greatly
appreciated. I would like to see some documentation, or at minimum a list of
what functions are included
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/897
Yes, it can be closed. Nice work on the syntax highlighting!
> On Jan 29, 2018, at 16:46, Kunal Khatua <notificati...@github.com> wrote:
>
> @cgivre <https://github.
GitHub user cgivre opened a pull request:
https://github.com/apache/drill/pull/1114
Drill-6104: Added Logfile Reader
I would like to submit a format plugin that will enable Drill to read log
files. Here is a link to the github repo which contains documentation:
https
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/1114#discussion_r168939597
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java
---
@@ -0,0 +1,261 @@
+package
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/1080
Hi Ted,
Thanks for doing this. This looks really great! The PCAP files came from
here: https://github.com/chrissanders/packets. The author said that they are
free to use, but asks
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/1114#discussion_r170675353
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java
---
@@ -0,0 +1,261 @@
+package
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/1114#discussion_r170675202
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogFormatPlugin.java
---
@@ -0,0 +1,151 @@
+package
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/1114#discussion_r170675294
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogFormatPlugin.java
---
@@ -0,0 +1,151 @@
+package
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/1114#discussion_r170675324
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java
---
@@ -0,0 +1,261 @@
+package
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/1114#discussion_r170675258
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogFormatPlugin.java
---
@@ -0,0 +1,151 @@
+package
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/1114#discussion_r170674795
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java
---
@@ -0,0 +1,261 @@
+package
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/1114#discussion_r170674675
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogRecordReader.java
---
@@ -0,0 +1,261 @@
+package
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/1114#discussion_r170690424
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/log/LogFormatPlugin.java
---
@@ -0,0 +1,151 @@
+package
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/258
Hi Brendan, I can review it if you can complete it.
âC
> On Mar 6, 2018, at 10:57, Brendan Stennett <notificati...@github.com>
wrote:
>
> +1 And would be ha
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/1134
Thanks @tdunning for doing this!
---
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/258
I also would really like to see this through to completion. If there is
something I can do, please let me know.
> On Mar 6, 2018, at 08:04, lherrmann974 <notificati...@github.com&
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/1201#discussion_r180411032
--- Diff:
contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STCrosses.java
---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/1201#discussion_r180411754
--- Diff:
contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STDifference.java
---
@@ -0,0 +1,66 @@
+/**
+ * Licensed to the Apache
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/1201#discussion_r180410015
--- Diff:
contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STBuffer.java
---
@@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/1201#discussion_r180412106
--- Diff:
contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STDisjoint.java
---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/1201
If you want to include it on this PR that would be great, but Iâm fine
with including it in a separate PR as well. I want to get this functionality
into Drill asap, so it probably would be quicker
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/1201
@ChrisSandison This isn't a review comment, but @k255 was working on a
format plugin for ESRI shape files. Would you want to take a look and see if
we could get that in as well? I could see
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/1201
@ChrisSandison Done. Here's a link to the JIRA
https://issues.apache.org/jira/browse/DRILL-6319
---
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/258
HI @brendanstennett I still am able to review if you'd like.
---
Github user cgivre closed the pull request at:
https://github.com/apache/drill/pull/897
---
72 matches
Mail list logo
