[GitHub] drill issue #905: DRILL-1162: Fix OOM for hash join operator when the right ...

2017-08-15 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/905 @paul-rogers @jinfengni can you please review this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] drill issue #895: DRILL-5704: Improve error message on client side when quer...

2017-08-04 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/895 @parthchandra can you please review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] drill issue #981: DRILL-5854: IllegalStateException when empty batch with va...

2017-10-10 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/981 @paul-rogers could you please review this one? ---

[GitHub] drill issue #990: DRILL-5872: Workaround for invalid cost in physical plans

2017-10-13 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/990 @amansinha100 or @arina-ielchiieva can you please review this? ---

[GitHub] drill pull request #994: Merge from latest

2017-10-13 Thread priteshm
GitHub user priteshm opened a pull request: https://github.com/apache/drill/pull/994 Merge from latest You can merge this pull request into a Git repository by running: $ git pull https://github.com/priteshm/drill master Alternatively you can review and apply these changes

[GitHub] drill pull request #994: Merge from latest

2017-10-13 Thread priteshm
Github user priteshm closed the pull request at: https://github.com/apache/drill/pull/994 ---

[GitHub] drill issue #949: DRILL-5795: Parquet Filter push down at rowgroup level

2017-10-16 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/949 @paul-rogers, @kkhatua can you provide some more information on the test case that failed? Hopefully, @dprofeta can replicate it in his environment. ---

[GitHub] drill issue #967: DRILL-5564: Added finally block for stopWait() to avoid al...

2017-09-29 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/967 @parthchandra can you review this? ---

[GitHub] drill issue #961: DRILL-5792: CONVERT_FROM_JSON on an empty file throws runt...

2017-09-29 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/961 @paul-rogers please review. ---

[GitHub] drill issue #930: DRILL-5761: Disable Lilith ClassicMultiplexSocketAppender ...

2017-09-01 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/930 @vvysotskyi is it possible to change the port number for Lilith to avoid the conflict? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] drill issue #920: DRILL-5737: Hash Agg uses more than the allocated memory u...

2017-08-31 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/920 @Ben-Zvi can you please review for it to be included in the current sprint? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] drill issue #976: DRILL-5797: Choose parquet reader from read columns

2017-11-14 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/976 @dprofeta will you be able to address the issues before the release? ---

[GitHub] drill issue #1028: DRILL-5943: Avoid the strong check introduced by DRILL-55...

2017-11-14 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1028 @parthchandra can you please review this? ---

[GitHub] drill issue #1047: DRILL-5970: DrillParquetReader always builds the schema w...

2017-11-27 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1047 @sachouche can you please review this? ---

[GitHub] drill issue #1071: DRILL-6028: Allow splitting generated code in ChainedHash...

2017-12-13 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1071 @paul-rogers can you please review this? ---

[GitHub] drill issue #1038: DRILL-5972: Slow performance for query on INFORMATION_SCH...

2017-11-16 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1038 @parthchandra can you please review this? ---

[GitHub] drill issue #1041: DRILL-5961: For long running queries (> 10 min) Drill may...

2017-11-16 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1041 @parthchandra or @adityakishore since you'll have made changes to these files before, can you review the changes here? ---

[GitHub] drill issue #1040: Drill 5425

2017-11-16 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1040 @arina-ielchiieva can you please review this? ---

[GitHub] drill issue #1001: JIRA DRILL-5879: Like operator performance improvements

2017-11-16 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1001 @ppadma @paul-rogers I see that @sachouche addressed the comments in the JIRA - is this one ready to merge? ---

[GitHub] drill issue #1014: DRILL-5771: Fix serDe errors for format plugins

2017-11-09 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1014 @ilooner can you please review this? ---

[GitHub] drill issue #1030: DRILL-5941: Skip header / footer improvements for Hive st...

2017-11-09 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1030 @ppadma can you review this? ---

[GitHub] drill issue #1025: DRILL-5936: Refactor MergingRecordBatch based on code rev...

2017-11-09 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1025 @amansinha100 can you review this change? ---

[GitHub] drill issue #976: DRILL-5797: Choose parquet reader from read columns

2017-10-29 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/976 @sachouche can you please take a final look? If it looks good, maybe one of the committers can include this for the 1.12 release. @arina-ielchiieva ? ---

[GitHub] drill issue #978: DRILL-5842: Refactor and simplify the fragment, operator c...

2017-10-27 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/978 @sohami can you please review this? ---

[GitHub] drill issue #1001: JIRA DRILL-5879: Like operator performance improvements

2018-01-09 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1001 @sachouche can you update this PR? ---

[GitHub] drill issue #1086: DRILL-6076: Reduce the default memory from a total of 13G...

2018-01-10 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1086 @paul-rogers, @parthchandra can you review/ comment on this change? ---

[GitHub] drill issue #1045: DRILL-5730 Test Mocking Improvements

2018-01-25 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1045 @arina-ielchiieva - any chance this can be committed with the batch commits tomorrow? otherwise, @ilooner would need to rebase again! ---

[GitHub] drill issue #1106: DRILL-6129: Fixed query failure due to nested column data...

2018-01-31 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1106 @amansinha100 can you please review it? ---

[GitHub] drill issue #1111: Upgrade drill-hive libraries to 2.1.1 version.

2018-02-05 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/ @vrozov can you please review this change? ---

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

2018-02-05 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1011 @sachouche @vrozov @arina-ielchiieva please review ---

[GitHub] drill issue #1119: DRILL-6143: Made FragmentsRunner's rpc timeout a SystemOp...

2018-02-09 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1119 @arina-ielchiieva is on vacation. @vrozov, @Ben-Zvi can you take a look? ---

[GitHub] drill issue #1101: DRILL-6032: Made the batch sizing for HashAgg more accura...

2018-02-22 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1101 @Ben-Zvi can you please do a final review? ---

[GitHub] drill issue #1105: DRILL-6125: Fix possible memory leak when query is cancel...

2018-02-22 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1105 @arina-ielchiieva is this bug ready to commit? ---

[GitHub] drill issue #1072: DRILL-5879: Improved SQL Pattern Contains Performance

2018-01-18 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1072 @paul-rogers Is this ready for commit? ---

[GitHub] drill pull request #1135: DRILL-6040: Added usage for graceful_stop in drill...

2018-03-06 Thread priteshm
Github user priteshm commented on a diff in the pull request: https://github.com/apache/drill/pull/1135#discussion_r172619940 --- Diff: distribution/src/resources/drillbit.sh --- @@ -45,7 +45,7 @@ # configuration file. The option takes precedence over the # DRILL_CONF_DIR

[GitHub] drill issue #1101: DRILL-6032: Made the batch sizing for HashAgg more accura...

2018-02-28 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1101 Spoke with Chun, he will run the tests and update the PR with the test results. ---

[GitHub] drill issue #1096: DRILL-6099 : Push limit past flatten(project) without pus...

2018-02-27 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1096 @gparai did you get a chance to address @amansinha100 's comment for this PR? ---

[GitHub] drill issue #1133: DRILL-6190 - Fix handling of packets longer than legally ...

2018-02-27 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1133 @parthchandra or @arina-ielchiieva can you review this? ---

[GitHub] drill issue #1166: DRILL-6016 - Fix for Error reading INT96 created by Apach...

2018-03-14 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1166 @parthchandra would you please review this? ---

[GitHub] drill issue #1158: DRILL-6145: Implement Hive MapR-DB JSON handler

2018-03-15 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1158 @vdiravka please do link the JIRA that you will create. @vrozov can you take a final look? ---

[GitHub] drill issue #1152: DRILL-6199: Add support for filter push down and partitio...

2018-03-08 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1152 @chunhui-shi or @HanumathRao can you please review this? ---

[GitHub] drill issue #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] classes t...

2018-04-05 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1184 @parthchandra can you please review it. @jiang-wu Parth is traveling and he would be able to review it next week. ---

[GitHub] drill issue #1204: DRILL-6318

2018-04-10 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1204 @ppadma can you review this? ---

[GitHub] drill issue #1204: DRILL-6318

2018-04-10 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1204 @arina-ielchiieva or @vdiravka can you review this? ---

[GitHub] drill issue #1207: DRILL-6320: Fixed License Headers

2018-04-11 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1207 There is a large number of files affected - it might be good to get this in early so that we don't have to keep rebasing. @vrozov/ @Ben-Zvi can you glance through the changes? @Ben-Zvi

[GitHub] drill issue #1199: DRILL-6303: Provide a button to copy the Drillbit's JStac...

2018-04-04 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1199 Nice work, @kkhatua! This seems very useful! ---

[GitHub] drill issue #1207: DRILL-6320: Fixed License Headers

2018-04-16 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1207 @arina-ielchiieva or @Ben-Zvi would it make sense to merge this in earlier before the batch commits later in the week? the number of files changes are large so don't want @ilooner to have to rebase

[GitHub] drill issue #1173: DRILL-6259: Support parquet filter push down for complex ...

2018-03-16 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1173 @parthchandra can you please review this change? ---

[GitHub] drill issue #1179: DRILL-6254: IllegalArgumentException: the requested size ...

2018-03-21 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1179 @bitblender can you please review this? ---

[GitHub] drill issue #1152: DRILL-6199: Add support for filter push down and partitio...

2018-03-19 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1152 Thanks, @chunhui-shi - marked it as ready-to-commit since the original feature was already merged to 1.13. The batch committer this week can take another look as well. ---

[GitHub] drill issue #1152: DRILL-6199: Add support for filter push down and partitio...

2018-03-19 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1152 @HanumathRao, @chunhui-shi any more comments from you? ---

[GitHub] drill pull request #1135: DRILL-6040: Added usage for graceful_stop in drill...

2018-03-01 Thread priteshm
Github user priteshm commented on a diff in the pull request: https://github.com/apache/drill/pull/1135#discussion_r171731905 --- Diff: distribution/src/resources/drillbit.sh --- @@ -45,7 +45,7 @@ # configuration file. The option takes precedence over the # DRILL_CONF_DIR