[GitHub] drill issue #1060: DRILL-5846: Improve parquet performance for Flat Data Typ...

2018-04-17 Thread sachouche
Github user sachouche commented on the issue: https://github.com/apache/drill/pull/1060 @parthchandra , @vrozov I have done the following modifications: - Renamed newly added files with the prefix "VL" with "VarLen" as suggested by @parthchandra

[GitHub] drill pull request #1237: DRILL-6348: Fixed code so that Unordered Receiver ...

2018-04-25 Thread sachouche
Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/1237#discussion_r184114148 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java --- @@ -153,8 +153,10 @@ private

[GitHub] drill pull request #1237: DRILL-6348: Fixed code so that Unordered Receiver ...

2018-04-25 Thread sachouche
Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/1237#discussion_r184117938 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java --- @@ -182,13 +184,18 @@ public

[GitHub] drill pull request #1237: DRILL-6348: Fixed code so that Unordered Receiver ...

2018-04-25 Thread sachouche
Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/1237#discussion_r184138876 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RawFragmentBatch.java --- @@ -77,4 +83,46 @@ public long getByteCount

[GitHub] drill pull request #1237: DRILL-6348: Fixed code so that Unordered Receiver ...

2018-04-25 Thread sachouche
Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/1237#discussion_r184112400 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java --- @@ -153,8 +153,10 @@ private

[GitHub] drill pull request #1237: DRILL-6348: Fixed code so that Unordered Receiver ...

2018-04-25 Thread sachouche
Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/1237#discussion_r184140733 --- Diff: exec/memory/base/src/main/java/org/apache/drill/exec/memory/AllocationManager.java --- @@ -253,10 +261,12 @@ public boolean transferBalance

[GitHub] drill issue #1060: DRILL-5846: Improve parquet performance for Flat Data Typ...

2018-03-30 Thread sachouche
Github user sachouche commented on the issue: https://github.com/apache/drill/pull/1060 Parth, - I have attached, within the DRILL-5846, two profiles with latest Apache code and this PR request (bounds checks are off): o Used one thread in each run o I observe ~3x

[GitHub] drill pull request #1192: DRILL-6299: Fixed a filter pushed down issue when ...

2018-03-28 Thread sachouche
GitHub user sachouche opened a pull request: https://github.com/apache/drill/pull/1192 DRILL-6299: Fixed a filter pushed down issue when a column doesn't ha… This bug happens when the isNull predicate is applied on a column without statistics. @arina-ielchiieva can you please

[GitHub] drill issue #1060: DRILL-5846: Improve parquet performance for Flat Data Typ...

2018-03-29 Thread sachouche
Github user sachouche commented on the issue: https://github.com/apache/drill/pull/1060 I have updated this pull request with the following changes: - Excluded the implicit column optimizations from this pull request (will be included as part of another Drill Jira) - Tuned

[GitHub] drill issue #1168: DRILL-6246: Reduced the size of the jdbc-all jar file

2018-03-29 Thread sachouche
Github user sachouche commented on the issue: https://github.com/apache/drill/pull/1168 I successfully ran the test-suite and some advanced tests which loaded the jdbc artifacts. Is this enough to validate the fix (and future exclusions to keep the jar size in-check)? if not, what

[GitHub] drill issue #1060: DRILL-5846: Improve parquet performance for Flat Data Typ...

2018-03-29 Thread sachouche
Github user sachouche commented on the issue: https://github.com/apache/drill/pull/1060 @parthchandra and @vrozov can you please let me know whether you are ok with the changes. Thanks! ---

[GitHub] drill issue #1170: DRILL-6223: Fixed several Drillbit failures due to schema...

2018-03-29 Thread sachouche
Github user sachouche commented on the issue: https://github.com/apache/drill/pull/1170 @parthchandra and @paul-rogers, I have added a comment within the Jira [DRILL-6223](https://issues.apache.org/jira/browse/DRILL-6223); please let me know what you think. Thanks! ---

[GitHub] drill issue #1144: DRILL-6202: Deprecate usage of IndexOutOfBoundsException ...

2018-04-03 Thread sachouche
Github user sachouche commented on the issue: https://github.com/apache/drill/pull/1144 I have added a comment within this PR associated JIRA: [DRILL-6202](https://issues.apache.org/jira/browse/DRILL-6202) ---

[GitHub] drill issue #1170: DRILL-6223: Fixed several Drillbit failures due to schema...

2018-03-17 Thread sachouche
Github user sachouche commented on the issue: https://github.com/apache/drill/pull/1170 @parthchandra can you also please review this PR? Thanks! ---

[GitHub] drill pull request #1237: DRILL-6348: Fixed code so that Unordered Receiver ...

2018-04-25 Thread sachouche
Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/1237#discussion_r184197278 --- Diff: exec/memory/base/src/main/java/org/apache/drill/exec/memory/AllocationManager.java --- @@ -253,10 +261,12 @@ public boolean transferBalance

[GitHub] drill pull request #1237: DRILL-6348: Fixed code so that Unordered Receiver ...

2018-04-25 Thread sachouche
Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/1237#discussion_r184197379 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java --- @@ -153,8 +153,10 @@ private

[GitHub] drill pull request #1237: DRILL-6348: Fixed code so that Unordered Receiver ...

2018-04-25 Thread sachouche
Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/1237#discussion_r184151186 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java --- @@ -182,13 +184,18 @@ public

[GitHub] drill pull request #1237: DRILL-6348: Fixed code so that Unordered Receiver ...

2018-04-25 Thread sachouche
Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/1237#discussion_r184192630 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RawFragmentBatch.java --- @@ -77,4 +83,46 @@ public long getByteCount

[GitHub] drill issue #1237: DRILL-6348: Fixed code so that Unordered Receiver reports...

2018-04-25 Thread sachouche
Github user sachouche commented on the issue: https://github.com/apache/drill/pull/1237 @vrozov, I have implemented the provided suggestions. ---

<    1   2