Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/793#discussion_r107647154
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/cost/DrillRelMdRowCount.java
---
@@ -14,35 +14,71 @@
* WITHOUT WARRANTIES
GitHub user Serhii-Harnyk opened a pull request:
https://github.com/apache/drill/pull/793
DRILL-4678: Tune metadata by generating a dispatcher at runtime
Changes for rebasing to Calcite 1.4.0-drill-r20
You can merge this pull request into a Git repository by running:
$ git
Github user Serhii-Harnyk commented on the issue:
https://github.com/apache/drill/pull/748
Merged into apace master without message _close apache/drill#748_. Closing
PR manually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user Serhii-Harnyk closed the pull request at:
https://github.com/apache/drill/pull/748
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/748#discussion_r101308389
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/NestedLoopJoinPrule.java
---
@@ -49,7 +49,7 @@ protected boolean
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/748#discussion_r101086894
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/NestedLoopJoinPrule.java
---
@@ -49,7 +49,7 @@ protected boolean
Github user Serhii-Harnyk commented on the issue:
https://github.com/apache/drill/pull/594
@amansinha100, could you please review new changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/594#discussion_r101024133
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
@@ -492,10 +537,18 @@ private void writeDataAllText
GitHub user Serhii-Harnyk opened a pull request:
https://github.com/apache/drill/pull/748
DRILL-5263: Prevent left NLJoin with non scalar subqueries
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Serhii-Harnyk/drill DRILL-5263
Serhii Harnyk created DRILL-5263:
Summary: Prevent left NLJoin with non scalar subqueries
Key: DRILL-5263
URL: https://issues.apache.org/jira/browse/DRILL-5263
Project: Apache Drill
Issue
Github user Serhii-Harnyk commented on the issue:
https://github.com/apache/drill/pull/594
Squashed all changes into single commit, rebased on master and resolved
conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user Serhii-Harnyk commented on the issue:
https://github.com/apache/drill/pull/581
@paul-rogers could you please review new changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r99315319
--- Diff:
logical/src/main/java/org/apache/drill/common/expression/fn/JodaDateValidator.java
---
@@ -0,0 +1,216 @@
+/*
+* Licensed
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r99313550
--- Diff:
logical/src/main/java/org/apache/drill/common/expression/fn/JodaDateValidator.java
---
@@ -0,0 +1,216 @@
+/*
+* Licensed
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r99315665
--- Diff:
logical/src/main/java/org/apache/drill/common/expression/fn/JodaDateValidator.java
---
@@ -0,0 +1,216 @@
+/*
+* Licensed
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r99316546
--- Diff:
logical/src/main/java/org/apache/drill/common/expression/fn/JodaDateValidator.java
---
@@ -0,0 +1,216 @@
+/*
+* Licensed
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r99317199
--- Diff:
logical/src/test/java/org/apache/drill/common/expression/fn/JodaDateValidatorTest.java
---
@@ -0,0 +1,176 @@
+/*
+* Licensed
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r99312234
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/testing/TestDateConversions.java
---
@@ -0,0 +1,200 @@
+/*
+* Licensed
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r99312091
--- Diff:
exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/SqlToDateTypeFunctions.java
---
@@ -0,0 +1,77
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r99311783
--- Diff:
exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/SqlToDateTypeFunctions.java
---
@@ -0,0 +1,77
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r99311060
--- Diff:
exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/SqlToDateTypeFunctions.java
---
@@ -0,0 +1,77
GitHub user Serhii-Harnyk opened a pull request:
https://github.com/apache/drill/pull/735
DRILL-5237: Same query produces different/wrong results
Fixed loss of nested fields from the schema when the first
FlattenRecordBatch is empty
You can merge this pull request into a Git
Serhii Harnyk created DRILL-5237:
Summary: Same query produces different/wrong results
Key: DRILL-5237
URL: https://issues.apache.org/jira/browse/DRILL-5237
Project: Apache Drill
Issue Type
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/580#discussion_r98232198
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/complex/MapVector.java
---
@@ -317,6 +317,12 @@ public Object getObject(int index
Github user Serhii-Harnyk commented on the issue:
https://github.com/apache/drill/pull/673
Squashed all changes into single commit and rebased on master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user Serhii-Harnyk commented on the issue:
https://github.com/apache/drill/pull/713
@amansinha100, could you please review new changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/713#discussion_r97576603
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
@@ -59,6 +59,12 @@
private final boolean
GitHub user Serhii-Harnyk opened a pull request:
https://github.com/apache/drill/pull/713
DRILL-3562: Query fails when using flatten on JSON data where some doâ¦
â¦cuments have an empty array
1. Added set for ListWriters tracking to keep empty arrays for further
initializing
GitHub user Serhii-Harnyk opened a pull request:
https://github.com/apache/drill/pull/711
DRILL-5164: Equi-join query results in CompileException
1. Added method call rotateBlock() to avoid adding expressions into single
Jblock.
2. Added unit tests to cover three types of joins
[
https://issues.apache.org/jira/browse/DRILL-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Serhii Harnyk resolved DRILL-1808.
--
Resolution: Duplicate
Fix Version/s: (was: Future)
1.10.0
Fixed
Github user Serhii-Harnyk commented on the issue:
https://github.com/apache/drill/pull/594
@chunhui-shi, I have made some changes, could you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user Serhii-Harnyk commented on the issue:
https://github.com/apache/drill/pull/654
@jinfengni, I have made some changes. Could you please review it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/654#discussion_r92801855
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveTableWrapper.java
---
@@ -0,0 +1,483
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/654#discussion_r92801426
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveTableWrapper.java
---
@@ -0,0 +1,483
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/654#discussion_r92800877
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveTableWrapper.java
---
@@ -0,0 +1,483
Github user Serhii-Harnyk commented on the issue:
https://github.com/apache/drill/pull/581
@paul-rogers, I have implemented changes that you have proposed. Could you
take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/594#discussion_r92478836
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
@@ -510,10 +517,13 @@ private void writeDataAllText
Github user Serhii-Harnyk commented on the issue:
https://github.com/apache/drill/pull/686
@sudheeshkatkam, when running for example test testEXTERNAL_SORT(),
generates class CopierGen4, in which methods doSetup() and doEval() does not
splits correctly. But with this fix them both
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/686#discussion_r92452238
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/compile/TestLargeFileCompilation.java
---
@@ -154,4 +158,20 @@ public void testProject
Github user Serhii-Harnyk commented on the issue:
https://github.com/apache/drill/pull/686
@jinfengni, could you please review new changes? I squashed all changes
into single commit and rebased into master.
---
If your project is set up for it, you can reply to this email and have
Github user Serhii-Harnyk commented on the issue:
https://github.com/apache/drill/pull/689
@zfong, I have added the unit test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/673#discussion_r91753304
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetFixedWidthDictionaryReaders.java
---
@@ -56,6 +58,31
Github user Serhii-Harnyk commented on the issue:
https://github.com/apache/drill/pull/594
@chunhui-shi, could you please review new changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user Serhii-Harnyk opened a pull request:
https://github.com/apache/drill/pull/686
DRILL-5117: Compile error when query a json file with 1000+columns
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Serhii-Harnyk/drill
Serhii Harnyk created DRILL-5117:
Summary: Compile error when query a json file with 1000+columns
Key: DRILL-5117
URL: https://issues.apache.org/jira/browse/DRILL-5117
Project: Apache Drill
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/654#discussion_r91351247
--- Diff:
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/schema/TestColumnListCache.java
---
@@ -0,0 +1,78
Github user Serhii-Harnyk commented on the issue:
https://github.com/apache/drill/pull/673
@parthchandra, could you please review new changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user Serhii-Harnyk commented on the issue:
https://github.com/apache/drill/pull/654
@chunhui-shi, I have made some changes. Could you please review it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user Serhii-Harnyk commented on the issue:
https://github.com/apache/drill/pull/673
@parthchandra, I have made some changes and added few test values. Could
you please review it?
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user Serhii-Harnyk opened a pull request:
https://github.com/apache/drill/pull/673
DRILL-4764: Parquet file with INT_16, etc. logical types not supporteâ¦
â¦d by simple SELECT
You can merge this pull request into a Git repository by running:
$ git pull https
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/654#discussion_r89520154
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java
---
@@ -398,12 +398,18 @@ public static void
GitHub user Serhii-Harnyk opened a pull request:
https://github.com/apache/drill/pull/657
DRILL-5048: AssertionError when case statement is used with timestampâ¦
⦠and null
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Serhii Harnyk created DRILL-5048:
Summary: AssertionError when case statement is used with timestamp
and null
Key: DRILL-5048
URL: https://issues.apache.org/jira/browse/DRILL-5048
Project: Apache
GitHub user Serhii-Harnyk opened a pull request:
https://github.com/apache/drill/pull/654
DRILL-5032: Drill query on hive parquet table failed with OutOfMemoryError
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Serhii-Harnyk
Serhii Harnyk created DRILL-5032:
Summary: Drill query on hive parquet table failed with
OutOfMemoryError: Java heap space
Key: DRILL-5032
URL: https://issues.apache.org/jira/browse/DRILL-5032
Github user Serhii-Harnyk commented on the issue:
https://github.com/apache/drill/pull/594
@chunhui-shi
Results of performance test
| % of nullable records | with fix | master | %(t-t0)/t0 |
| 0.001 | 13986,8 | 13752,1 | 1,71% |
| 0.1 | 13873,6
Github user Serhii-Harnyk commented on the issue:
https://github.com/apache/drill/pull/594
@chunhui-shi what about second commit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ou please give me a working example of the usage with "s" for second
> of minute and "S" for fraction of second.
>
> I tried with both those symbols, however Drill 1.9.0 (commit: a29f1e29)
> does not honor those symbols when used from within the to_date function.
>
>
Hello, Khurram
http://joda-time.sourceforge.net/apidocs/org/joda/time/format/DateTimeFormat.html
s second of minute number55
S fraction of second number978
2016-10-27 13:54 GMT+03:00 Khurram Faraaz :
> All,
>
> I am on
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/594#discussion_r84509937
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
@@ -337,6 +364,7 @@ private void writeData(MapWriter
Github user Serhii-Harnyk commented on the issue:
https://github.com/apache/drill/pull/594
Added fixes according to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/594#discussion_r84509944
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
@@ -418,6 +447,7 @@ private void writeDataAllText
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/594#discussion_r84507055
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
@@ -56,6 +58,12 @@
private final boolean
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/594#discussion_r84507516
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
@@ -131,14 +139,33 @@ public void
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/594#discussion_r84508112
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
@@ -131,14 +139,33 @@ public void
Github user Serhii-Harnyk commented on the issue:
https://github.com/apache/drill/pull/581
@adeneche - miliseconds issue is fixed in last commit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r83871818
--- Diff:
logical/src/main/java/org/apache/drill/common/expression/fn/JodaDateValidator.java
---
@@ -0,0 +1,213 @@
+/*
+* Licensed
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r83871606
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java
---
@@ -408,6 +411,12 @@ private LogicalExpression
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r83871870
--- Diff:
logical/src/main/java/org/apache/drill/common/expression/fn/JodaDateValidator.java
---
@@ -0,0 +1,213 @@
+/*
+* Licensed
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r83871748
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java
---
@@ -408,6 +411,12 @@ private LogicalExpression
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r83871584
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java
---
@@ -408,6 +411,12 @@ private LogicalExpression
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r83870798
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/AnsiToJoda.java
---
@@ -0,0 +1,58 @@
+/*
+* Licensed to the Apache
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r83871296
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/AnsiToJoda.java
---
@@ -0,0 +1,58 @@
+/*
+* Licensed to the Apache
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/598#discussion_r81115837
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/planner/logical/TestCaseNullableTypes.java
---
@@ -0,0 +1,107 @@
+/*
+* Licensed
GitHub user Serhii-Harnyk opened a pull request:
https://github.com/apache/drill/pull/598
DRILL-4906 CASE Expression with constant generates class exception
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Serhii-Harnyk/drill
Serhii Harnyk created DRILL-4906:
Summary: CASE Expression with constant generates class exception
Key: DRILL-4906
URL: https://issues.apache.org/jira/browse/DRILL-4906
Project: Apache Drill
GitHub user Serhii-Harnyk opened a pull request:
https://github.com/apache/drill/pull/594
DRILL-4842: SELECT * on JSON data results in NumberFormatException
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Serhii-Harnyk/drill
GitHub user Serhii-Harnyk opened a pull request:
https://github.com/apache/drill/pull/581
DRILL-4864: Add ANSI format for date/time functions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Serhii-Harnyk/drill DRILL-4864
78 matches
Mail list logo