Github user julianhyde commented on the issue:
https://github.com/apache/drill/pull/1012
If I recall correctly -- we went through this because Calcite uses ESRI --
the only change was to remove org.json. It's a pretty important change because
org.json is not compatible with Apache
Github user julianhyde commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145561518
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -584,11 +492,14 @@ public static void defineWorkspace(Drillbit
Github user julianhyde commented on the issue:
https://github.com/apache/drill/pull/685
To be consistent with other the other context functions in standard SQL
({{CURRENT_USER}}, {{SESSION_USER}}, {{CURRENT_PATH}}, {{CURRENT_ROLE}},
{{LOCALTIMESTAMP}}) this should be invoked without
Github user julianhyde commented on the issue:
https://github.com/apache/drill/pull/671
Rebasing onto Calcite is like running after a train: you can't just stop
and take a rest. :)
And by the way, the state of Drill-Arrow integration makes me very sad. Now
Drill has fallen
Github user julianhyde commented on the issue:
https://github.com/apache/drill/pull/671
Yes, CachingRelMetadataProvider is meant for this.
After https://issues.apache.org/jira/browse/CALCITE-604, providers are
considerably more efficient (not called via reflection
Github user julianhyde commented on a diff in the pull request:
https://github.com/apache/drill/pull/549#discussion_r72143283
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/DrillCompoundIdentifier.java
---
@@ -69,31 +70,38 @@ public void addIndex
Github user julianhyde commented on a diff in the pull request:
https://github.com/apache/drill/pull/549#discussion_r71924583
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/DrillCompoundIdentifier.java
---
@@ -69,31 +70,38 @@ public void addIndex
Github user julianhyde commented on the issue:
https://github.com/apache/drill/pull/541
The method in the parser and the class should both be called `DropTable`.
`ifExists` should just be a boolean field.
At some point you might want to add an `OR REPLACE` clause to `CREATE
Github user julianhyde commented on the issue:
https://github.com/apache/drill/pull/541
Why rename DropTable to DropTableIfExists? It's still the DROP TABLE
command.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user julianhyde commented on the pull request:
https://github.com/apache/drill/pull/436#issuecomment-200448075
Yes, I think this would be good in Calcite. Thanks for offering.
DESCRIBE is in the SQL standard (the latest draft, anyway; I didn't check
any others
Github user julianhyde commented on a diff in the pull request:
https://github.com/apache/drill/pull/193#discussion_r45012029
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillDirectScanRel.java
---
@@ -0,0 +1,111 @@
+/**
+ * Licensed
Github user julianhyde commented on a diff in the pull request:
https://github.com/apache/drill/pull/193#discussion_r43316183
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/FindLimit0Visitor.java
---
@@ -46,6 +51,32 @@ public static boolean
Github user julianhyde commented on a diff in the pull request:
https://github.com/apache/drill/pull/169#discussion_r40447157
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/LimitUnionExchangeTransposeRule.java
---
@@ -0,0 +1,64
Github user julianhyde commented on a diff in the pull request:
https://github.com/apache/drill/pull/169#discussion_r40446899
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillLimitRelBase.java
---
@@ -36,11 +36,17 @@
public abstract class
Github user julianhyde commented on the pull request:
https://github.com/apache/drill/pull/159#issuecomment-143310179
Yes, open a JIRA.
We don't need NonReservedKeyWord() and CommonNonReservedKeyWord() to be
separate anymore, so you can generate code into whichever one
Github user julianhyde commented on a diff in the pull request:
https://github.com/apache/drill/pull/169#discussion_r40465777
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/LimitUnionExchangeTransposeRule.java
---
@@ -0,0 +1,64
16 matches
Mail list logo
