Github user rajrahul commented on the issue:
https://github.com/apache/drill/pull/1166
@vdiravka removed the extra line.
---
Github user rajrahul commented on a diff in the pull request:
https://github.com/apache/drill/pull/1166#discussion_r178324303
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -61,6 +60,7 @@
import
Github user rajrahul commented on a diff in the pull request:
https://github.com/apache/drill/pull/1166#discussion_r178290675
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -780,17 +780,31 @@ public void
Github user rajrahul commented on the issue:
https://github.com/apache/drill/pull/1166
@vdiravka Done. Please review.
---
Github user rajrahul commented on the issue:
https://github.com/apache/drill/pull/1166
@vdiravka I have made similar changes for
testSparkParquetBinaryAsTimeStamp_DictChange,
testHiveParquetTimestampAsInt96_basic and
testImpalaParquetBinaryAsTimeStamp_DictChange. All tests
Github user rajrahul commented on a diff in the pull request:
https://github.com/apache/drill/pull/1166#discussion_r177950795
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -797,6 +797,24 @@ public void
Github user rajrahul commented on a diff in the pull request:
https://github.com/apache/drill/pull/1166#discussion_r177318780
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -797,6 +797,24 @@ public void
Github user rajrahul commented on the issue:
https://github.com/apache/drill/pull/1166
The schema given below creates the issue, as @vdiravka pointed int96 is
marked required here. This parquet was generated with an older version of spark
and is included in the test case
Github user rajrahul commented on the issue:
https://github.com/apache/drill/pull/1166
@parthchandra @vdiravka I have added the test case using the same parquet
file(2.9k bytes). I tried creating a smaller file using Spark, but could not
replicate the behavior. I have rebased
Github user rajrahul commented on the issue:
https://github.com/apache/drill/pull/1166
@parthchandra I will create a unit test with few time stamp fields.
---
Github user rajrahul commented on the issue:
https://github.com/apache/drill/pull/1166
@parthchandra please use the link
https://github.com/rajrahul/files/raw/master/result.tar.gz
The files are present inside result/parquet/latest.
---
Github user rajrahul commented on the issue:
https://github.com/apache/drill/pull/1166
@parthchandra @vdiravka I do not have a test case for this. I have
manually verified the scenario with and without the patch. The sample input
file is attached with https://issues.apache.org/jira
GitHub user rajrahul opened a pull request:
https://github.com/apache/drill/pull/1166
DRILL-6016 - Fix for Error reading INT96 created by Apache Spark
This fixes DRILL-6016 where drill was failing to read int96 generated by
Apache Spark even after setting
GitHub user rajrahul opened a pull request:
https://github.com/apache/drill/pull/1067
DRILL-3958: Return a valid error message when storage plugin fails
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rajrahul/drill DRILL-3958
14 matches
Mail list logo
