[GitHub] Agirish commented on a change in pull request #1430: DRILL-6680: Expose show files command into INFORMATION_SCHEMA

2018-08-11 Thread GitBox 
Agirish commented on a change in pull request #1430: DRILL-6680: Expose show 
files command into INFORMATION_SCHEMA
URL: https://github.com/apache/drill/pull/1430#discussion_r209430632
 
 

 ##
 File path: exec/java-exec/src/main/resources/drill-module.conf
 ##
 @@ -605,4 +605,5 @@ drill.exec.options: {
 store.kafka.poll.timeout: 200,
 web.logs.max_lines: 1,
 window.enable: true,
+storage.list_files_recursively: true
 
 Review comment:
   ah...Is this setting only applicable when querying the 
INFORMATION_SCHEMA.`FILES` table? And SHOW FILES command will continue to work 
as it does today? If so, sorry - please ignore my previous comment. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Agirish commented on a change in pull request #1430: DRILL-6680: Expose show files command into INFORMATION_SCHEMA

2018-08-11 Thread GitBox 
Agirish commented on a change in pull request #1430: DRILL-6680: Expose show 
files command into INFORMATION_SCHEMA
URL: https://github.com/apache/drill/pull/1430#discussion_r209430462
 
 

 ##
 File path: exec/java-exec/src/main/resources/drill-module.conf
 ##
 @@ -605,4 +605,5 @@ drill.exec.options: {
 store.kafka.poll.timeout: 200,
 web.logs.max_lines: 1,
 window.enable: true,
+storage.list_files_recursively: true
 
 Review comment:
   I would suggest we keep the default false for backward compatibility - if 
not, show files command output may explode for very high level directories, and 
may be less helpful for exploratory purposes. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services