[GitHub] drill issue #638: DRILL-4982: Separate Hive reader classes for different dat...

2016-12-02 Thread parthchandra
Github user parthchandra commented on the issue:

https://github.com/apache/drill/pull/638
  
LGTM too. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill issue #638: DRILL-4982: Separate Hive reader classes for different dat...

2016-12-02 Thread chunhui-shi
Github user chunhui-shi commented on the issue:

https://github.com/apache/drill/pull/638
  
Addressed your comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill issue #638: DRILL-4982: Separate Hive reader classes for different dat...

2016-11-04 Thread chunhui-shi
Github user chunhui-shi commented on the issue:

https://github.com/apache/drill/pull/638
  
The performance degradation is worse with larger tables. The degradation is 
>300% on a 15GB table. After this fix, this degradation disappears.

There are other visible performance gains of this fix even when there is no 
degradation:

For a simple query on ORC/Parquet table through HiveReaders, I observed the 
improvement is about 10%-25% and the average improved percentage is 17.6%.

For TPCH tests on a 10 node cluster with Parquet tables + HiveReaders, the 
average improvement (of two runs) is 5.1%




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---