Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1001
Created another pull request #1072to merge my changes with the one done
with Padma's.
---
Github user priteshm commented on the issue:
https://github.com/apache/drill/pull/1001
@sachouche can you update this PR?
---
Github user ppadma commented on the issue:
https://github.com/apache/drill/pull/1001
@priteshm @sachouche This PR needs to be updated on top of changes made for
DRILL-5899.
---
Github user priteshm commented on the issue:
https://github.com/apache/drill/pull/1001
@ppadma @paul-rogers I see that @sachouche addressed the comments in the
JIRA - is this one ready to merge?
---
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1001
Paul, again thanks for the detailed review:
- I was able to address most of the feedback except for one
- I agree that expressions that can operate directly on the encoded UTF-8
string
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1001
Paul,
- I think you misunderstood the proposal
- Let me use an example
- select .. c1 like '%pattern1%' OR c1 like '%pattern2'..
- Assume c1 has 3 values [v1, v2, v3]
- The
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1001
- It was 50% for 1) and 50% for 2)
- Notice this breakdown depends on
o The number of Contains pattern for the same value (impacts 1))
o The pattern length (impacts both 1) and
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/1001
@sachouche, thanks for the first PR to Drill! Thanks for the detailed
explanation!
Before reviewing the code, a comment on the design:
> Added a new integer variable "asciiMode"
Github user ppadma commented on the issue:
https://github.com/apache/drill/pull/1001
@sachouche Do you have a breakdown of how much gain we got with 1 vs 2.
Since the changes for 2 are not straightforward and easy to maintain, I am
thinking performance gain vs. maintainability of
