[GitHub] drill issue #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 Stabali...

2018-01-11 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1023 Travis build is flakey. Rerunning build. ---

[GitHub] drill issue #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 Stabali...

2018-01-09 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1023 @paul-rogers For some reason this wan't included in a batch commit. After rebasing onto master I noticed some tests were failing sporadically so I've included a 1 line fix for DRILL-6003 in the last

[GitHub] drill issue #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 Stabali...

2017-12-11 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1023 @paul-rogers Applied review comments. I'll squash commits and mark this as ready to commit ---

[GitHub] drill issue #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 Stabali...

2017-12-04 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1023 @paul-rogers Can you take another pass at reviewing this? I have resolved conflicts with the graceful shutdown work. The graceful shutdown tests were also timing out on my laptop so I fixed them.

[GitHub] drill issue #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 Stabali...

2017-11-15 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1023 @arina-ielchiieva Spoke with @paul-rogers . This will likely introduce some conflicts for https://github.com/apache/drill/pull/921 . In an effort to lighten the workload for that contributor we'll

[GitHub] drill issue #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 Stabali...

2017-11-15 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1023 @ilooner please resolve conflicts. ---

[GitHub] drill issue #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 Stabali...

2017-11-10 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1023 For commit, let's do this: * With luck, Arina will commit two PRs this week that may conflict: PR #970, and PR #978. * Tim should rebase this PR on top of those changes once they are

[GitHub] drill issue #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 Stabali...

2017-11-10 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1023 *Note for batch committer:* Please do not squash the two commits in this PR. Please see the discussion on **pom.xml** for details. ---

[GitHub] drill issue #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 Stabali...

2017-11-06 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1023 Applied review comments ---

[GitHub] drill issue #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 Stabali...

2017-11-06 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1023 @arina-ielchiieva Please let me know if you have any additional comments. ---