Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1060
@parthchandra , @vrozov
I have done the following modifications:
- Renamed newly added files with the prefix "VL" with "VarLen" as suggested
by @parthchandra
- After talking
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1060
Parth,
- I have attached, within the DRILL-5846, two profiles with latest Apache
code and this PR request (bounds checks are off):
o Used one thread in each run
o I observe ~3x
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/1060
I feel putting this PR in without finalizing DRILL-6301 is putting the cart
before the horse. (BTW, it would help the discussion if the benchmarks were
published !). My observation based on
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1060
@parthchandra and @vrozov can you please let me know whether you are ok
with the changes.
Thanks!
---
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1060
I have updated this pull request with the following changes:
- Excluded the implicit column optimizations from this pull request (will
be included as part of another Drill Jira)
- Tuned a
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1060
@paul-rogers with regard to the design aspects that you brought up:
** Corrections about the proposed Design **
Your analysis somehow assumes the Vector is the one driving the loading
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1060
Before I reply to the provided comments I want first to thank both Parth
and Paul for taking time to review this Pull Request.
@parthchandra Regarding the High Level Comments
- FS
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/1060
Always a good idea to suggest an alternative in addition to identifying
challenges. I wonder if the code can resolve the questions raised by taking a
someone different approach:
1.
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/1060
This PR is a tough one. We generally like to avoid design discussions in
PRs; but I'm going to violate that rule.
This PR is based on the premise that each vector has all the information
