[GitHub] drill issue #1152: DRILL-6199: Add support for filter push down and partitio...

2018-03-20 Thread vdiravka
Github user vdiravka commented on the issue: https://github.com/apache/drill/pull/1152 +1 ---

[GitHub] drill issue #1152: DRILL-6199: Add support for filter push down and partitio...

2018-03-19 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1152 Thanks, @chunhui-shi - marked it as ready-to-commit since the original feature was already merged to 1.13. The batch committer this week can take another look as well. ---

[GitHub] drill issue #1152: DRILL-6199: Add support for filter push down and partitio...

2018-03-19 Thread chunhui-shi
Github user chunhui-shi commented on the issue: https://github.com/apache/drill/pull/1152 +1, good to me. ---

[GitHub] drill issue #1152: DRILL-6199: Add support for filter push down and partitio...

2018-03-19 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1152 @HanumathRao, @chunhui-shi any more comments from you? ---

[GitHub] drill issue #1152: DRILL-6199: Add support for filter push down and partitio...

2018-03-16 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1152 @HanumathRao thanks for the review. Applied code review comment. ---

[GitHub] drill issue #1152: DRILL-6199: Add support for filter push down and partitio...

2018-03-14 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1152 @chunhui-shi yes, you are correct, we are trying to find item star columns and push them into scan This case if F is optional then we don't have filter and there will no filter push

[GitHub] drill issue #1152: DRILL-6199: Add support for filter push down and partitio...

2018-03-08 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1152 @chunhui-shi or @HanumathRao can you please review this? ---

[GitHub] drill issue #1152: DRILL-6199: Add support for filter push down and partitio...

2018-03-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1152 @chunhui-shi please review. ---