Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1168
No I didn't.
Regards,
Salim
Regards,
Salim
-Original Message-
From: Kunal Khatua [notificati...@github.com]
Received: Tuesday, 10 Apr 2018, 14:01
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1168
@sachouche have you had a chance to test the generated JDBC driver with
Spotfire/SQuirreL ?
---
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/1168
I would recommend trying to setup a connection using Spotfire or Squirrel
and running a couple of metadata queries and a couple of queries on complex
data. (These have traditionally been areas
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1168
I successfully ran the test-suite and some advanced tests which loaded the
jdbc artifacts. Is this enough to validate the fix (and future exclusions to
keep the jar size in-check)? if not, what
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/1168
Classes from `avatica.metrics` are used in `JsonHandler`, `ProtobufHandler`
and `LocalService`. If Drill does not use these classes than I agree that we
can exclude it from `jdbc-all` jar.
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/1168
+1 LGTM. Thanks for making the changes.
---
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1168
@sohami can you please review this pull request?
Thanks!
---
