Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/1170
Over the last year, we've tended to favor including unit tests with each
PR. There don't seem to be any with this one, yet we are proposing to make a
fairly complex change. Perhaps tests can be
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/1170
BTW: thanks for tackling such a difficult, core issue in Drill. Drill
claims to be a) schema free and b) SQL compliant. SQL is based on operations
over relations with a fixed number of columns
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/1170
Sorry to say, I still disagree with this statement: "This pull request adds
logic to detect and eliminate dangling columns".
There was a prior discussion that `SELECT *` means "return
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1170
@parthchandra and @paul-rogers, I have added a comment within the Jira
[DRILL-6223](https://issues.apache.org/jira/browse/DRILL-6223); please let me
know what you think.
Thanks!
---
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/1170
The waters here run deep. Please see a detailed comment in
[DRILL-6223](https://issues.apache.org/jira/browse/DRILL-6223).
---
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1170
@parthchandra can you also please review this PR?
Thanks!
---
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/1170
I added a comment in the JIRA -
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1170
@amansinha100 can you please review this pull request?
Thanks!
---
