[GitHub] drill issue #1224: DRILL-6321: Customize Drill's conformance. Allow support ...

2018-05-02 Thread vvysotskyi
Github user vvysotskyi commented on the issue: https://github.com/apache/drill/pull/1224 @parthchandra, thanks for the explanation. @chunhui-shi, thanks for making changes, +1 ---

[GitHub] drill issue #1224: DRILL-6321: Customize Drill's conformance. Allow support ...

2018-05-01 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/1224 +1 Overall. Note that this is needed for implementing Lateral join and Unnest support. ---

[GitHub] drill issue #1224: DRILL-6321: Customize Drill's conformance. Allow support ...

2018-04-30 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/1224 @vvysotskyi The lateral join implementation committed in DRILL-6323 supports cross join for all conditions. The main difficulty in cross join is the management of the memory needed to produce

[GitHub] drill issue #1224: DRILL-6321: Customize Drill's conformance. Allow support ...

2018-04-29 Thread vvysotskyi
Github user vvysotskyi commented on the issue: https://github.com/apache/drill/pull/1224 As I understand from DRILL-1921, cross join was prevented due to the `CannotPlanException` exception at the planning stage. Can we get the same problem using `APPLY`? If yes, should be

[GitHub] drill issue #1224: DRILL-6321: Customize Drill's conformance. Allow support ...

2018-04-29 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1224 @chunhui-shi could you please address @vrozov comment? @vvysotskyi could you please alos take a look at PR? ---