[GitHub] drill issue #1232: DRILL-6094: Decimal data type enhancements

2018-04-26 Thread parthchandra 
Github user parthchandra commented on the issue:

https://github.com/apache/drill/pull/1232
  
+1 for the C++ part. Looks really good. 


---

[GitHub] drill issue #1232: DRILL-6094: Decimal data type enhancements

2018-04-26 Thread kkhatua 
Github user kkhatua commented on the issue:

https://github.com/apache/drill/pull/1232
  
I would recommend we wait till we have all testing complete, since this is 
a big feature.


---

[GitHub] drill issue #1232: DRILL-6094: Decimal data type enhancements

2018-04-20 Thread vvysotskyi 
Github user vvysotskyi commented on the issue:

https://github.com/apache/drill/pull/1232
  
@arina-ielchiieva, @parthchandra could you please take a look at this?


---