[GitHub] drill issue #570: DRILL-4834 decimal implementation is vulnerable to overflo...

2018-01-18 Thread daveoshinsky
Github user daveoshinsky commented on the issue: https://github.com/apache/drill/pull/570 The new VARDECIMAL one-size-fits-all decimal type, which this PR implements, will now be incorporated into the following new JIRA with additional changes and fixes for Drill 1.13:

[GitHub] drill issue #570: DRILL-4834 decimal implementation is vulnerable to overflo...

2017-02-28 Thread daveoshinsky
Github user daveoshinsky commented on the issue: https://github.com/apache/drill/pull/570 Would someone please review this? Or estimate when this can be started? It has now been months, and I just merged some conflicts that were introduced because it has been months since I

[GitHub] drill issue #570: DRILL-4834 decimal implementation is vulnerable to overflo...

2016-09-06 Thread daveoshinsky
Github user daveoshinsky commented on the issue: https://github.com/apache/drill/pull/570 Please review "one-size-fits-all" VARDECIMAL implementation in this pull request. Initially, it exists alongside all of the other decimal types, and is only used for variable-width BINARY