[GitHub] drill issue #686: DRILL-5117: Compile error when query a json file with 1000...

2016-12-14 Thread jinfengni
Github user jinfengni commented on the issue: https://github.com/apache/drill/pull/686 I think the cause of DRILL-1808 is same as DRILL-5117. We should mark them as related or duplicated in the JIRA. --- If your project is set up for it, you can reply to this email and have your

[GitHub] drill issue #686: DRILL-5117: Compile error when query a json file with 1000...

2016-12-14 Thread Serhii-Harnyk
Github user Serhii-Harnyk commented on the issue: https://github.com/apache/drill/pull/686 @sudheeshkatkam, when running for example test testEXTERNAL_SORT(), generates class CopierGen4, in which methods doSetup() and doEval() does not splits correctly. But with this fix them both

[GitHub] drill issue #686: DRILL-5117: Compile error when query a json file with 1000...

2016-12-14 Thread sudheeshkatkam
Github user sudheeshkatkam commented on the issue: https://github.com/apache/drill/pull/686 @Serhii-Harnyk I am curious how this resolves DRILL-1808. Can you provide some details? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] drill issue #686: DRILL-5117: Compile error when query a json file with 1000...

2016-12-14 Thread jinfengni
Github user jinfengni commented on the issue: https://github.com/apache/drill/pull/686 +1 LGTM. Thanks for the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] drill issue #686: DRILL-5117: Compile error when query a json file with 1000...

2016-12-14 Thread Serhii-Harnyk
Github user Serhii-Harnyk commented on the issue: https://github.com/apache/drill/pull/686 @jinfengni, could you please review new changes? I squashed all changes into single commit and rebased into master. --- If your project is set up for it, you can reply to this email and have