[GitHub] drill issue #926: DRILL-5269 Make DirectSubScan Jackson JSON deserializable

2017-09-13 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/926 rebased and squashed ---

[GitHub] drill issue #926: DRILL-5269 Make DirectSubScan Jackson JSON deserializable

2017-09-13 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/926 @paul-rogers Added unit test and adopted query to an existing parquet file. ---

[GitHub] drill issue #926: DRILL-5269 Make DirectSubScan Jackson JSON deserializable

2017-09-09 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/926 On the first comment, it sounds like the close is a placeholder, actual close is to be done after some refactoring? This is fine. Just a bit surprising to see a log message, but not actual close.

[GitHub] drill issue #926: DRILL-5269 Make DirectSubScan Jackson JSON deserializable

2017-09-09 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/926 @paul-rogers I guess you refer to a system/integration test (execute the query provided in JIRA), not a unit test. ---