[GitHub] drill issue #936: DRILL-5772: Add unit tests to indicate how utf-8 support c...

2017-10-17 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/936 @paul-rogers agree with you that charsets used in saffron properties should be defaulted in Drill to `UTF-8` since Drill can read UTF-8 data and it's strange that it would fail by

[GitHub] drill issue #936: DRILL-5772: Add unit tests to indicate how utf-8 support c...

2017-09-13 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/936 @arina-ielchiieva, my comments boil down to two points: 1. What happens if UTF-8 support in Drill is disabled? Do we have consistent handling of character data? Do we revert to ASCII? The

[GitHub] drill issue #936: DRILL-5772: Add unit tests to indicate how utf-8 support c...

2017-09-12 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/936 @arina-ielchiieva, thanks for the explanation. Drill's runtime framework assumes that data is either: 1. ASCII (or, at least, single-byte character set based on ASCII), or 2. UTF-8

[GitHub] drill issue #936: DRILL-5772: Add unit tests to indicate how utf-8 support c...

2017-09-12 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/936 @paul-rogers, the unit tests just show which influence saffron property has on Drill (since people in the community where asking how to enable support UTF-8 in Drill), a long with this PR