[GitHub] drill issue #950: DRILL-5431: SSL Support

2017-10-12 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/950 Go for it. I won't do any more commits until you give the all-clear. ---

[GitHub] drill issue #950: DRILL-5431: SSL Support

2017-10-06 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/950 Squashed and rebased on master again. ---

[GitHub] drill issue #950: DRILL-5431: SSL Support

2017-10-06 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/950 @laurentgo are you good with this? I'll open a new JIRA for the enhancements to the C++ client. ---

[GitHub] drill issue #950: DRILL-5431: SSL Support

2017-10-05 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/950 @arina-ielchiieva The `TestSSLConfig.testMissingKeystorePassword` test will fail if the exception is not thrown. The test is checking that the exception is in fact being thrown. Anyway, I added

[GitHub] drill issue #950: DRILL-5431: SSL Support

2017-10-03 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/950 Squashed the review changes and rebased on master. ---

[GitHub] drill issue #950: DRILL-5431: SSL Support

2017-10-03 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/950 @parthchandra could you please resolve the conflicts? ---